From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE63AC10F14 for ; Tue, 23 Apr 2019 10:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B740218D2 for ; Tue, 23 Apr 2019 10:26:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R71P1EHt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727404AbfDWK0y (ORCPT ); Tue, 23 Apr 2019 06:26:54 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37542 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfDWK0x (ORCPT ); Tue, 23 Apr 2019 06:26:53 -0400 Received: by mail-lj1-f194.google.com with SMTP id v13so437841ljk.4 for ; Tue, 23 Apr 2019 03:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1FroAomXJaDKJahsq0GryFxVKyy+ztefG4XwsaWwQLQ=; b=R71P1EHtE9ho7Q7VaICQcQfxwqZxvTIIoMzw3gql1mrrGGSUukyBT6JAymY6q8nFRd AekCHr6FRxyNKtmnj0b52GWN93roohjUvmdUEtBMNtd9SPDv0Rl+CZG2qkK/Qdq3pLpq ILNlgEgewBdvOZNx7LJOdRl3+AVEc9fshal3/fcJ1X0gULtD+QaQOY5gFTe6UDWCSgny Q2ezjf0z6XsHHW2lw18lwGk5LOwsaZR6UK9YG/g6VZl0g+9NHWEvBJjwJAOPzWuUBska JooQNKqfWDYfBDjNJVkQl3RpxYhJ6fATqku8Ay5l0YwG/tVUBKgc8Tc6uu9nlnXdLkL2 2Wjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1FroAomXJaDKJahsq0GryFxVKyy+ztefG4XwsaWwQLQ=; b=ulwd4jozBxHkQ9IysmrbCNdZBZpsSZJj05h3DkqYzzhOOsoTARUCcU+w2MPM4RrjS+ g+ASw5cxaB7q0ux+CFGxdkr8aAXgzho9WhK0z3gWvG5D5kxOLJ/w09bTEqYsheOWoBYI 2m+X/kG0RXdnSVGOHbYVJCxY5VWLdy+coya5Q56EYxN2IEq6zzumt7uWEJcpR8xAfHDV 0HYd2xpT2192+OgJ60MklyX9jt5uzt26yfQsOEVd4ea93WnGXAh3ug04+7rPRIJyYPzG LhYkGbyh0Zh4Qznh5drjN5vykE+0PRIllPQdL5qzxPIXgsyZRY7FHcWaEmLVW5tWhipg ESYA== X-Gm-Message-State: APjAAAVPcZo8usut+pnnwJrevJazwQeBCOBM8rGMTZ7GGYY/k4Y/crbW rBOSZGZghbJm/Stxi09ElIASNaHzA47wnkcqrpcMdQ== X-Google-Smtp-Source: APXvYqy1KhtlaeUH//E9N6SAdKJvZtTMP6eUA5vssp6lV0Aoj05LJ++zPDdRuPPv5R+y2Et7LCBBq7eDGMc9rZA8yW4= X-Received: by 2002:a2e:8703:: with SMTP id m3mr12709901lji.107.1556015211519; Tue, 23 Apr 2019 03:26:51 -0700 (PDT) MIME-Version: 1.0 References: <1555139666-948-1-git-send-email-hofrat@osadl.org> <1555139666-948-9-git-send-email-hofrat@osadl.org> In-Reply-To: <1555139666-948-9-git-send-email-hofrat@osadl.org> From: Linus Walleij Date: Tue, 23 Apr 2019 12:26:40 +0200 Message-ID: Subject: Re: [PATCH] ARM: u300: add missing check for kmalloc To: Nicholas Mc Guire Cc: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Mark Brown , Tony Lindgren , Mike Rapoport , Janusz Krzysztofik , Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicholas, thanks for your patch! On Sat, Apr 13, 2019 at 9:20 AM Nicholas Mc Guire wrote: > kmalloc return for bigrxbuf_virtual was not being checked - in case > of failure set status, cleanup bigtxbuf_virtual and baile out. > > Signed-off-by: Nicholas Mc Guire > Fixes: c7c8c78fdf6e ("ARM: 5667/3: U300 SSP/SPI board setup and test") This code is deleted from the kernel and the code had zero users before that, so no need to fix it! Sorry for your trouble! Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFEF1C10F14 for ; Tue, 23 Apr 2019 10:26:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB8A32175B for ; Tue, 23 Apr 2019 10:26:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OASWYjAg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R71P1EHt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB8A32175B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x0w3YQE+j/fH/YI2f0rAR5BJwj8u96wZmSgrWw+D5kI=; b=OASWYjAgCwxRsi 7aqO/etZLRxnooUHSSiz2mTPFp/0yNoCqgmJ55X8p/S0oOU89/QiB3xPBinRgHpVVQ58TrnEaXvIu iPMyMhXjNgnie9/aXGq07R2rEwqlHoQGmifK0rp1y9/sSI6rMEwgRESW03jnDp1BfvSX4Qc8pmzrg W0rZVRnGWz9WuneOKTOE+eaX8f9x7bm0k5YHfnVsDgvDiUKSzVYBgFPhFA7aSA/BIgzEp/df16dSg /jDNLIK8JrFon9L0ZEJ70qaKh2PZ8NYfHLareuFFi5wcDXl/ucJ5iHCOikgypqCDXJvIBkYBh3aQi TkahWm/+m6a1vFI6Kr6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIsdc-0006jD-SA; Tue, 23 Apr 2019 10:26:56 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIsdZ-0006it-Dd for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2019 10:26:55 +0000 Received: by mail-lj1-x241.google.com with SMTP id y6so12971426ljd.12 for ; Tue, 23 Apr 2019 03:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1FroAomXJaDKJahsq0GryFxVKyy+ztefG4XwsaWwQLQ=; b=R71P1EHtE9ho7Q7VaICQcQfxwqZxvTIIoMzw3gql1mrrGGSUukyBT6JAymY6q8nFRd AekCHr6FRxyNKtmnj0b52GWN93roohjUvmdUEtBMNtd9SPDv0Rl+CZG2qkK/Qdq3pLpq ILNlgEgewBdvOZNx7LJOdRl3+AVEc9fshal3/fcJ1X0gULtD+QaQOY5gFTe6UDWCSgny Q2ezjf0z6XsHHW2lw18lwGk5LOwsaZR6UK9YG/g6VZl0g+9NHWEvBJjwJAOPzWuUBska JooQNKqfWDYfBDjNJVkQl3RpxYhJ6fATqku8Ay5l0YwG/tVUBKgc8Tc6uu9nlnXdLkL2 2Wjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1FroAomXJaDKJahsq0GryFxVKyy+ztefG4XwsaWwQLQ=; b=DTPqhss7mhn+EvvZFr1NN8UBUiIGSjj3OWP+W2mpj8OUzMCMk3YDH5EQI7Qr38NyM1 8Ugk7QaVMUcZQA8nytw7spio/u5QY8ARtCxpIOlaDq2xYdJQYbKEnVf2SL6LwRKVHgtN fFu7fmS87nTH58u9uE/AuqtLrMGcP5dZItqcCK7unEdRQ7bhXBGJKnhWor+oKAJ5cEl2 R3W8VvloQMMqMz+dfONEXT0XMHM8TwFV6BmP6nCJk61QRB5S9rtZJ3zp/eHG5Le3pbso oxFCClGTX6LcM0CPz7WhZR/MwM10kmGdAuprIW4S29NM6KpbNAsPlIDviY+bVkH/ND9q Gtlg== X-Gm-Message-State: APjAAAWSFrYae5+lGe6wKdsjaaeD5ncnWYTtU3+fiF6bvF06x97wMwpN 9tz3uHDM6gob/z/Div9OOR0FRY84WpOdaIoT1Qb0Ww== X-Google-Smtp-Source: APXvYqy1KhtlaeUH//E9N6SAdKJvZtTMP6eUA5vssp6lV0Aoj05LJ++zPDdRuPPv5R+y2Et7LCBBq7eDGMc9rZA8yW4= X-Received: by 2002:a2e:8703:: with SMTP id m3mr12709901lji.107.1556015211519; Tue, 23 Apr 2019 03:26:51 -0700 (PDT) MIME-Version: 1.0 References: <1555139666-948-1-git-send-email-hofrat@osadl.org> <1555139666-948-9-git-send-email-hofrat@osadl.org> In-Reply-To: <1555139666-948-9-git-send-email-hofrat@osadl.org> From: Linus Walleij Date: Tue, 23 Apr 2019 12:26:40 +0200 Message-ID: Subject: Re: [PATCH] ARM: u300: add missing check for kmalloc To: Nicholas Mc Guire X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_032653_515079_895723AE X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Rapoport , Tony Lindgren , Shawn Guo , Sascha Hauer , Janusz Krzysztofik , Russell King , "linux-kernel@vger.kernel.org" , Mark Brown , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nicholas, thanks for your patch! On Sat, Apr 13, 2019 at 9:20 AM Nicholas Mc Guire wrote: > kmalloc return for bigrxbuf_virtual was not being checked - in case > of failure set status, cleanup bigtxbuf_virtual and baile out. > > Signed-off-by: Nicholas Mc Guire > Fixes: c7c8c78fdf6e ("ARM: 5667/3: U300 SSP/SPI board setup and test") This code is deleted from the kernel and the code had zero users before that, so no need to fix it! Sorry for your trouble! Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel