From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E22C433DF for ; Wed, 12 Aug 2020 06:48:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDC512076B for ; Wed, 12 Aug 2020 06:48:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VpYvDBU0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726718AbgHLGs4 (ORCPT ); Wed, 12 Aug 2020 02:48:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726629AbgHLGs4 (ORCPT ); Wed, 12 Aug 2020 02:48:56 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BF62C06174A for ; Tue, 11 Aug 2020 23:48:56 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id m22so1020660ljj.5 for ; Tue, 11 Aug 2020 23:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J31UG4xZfaTIfqQug3jDowpRaMecAJvi+cR7RWW/6Kc=; b=VpYvDBU0f25AQ9m3GDVHoUNKGkkDhwbrnVrRQGv9qnG12eXf4IY7Tpb4nKzyaA5GnR AHtuTeNxArmL+axuWPrSumZ/XebgP77RRcTE+GQkB8i0oVWOsRSw3z0wBHwftrhm/jFP CvNNCuSx/bwusMpWV+mV9dc66XOoA5fxPM26P+c7ZZjLqGy7wW5QVw4vw9fqIqUTa5cF PSVEIwmtvgOvsay+aDb9WpoGr6AwxjmjiR43zYa7iWp4i2u/PL9XMjOAPLVij/0Pn1yV +mULTLZ5F3Go7VxJFDc79NuukaGuX283qR5QhEyWTK2QvmhsNtuRRq7Luw33QF6WG0Zs U7Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J31UG4xZfaTIfqQug3jDowpRaMecAJvi+cR7RWW/6Kc=; b=LmLta2sXx6lBWLxVljEummR+eQgwq7fhpSZot9K7cf3yc7hbbYTPNuUYFhT1QisX0d cMse4sQcn94CUMn7F8NpafiOHewIprg8GxHklFX0lTV+5VohpPQAgisH9OIJOQ4g4ATq FKIF/390fjo7nOKSrrjMNuocRZyGJxyIjzM8NvDtFit9hC1iE5OsCY1OByxfBLpjLeH4 KJ76/UE+i17DnwA/RvLVzjzbB7rjiitnJ0QLckcR8ttBe9PSNhEQrG+hpzYjWakDTZA4 KtitdXPo6rwHRdlsSboOKu9hU1XRPqaIeNdSVBrkF/Ul5yIgFFt1en0IngPzcEKq3NRF KJdA== X-Gm-Message-State: AOAM533YX94VCvH+YkNmuFtD2Q3XNK++wkTpJKCoH4u8SLnuX+kaH4T0 dS/HJb4f+Q4WXV3/CyXF9pZMECyjKabhUnXynBgApw== X-Google-Smtp-Source: ABdhPJxHxwmcGrskpI/3oFiCVwxSZLG0pwpgInuuMV19jZuo3wuyU4iLrgAO3cTWdJQBKcHLd6uIZH9VRx2ad2MKIIE= X-Received: by 2002:a2e:8144:: with SMTP id t4mr4977361ljg.100.1597214934520; Tue, 11 Aug 2020 23:48:54 -0700 (PDT) MIME-Version: 1.0 References: <20200720203506.3883129-1-linus.walleij@linaro.org> <20200721083228.GA283099@ravnborg.org> In-Reply-To: <20200721083228.GA283099@ravnborg.org> From: Linus Walleij Date: Wed, 12 Aug 2020 08:48:42 +0200 Message-ID: Subject: Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings To: Sam Ravnborg Cc: Lee Jones , Daniel Thompson , Jingoo Han , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jul 21, 2020 at 10:32 AM Sam Ravnborg wrote: > > +description: | > > + The Kinetic Technologies KTD253 is a white LED backlight that is > > + controlled by a single GPIO line. If you just turn on the backlight > > + it goes to maximum backlight then you can set the level of backlight > > + using pulses on the enable wire. > > No $ref for common.yaml? Since this is a backlight, and we do not have common bindings for, backlight I first looked into using the LED bindings in ../common.yaml, but that has several problems, it cannot really be used for backlight. Backlight doesn't have "triggers", patterns, flash properties, the function is also pretty much evident. So I will look into creating a new common for backlight. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB25C433DF for ; Wed, 12 Aug 2020 06:48:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 957272076B for ; Wed, 12 Aug 2020 06:48:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VpYvDBU0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 957272076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 907CF6E8A6; Wed, 12 Aug 2020 06:48:57 +0000 (UTC) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 318286E8A6 for ; Wed, 12 Aug 2020 06:48:56 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id v4so1044346ljd.0 for ; Tue, 11 Aug 2020 23:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J31UG4xZfaTIfqQug3jDowpRaMecAJvi+cR7RWW/6Kc=; b=VpYvDBU0f25AQ9m3GDVHoUNKGkkDhwbrnVrRQGv9qnG12eXf4IY7Tpb4nKzyaA5GnR AHtuTeNxArmL+axuWPrSumZ/XebgP77RRcTE+GQkB8i0oVWOsRSw3z0wBHwftrhm/jFP CvNNCuSx/bwusMpWV+mV9dc66XOoA5fxPM26P+c7ZZjLqGy7wW5QVw4vw9fqIqUTa5cF PSVEIwmtvgOvsay+aDb9WpoGr6AwxjmjiR43zYa7iWp4i2u/PL9XMjOAPLVij/0Pn1yV +mULTLZ5F3Go7VxJFDc79NuukaGuX283qR5QhEyWTK2QvmhsNtuRRq7Luw33QF6WG0Zs U7Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J31UG4xZfaTIfqQug3jDowpRaMecAJvi+cR7RWW/6Kc=; b=XaGv6tTUpl/Bzqjzrnvqu58AfSh22XVFPAmYJACO9cnoaNzDkGJG3UqsLMkIVG6aJp qbX5QbyjMSankr5G6scN+ui8DiLbjuw2m0adaXgiVGans42PkpGUPpN57v32NQ5prlSw 32q/3sZUGR/hiH4lbqtZxVhwjM0na1yfgeAZRfohI3FyMRyM9bTqXuYvf1kYCix9hV3d i/pjgCchDOMFbcfpzJaDlCfXlIpDtBeH9w2HajFCSTFETS6Ih2adQokbjfRLX3lm2ITW Yc0eHHO/tpZMsjTwSkGLwAmJ3SMXTEIJdpfe8I8SP/L7mRkeEWqhzsoXOfsls3fouCMy W2mQ== X-Gm-Message-State: AOAM532OF5mSqFqnaZXmUwWOyJ+KT0DaubSYEN09HjVnSqDEW5LnUfcE brqD9sSOP5/faBaqeCBKZq6rbGGBeqPLn53AEZuTXw== X-Google-Smtp-Source: ABdhPJxHxwmcGrskpI/3oFiCVwxSZLG0pwpgInuuMV19jZuo3wuyU4iLrgAO3cTWdJQBKcHLd6uIZH9VRx2ad2MKIIE= X-Received: by 2002:a2e:8144:: with SMTP id t4mr4977361ljg.100.1597214934520; Tue, 11 Aug 2020 23:48:54 -0700 (PDT) MIME-Version: 1.0 References: <20200720203506.3883129-1-linus.walleij@linaro.org> <20200721083228.GA283099@ravnborg.org> In-Reply-To: <20200721083228.GA283099@ravnborg.org> From: Linus Walleij Date: Wed, 12 Aug 2020 08:48:42 +0200 Message-ID: Subject: Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings To: Sam Ravnborg X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jingoo Han , Daniel Thompson , Lee Jones , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jul 21, 2020 at 10:32 AM Sam Ravnborg wrote: > > +description: | > > + The Kinetic Technologies KTD253 is a white LED backlight that is > > + controlled by a single GPIO line. If you just turn on the backlight > > + it goes to maximum backlight then you can set the level of backlight > > + using pulses on the enable wire. > > No $ref for common.yaml? Since this is a backlight, and we do not have common bindings for, backlight I first looked into using the LED bindings in ../common.yaml, but that has several problems, it cannot really be used for backlight. Backlight doesn't have "triggers", patterns, flash properties, the function is also pretty much evident. So I will look into creating a new common for backlight. Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel