From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <6c866a82-8f54-575e-0376-fc9653078b7c@kernel.org> References: <1467251334-30594-1-git-send-email-linus.walleij@linaro.org> <1467251334-30594-11-git-send-email-linus.walleij@linaro.org> <6c866a82-8f54-575e-0376-fc9653078b7c@kernel.org> From: Linus Walleij Date: Tue, 5 Jul 2016 15:37:22 +0200 Message-ID: Subject: Re: [PATCH 10/10 v4] iio: pressure: bmp280: read calibration data once To: Jonathan Cameron Cc: "linux-iio@vger.kernel.org" , Akinobu Mita , "H. Nikolaus Schaller" , Matt Ranostay , Peter Meerwald-Stadler , Christoph Mair , Vlad Dogaru , Hartmut Knaack , Marek Belisko , Eric Andersson , Neil Brown Content-Type: text/plain; charset=UTF-8 List-ID: On Sun, Jul 3, 2016 at 12:23 PM, Jonathan Cameron wrote: > On 30/06/16 02:48, Linus Walleij wrote: >> The calibration data is described as coming from an E2PROM and that >> means it does not change. Just read it once at probe time and store >> it in the device state container. Also toss the calibration data >> into the entropy pool since it is device unique. >> >> Reviewed-by: Vlad Dogaru >> Signed-off-by: Linus Walleij > Applied with a whole 1 line of fuzz ;) Thanks for applying and fixing my silly mistakes along the road. Part of the churn comes from massaging review comments into the patch set, I guess I just need to be more careful to build at every step along the way when doing that. But the patch splitting up the driver was driving me nuts with the constant rebasing and drew a lot of focus, I blame it all on that one. Mostly the splitting and adding SPI interface was about obsoleting the misc driver so it's for a higher cause.... Yours, Linus Walleij