From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] gpiolib: Show correct direction from the beginning Date: Thu, 20 Sep 2018 15:36:26 -0700 Message-ID: References: <20180914070839.4667-1-ricardo.ribalda@gmail.com> <20180914070839.4667-2-ricardo.ribalda@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: timur@kernel.org Cc: Ricardo Ribalda Delgado , Stephen Boyd , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Thu, Sep 20, 2018 at 5:35 AM Timur Tabi wrote: > On 9/20/18 12:23 AM, Linus Walleij wrote: > > I think most gpiochips easily survives calling the .get_direction() > > early, Qualcomm's stand out here. > > > > Now that we have .valid_mask in the gpiochip could we simply just > > add this back, resepecting valid_mask and avoid checking the > > direction of precisely these GPIOs? > > Can you be more specific? One of the proposals made previously was to > add a check in msm_gpio_get_direction(), but that was rejected because > the consensus was the valid_mask checks in gpiolib are sufficient. What I mean is that $SUBJECT patch might not hurt Qualcomms GPIOs (not crash the platform) if and only if it is augmented to not try to get the initial direction from lines masked off in .valid_mask if .need_valid_mask is true. Whether it makes sense semantically is a different debate, but it seems possible to reintroduce calling .get_direction() without hurting anyone. Yours, Linus Walleij