From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817C9C433EF for ; Fri, 24 Jun 2022 06:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229837AbiFXGZn (ORCPT ); Fri, 24 Jun 2022 02:25:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiFXGZm (ORCPT ); Fri, 24 Jun 2022 02:25:42 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E62AD50B1A for ; Thu, 23 Jun 2022 23:25:40 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id x38so2864061ybd.9 for ; Thu, 23 Jun 2022 23:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3WRM/jegNDF7MJkfKHHwllsaLEoDBdN6Clej3P/Y4lI=; b=D530abNNVW04AkYbW5cBkqRo9d5231SDuKgu4fDW7AaH4jE4mVT5OFUcx+HC+Oclit 8chp6jbBbNGEk0P3WtO4E/T3LUNKEl4CZYHCB8kDC72f1y33a5Jl8zQdYz/7h8rofzI9 molKE7wLhlBuYhpF8PG8/LP34IC1bse0Fsc34U93w63mTGtgoR/kSBJU3IAZV6RJIDoX vewJ811NMZGN+RX3N8aqUoPR3IjQiufTbvKsQ7KYzVX9rrK377CYprRQ3djZSphTlWnA kr90KekhWjo1rMkgj80oOFkzfZZBsx36WCy428UlmluupR0YrGtaLVqkr96HnOa5PXRo +Ovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3WRM/jegNDF7MJkfKHHwllsaLEoDBdN6Clej3P/Y4lI=; b=Z0ZHZkTm4b/pLAW/Mua1y93dH49C7EyhcxDwSYuF5hVjPT/H/Q0ZSH6L0bILz9KAEv UkMRXAMvDqIn6tivs3Lw4oMdRHI4mmovxPImIAev5rwOfeznkfA0wTb0L6tskffB0be1 Bm1eWx+68vPknYdvGC3AczVygUJYVj8swvnohNuWCt+FugLoQ81s6tbtLU5OYJbbP1K6 44VrUiJqfxTQPzUmUBJRb9ItGBRs05XzdKTs2S8zI7cSIbdExLsTkELd04+x3lb9WkIq qSl+4B9Tfj91JS1ceGR4/JuWhP6jzDXuNwJy99Vrk02IK4AVXgvfia487yCwfKy9ALXy PG3w== X-Gm-Message-State: AJIora87OLqPAKZPvtCOKYW+i6qxy/WpfGPp4zNjjLwbrSxMUC76rFXd AueZIYAlKeFybz6jq16NyavBcMlJLAPsXWlOnim2gA== X-Google-Smtp-Source: AGRyM1sT2bkts91ktfEoGKQU7+LXoN5AOODxkIaXfQ8ZFlQvpAh1fKz3hE77tVb6U5oyh1MbZfwUv7onSbM8QOjAaWU= X-Received: by 2002:a25:1f57:0:b0:669:b6fa:167e with SMTP id f84-20020a251f57000000b00669b6fa167emr4052148ybf.295.1656051940195; Thu, 23 Jun 2022 23:25:40 -0700 (PDT) MIME-Version: 1.0 References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-13-peterwu.pub@gmail.com> In-Reply-To: From: Linus Walleij Date: Fri, 24 Jun 2022 08:25:29 +0200 Message-ID: Subject: Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support To: ChiaEn Wu Cc: lee.jones@linaro.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sre@kernel.org, chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com, deller@gmx.de, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com, alice_chen@richtek.com, linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, cy_huang@richtek.com, chiaen_wu@richtek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Jun 24, 2022 at 8:23 AM Linus Walleij wrote: > Thanks for your patch! > > On Thu, Jun 23, 2022 at 1:58 PM ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > Add Mediatek MT6370 current sink type LED Indicator driver. > > > > Signed-off-by: ChiYuan Huang > (...) > > drivers/leds/Kconfig | 11 + > > drivers/leds/Makefile | 1 + > > drivers/leds/leds-mt6370.c | 989 +++++++++++++++++++++++++++++++++++++++++++++ > > There is a drivers/leds/flash subdirectory these days, put the driver > in that directory instead. Sorry I'm commenting on the wrong patch. I meant this one. Move that into drivers/leds/flash drivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++ Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA5FCC433EF for ; Fri, 24 Jun 2022 06:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oKLJeJf95FyiK953D/iJHIEuhSzCF0yohDxj7oD84e4=; b=svxOOwv8f2d774 On6iv0e5jIKpbpo3Ux/Up5Iqe0byy+nZ4e2XKdySova/6UxRUlR82KODm+gXSx7Pv+eguQ5OiReBK 8rtALAuBV0rtqvdhnRC8iYIA+9l7zoUY28JzhKuY8OFsmDE0VGwYKJOHNO+eN80ppgn1x7lqAeK/o ZIMhoNLBUPkJfPTzDKU1LAUgpzcKxRj5TTSx9q2mUxNFeBpP6mN7xY+OrSu2XWB3eggSg8MaW2+XE 4PgPja/31TXh/hHJqVBUnCPkwqgmsb3Baccam2ZMu+6AcBz/2DdTN8rMWdhESp+ax9nUhl/PHUouv /siBR9VhpNWbjQhJ3Vbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4clF-000pyN-Gt; Fri, 24 Jun 2022 06:25:45 +0000 Received: from mail-yb1-xb33.google.com ([2607:f8b0:4864:20::b33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4clB-000pwz-NP for linux-arm-kernel@lists.infradead.org; Fri, 24 Jun 2022 06:25:43 +0000 Received: by mail-yb1-xb33.google.com with SMTP id x184so135438ybg.12 for ; Thu, 23 Jun 2022 23:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3WRM/jegNDF7MJkfKHHwllsaLEoDBdN6Clej3P/Y4lI=; b=D530abNNVW04AkYbW5cBkqRo9d5231SDuKgu4fDW7AaH4jE4mVT5OFUcx+HC+Oclit 8chp6jbBbNGEk0P3WtO4E/T3LUNKEl4CZYHCB8kDC72f1y33a5Jl8zQdYz/7h8rofzI9 molKE7wLhlBuYhpF8PG8/LP34IC1bse0Fsc34U93w63mTGtgoR/kSBJU3IAZV6RJIDoX vewJ811NMZGN+RX3N8aqUoPR3IjQiufTbvKsQ7KYzVX9rrK377CYprRQ3djZSphTlWnA kr90KekhWjo1rMkgj80oOFkzfZZBsx36WCy428UlmluupR0YrGtaLVqkr96HnOa5PXRo +Ovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3WRM/jegNDF7MJkfKHHwllsaLEoDBdN6Clej3P/Y4lI=; b=u7ayYcH55hoO+VxPmDxbTF+BJMXNVdDh4GcuoJC2YAh+9tDEmD9FBf565D56XZ/gC9 R7U7bDHH0gSnSVZ9J14H20208D9i/DDB4t2tFyLXjTig/MepjD9qeaVTEsQGkCRa0zI8 pHxfd+g9Z8C2uVx7cQEp8n4wnbgCfgIBPDa2UMnvFb73w2vfUgXF0mOgNwRBHhUUbH+i Sg8RwD5r/7fWzxpy7DW1dnAFpPcPJWyeYUo5jJtYdf0JzD3O+2ZaRP73vPQBr6CXx3Qp ioaWoCLw/kJJD2CH+Z1OCqiZ/WWQTbA1maeoYE7I57bztTuUBm88UEiNTM1ZF7ho9STj wk4Q== X-Gm-Message-State: AJIora9DMN7Hf/3zMbQUk+Cjj6XT//g6FzG+MHvrA6AZAzxhy6rx2hJZ QRbicMEQ+LwtxG3T+QUNNIZa8Ksl9+4swptGQvDjNA== X-Google-Smtp-Source: AGRyM1sT2bkts91ktfEoGKQU7+LXoN5AOODxkIaXfQ8ZFlQvpAh1fKz3hE77tVb6U5oyh1MbZfwUv7onSbM8QOjAaWU= X-Received: by 2002:a25:1f57:0:b0:669:b6fa:167e with SMTP id f84-20020a251f57000000b00669b6fa167emr4052148ybf.295.1656051940195; Thu, 23 Jun 2022 23:25:40 -0700 (PDT) MIME-Version: 1.0 References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-13-peterwu.pub@gmail.com> In-Reply-To: From: Linus Walleij Date: Fri, 24 Jun 2022 08:25:29 +0200 Message-ID: Subject: Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support To: ChiaEn Wu Cc: lee.jones@linaro.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sre@kernel.org, chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com, deller@gmx.de, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com, alice_chen@richtek.com, linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, cy_huang@richtek.com, chiaen_wu@richtek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220623_232541_790072_691B4793 X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 24, 2022 at 8:23 AM Linus Walleij wrote: > Thanks for your patch! > > On Thu, Jun 23, 2022 at 1:58 PM ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > Add Mediatek MT6370 current sink type LED Indicator driver. > > > > Signed-off-by: ChiYuan Huang > (...) > > drivers/leds/Kconfig | 11 + > > drivers/leds/Makefile | 1 + > > drivers/leds/leds-mt6370.c | 989 +++++++++++++++++++++++++++++++++++++++++++++ > > There is a drivers/leds/flash subdirectory these days, put the driver > in that directory instead. Sorry I'm commenting on the wrong patch. I meant this one. Move that into drivers/leds/flash drivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++ Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 864F5C433EF for ; Fri, 24 Jun 2022 06:33:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 70B0510F0C7; Fri, 24 Jun 2022 06:33:54 +0000 (UTC) Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02D8A112694 for ; Fri, 24 Jun 2022 06:25:40 +0000 (UTC) Received: by mail-yb1-xb35.google.com with SMTP id h187so681144ybg.0 for ; Thu, 23 Jun 2022 23:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3WRM/jegNDF7MJkfKHHwllsaLEoDBdN6Clej3P/Y4lI=; b=D530abNNVW04AkYbW5cBkqRo9d5231SDuKgu4fDW7AaH4jE4mVT5OFUcx+HC+Oclit 8chp6jbBbNGEk0P3WtO4E/T3LUNKEl4CZYHCB8kDC72f1y33a5Jl8zQdYz/7h8rofzI9 molKE7wLhlBuYhpF8PG8/LP34IC1bse0Fsc34U93w63mTGtgoR/kSBJU3IAZV6RJIDoX vewJ811NMZGN+RX3N8aqUoPR3IjQiufTbvKsQ7KYzVX9rrK377CYprRQ3djZSphTlWnA kr90KekhWjo1rMkgj80oOFkzfZZBsx36WCy428UlmluupR0YrGtaLVqkr96HnOa5PXRo +Ovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3WRM/jegNDF7MJkfKHHwllsaLEoDBdN6Clej3P/Y4lI=; b=zA0zS5zQpkf+WHx+jPjCSZoKkzIeV7MzxcLtl0rBSpi8mI2Sr10zd1/5tHW1nI5aab eWv5hc7/zouogjwiNjseNS7Qbbef5449v3hS34KSZnZ+oLBd9dK16E5FyYUldLzj/3J8 H6WwR3wCLeitE7ZqlFStmGKJrwkGX/d5b18QB0zgphLB+0/CxnVOCH+P+r6Dv8lZqF3W jZdERej1FzjuROoH/JOTIrGCyzGxQfDXlkclg8RVrC8OxOmUvE8sbsv93LkUR3p7PcVT Qi6Eu9Eswys9725rn42ByHF1Sc2Th3styOnnKHWGRXe1pTW/7DF8+Ll13BZTlrNeLxf9 ZKVw== X-Gm-Message-State: AJIora+1lb6wdsUnk/KJFH9gR7zih5elaQEKKrYp9B/CAzN568OMNeQG Zx7pLx9zAUT5TSuvOLeZANuNnPD3XYOd8MdDjqxpNw== X-Google-Smtp-Source: AGRyM1sT2bkts91ktfEoGKQU7+LXoN5AOODxkIaXfQ8ZFlQvpAh1fKz3hE77tVb6U5oyh1MbZfwUv7onSbM8QOjAaWU= X-Received: by 2002:a25:1f57:0:b0:669:b6fa:167e with SMTP id f84-20020a251f57000000b00669b6fa167emr4052148ybf.295.1656051940195; Thu, 23 Jun 2022 23:25:40 -0700 (PDT) MIME-Version: 1.0 References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-13-peterwu.pub@gmail.com> In-Reply-To: From: Linus Walleij Date: Fri, 24 Jun 2022 08:25:29 +0200 Message-ID: Subject: Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support To: ChiaEn Wu Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, heikki.krogerus@linux.intel.com, krzysztof.kozlowski+dt@linaro.org, alice_chen@richtek.com, linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, lgirdwood@gmail.com, cy_huang@richtek.com, pavel@ucw.cz, lee.jones@linaro.org, linux-leds@vger.kernel.org, daniel.thompson@linaro.org, deller@gmx.de, chunfeng.yun@mediatek.com, linux@roeck-us.net, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, szunichen@gmail.com, chiaen_wu@richtek.com, broonie@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, jingoohan1@gmail.com, linux-usb@vger.kernel.org, sre@kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, gregkh@linuxfoundation.org, jic23@kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 24, 2022 at 8:23 AM Linus Walleij wrote: > Thanks for your patch! > > On Thu, Jun 23, 2022 at 1:58 PM ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > Add Mediatek MT6370 current sink type LED Indicator driver. > > > > Signed-off-by: ChiYuan Huang > (...) > > drivers/leds/Kconfig | 11 + > > drivers/leds/Makefile | 1 + > > drivers/leds/leds-mt6370.c | 989 +++++++++++++++++++++++++++++++++++++++++++++ > > There is a drivers/leds/flash subdirectory these days, put the driver > in that directory instead. Sorry I'm commenting on the wrong patch. I meant this one. Move that into drivers/leds/flash drivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++ Yours, Linus Walleij