From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qa0-f46.google.com (mail-qa0-f46.google.com [209.85.216.46]) by mail.openembedded.org (Postfix) with ESMTP id E647F6B6B7 for ; Wed, 18 Feb 2015 03:40:44 +0000 (UTC) Received: by mail-qa0-f46.google.com with SMTP id n4so29441265qaq.5 for ; Tue, 17 Feb 2015 19:40:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=TsjR+/KTiowTLAvqVy8wEamhkZHTvg7zySMxh1V7wXc=; b=vg6zz6dheLn5TarIY4Go81SMbAsVW/nNXznEiGsA6pb9ofQTEaIH3tCIlPOcH8oqBz ZYFPOsrzkJ9WgL+YMLG7L3HkYODdqynOZOllAUPXQ6rVICM4BWQsxpuXcKlcdpQe97tv Y1/CLZxJe1v7shnTn12aRpW9lg3oLpKptmFkaMmKBlU14SI91avdqc/k+mW/NwTpzGa7 HLlgkbQ4toGBQFbHL6iRA5WsdYmKnm9XFEGvYftCrnXHvznQ3ZP0gRYjEYtF04fhhc2M G6blyjGrC1fO7KqOQkPD30dAUC2iAn5om4C6ZZHRjpDVeLdhjqKnCnEsmGHG/P0SI2OX Y/kg== MIME-Version: 1.0 X-Received: by 10.140.41.169 with SMTP id z38mr786646qgz.56.1424230845592; Tue, 17 Feb 2015 19:40:45 -0800 (PST) Received: by 10.96.118.39 with HTTP; Tue, 17 Feb 2015 19:40:45 -0800 (PST) Received: by 10.96.118.39 with HTTP; Tue, 17 Feb 2015 19:40:45 -0800 (PST) In-Reply-To: <54E375B2.9080002@windriver.com> References: <1424180525-4138-1-git-send-email-patrick.ohly@intel.com> <54E3723B.9050606@windriver.com> <54E375B2.9080002@windriver.com> Date: Tue, 17 Feb 2015 21:40:45 -0600 Message-ID: From: Dan McGregor To: Mark Hatle Cc: Christopher Larson , Patches and discussions about the oe-core layer Subject: Re: [PATCH] package_rpm.bbclass: support packaging of symlinks to directories X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 03:40:45 -0000 Content-Type: multipart/alternative; boundary=001a11c11dbaa13aac050f549523 --001a11c11dbaa13aac050f549523 Content-Type: text/plain; charset=UTF-8 On 17 Feb 2015 11:09, "Mark Hatle" wrote: > > On 2/17/15 10:57 AM, Christopher Larson wrote: > > > > On Tue, Feb 17, 2015 at 9:54 AM, Mark Hatle > > wrote: > > > > On 2/17/15 7:42 AM, Patrick Ohly wrote: > > > os.walk() returns symlinks to directories in the "dirs" lists, > > > but then never enters them by default. As a result, the old > > > code applied neither the directory handling (because that > > > is active once a directory gets entered) nor the file handling, > > > and thus never packaged such symlinks. > > > > > > The fix is simple: find such special directory entries and move > > > them to the "files" list. > > > > I'm curious, what is the problem that is being fixed with this. > > > > Normally you don't want to walk into symlinks to directories, as either you want > > to capture the symlink itself -- or the symlink is pointing to something you > > don't have access to when packaging (i.e. /proc). > > > > > > This patch doesn't make it walk into the directory symlinks, it moves them into > > the files list rather than the dirs list so they'll be captured themselves, as > > far as I can tell from reading it. > > Ok.. I missed that bit.. I'm still curious what this fixes. > I haven't tried myself, but I expect it helps with the /usr merge. > --Mark > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core --001a11c11dbaa13aac050f549523 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 17 Feb 2015 11:09, "Mark Hatle" <mark.hatle@windriver.com> wrote:
>
> On 2/17/15 10:57 AM, Christopher Larson wrote:
> >
> > On Tue, Feb 17, 2015 at 9:54 AM, Mark Hatle <mark.hatle@windriver.com
> > <mailto:mark.hatle= @windriver.com>> wrote:
> >
> >=C2=A0 =C2=A0 =C2=A0On 2/17/15 7:42 AM, Patrick Ohly wrote:
> >=C2=A0 =C2=A0 =C2=A0> os.walk() returns symlinks to directories= in the "dirs" lists,
> >=C2=A0 =C2=A0 =C2=A0> but then never enters them by default. As= a result, the old
> >=C2=A0 =C2=A0 =C2=A0> code applied neither the directory handli= ng (because that
> >=C2=A0 =C2=A0 =C2=A0> is active once a directory gets entered) = nor the file handling,
> >=C2=A0 =C2=A0 =C2=A0> and thus never packaged such symlinks. > >=C2=A0 =C2=A0 =C2=A0>
> >=C2=A0 =C2=A0 =C2=A0> The fix is simple: find such special dire= ctory entries and move
> >=C2=A0 =C2=A0 =C2=A0> them to the "files" list.
> >
> >=C2=A0 =C2=A0 =C2=A0I'm curious, what is the problem that is b= eing fixed with this.
> >
> >=C2=A0 =C2=A0 =C2=A0Normally you don't want to walk into symli= nks to directories, as either you want
> >=C2=A0 =C2=A0 =C2=A0to capture the symlink itself -- or the symlin= k is pointing to something you
> >=C2=A0 =C2=A0 =C2=A0don't have access to when packaging (i.e. = /proc).
> >
> >
> > This patch doesn't make it walk into the directory symlinks, = it moves them into
> > the files list rather than the dirs list so they'll be captur= ed themselves, as
> > far as I can tell from reading it.
>
> Ok.. I missed that bit.. I'm still curious what this fixes.
>

I haven't tried myself, but I expect it helps with the /= usr merge.

> --Mark
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedd= ed-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core=

--001a11c11dbaa13aac050f549523--