From: Soheil Hassas Yeganeh <soheil@google.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Andy Lutomirski <luto@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2 net-next 0/2] tcp: mmap: rework zerocopy receive
Date: Wed, 25 Apr 2018 21:20:40 -0400 [thread overview]
Message-ID: <CACSApvZF8CJqcRx7FGkMGitBiC6m0=_FT9XRZ=VV07U62wGM3Q@mail.gmail.com> (raw)
In-Reply-To: <20180425214307.159264-1-edumazet@google.com>
On Wed, Apr 25, 2018 at 5:43 PM, Eric Dumazet <edumazet@google.com> wrote:
> syzbot reported a lockdep issue caused by tcp mmap() support.
>
> I implemented Andy Lutomirski nice suggestions to resolve the
> issue and increase scalability as well.
>
> First patch is adding a new setsockopt() operation and changes mmap()
> behavior.
>
> Second patch changes tcp_mmap reference program.
>
> v2:
> Added a missing page align of zc->length in tcp_zerocopy_receive()
> Properly clear zc->recv_skip_hint in case user request was completed.
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Thank you Eric for the nice redesign!
> Eric Dumazet (2):
> tcp: add TCP_ZEROCOPY_RECEIVE support for zerocopy receive
> selftests: net: tcp_mmap must use TCP_ZEROCOPY_RECEIVE
>
> include/uapi/linux/tcp.h | 8 ++
> net/ipv4/tcp.c | 189 +++++++++++++------------
> tools/testing/selftests/net/tcp_mmap.c | 63 +++++----
> 3 files changed, 142 insertions(+), 118 deletions(-)
>
> --
> 2.17.0.441.gb46fe60e1d-goog
>
next prev parent reply other threads:[~2018-04-26 1:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 21:43 [PATCH v2 net-next 0/2] tcp: mmap: rework zerocopy receive Eric Dumazet
2018-04-25 21:43 ` [PATCH v2 net-next 1/2] tcp: add TCP_ZEROCOPY_RECEIVE support for " Eric Dumazet
2018-04-26 13:40 ` Ka-Cheong Poon
2018-04-26 13:47 ` Eric Dumazet
2018-04-26 13:47 ` Eric Dumazet
2018-04-27 8:44 ` kbuild test robot
2018-04-27 8:44 ` kbuild test robot
2018-04-27 13:03 ` Eric Dumazet
2018-04-25 21:43 ` [PATCH v2 net-next 2/2] selftests: net: tcp_mmap must use TCP_ZEROCOPY_RECEIVE Eric Dumazet
2018-04-26 1:20 ` Soheil Hassas Yeganeh [this message]
2018-04-26 14:56 ` [PATCH v2 net-next 0/2] tcp: mmap: rework zerocopy receive Eric Dumazet
2018-04-26 21:16 ` Andy Lutomirski
2018-04-26 21:40 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACSApvZF8CJqcRx7FGkMGitBiC6m0=_FT9XRZ=VV07U62wGM3Q@mail.gmail.com' \
--to=soheil@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.