From mboxrd@z Thu Jan  1 00:00:00 1970
From: Soheil Hassas Yeganeh <soheil@google.com>
Subject: Re: [PATCH net-next 2/4] tcp: do not force quickack when receiving
 out-of-order packets
Date: Thu, 17 May 2018 13:14:13 -0400
Message-ID: <CACSApvaX4OBj=0L-ij7c8s4kKH0JeKs+MwceCM3EU+3e8qyQWg@mail.gmail.com>
References: <20180517121213.43559-1-edumazet@google.com> <20180517121213.43559-3-edumazet@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: "David S . Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>,
        Neal Cardwell <ncardwell@google.com>,
        Yuchung Cheng <ycheng@google.com>,
        Eric Dumazet <eric.dumazet@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f196.google.com ([209.85.223.196]:43213 "EHLO
        mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750924AbeEQROz (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 17 May 2018 13:14:55 -0400
Received: by mail-io0-f196.google.com with SMTP id t23-v6so2906658ioc.10
        for <netdev@vger.kernel.org>; Thu, 17 May 2018 10:14:55 -0700 (PDT)
In-Reply-To: <20180517121213.43559-3-edumazet@google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, May 17, 2018 at 8:12 AM, Eric Dumazet <edumazet@google.com> wrote:
> As explained in commit 9f9843a751d0 ("tcp: properly handle stretch
> acks in slow start"), TCP stacks have to consider how many packets
> are acknowledged in one single ACK, because of GRO, but also
> because of ACK compression or losses.
>
> We plan to add SACK compression in the following patch, we
> must therefore not call tcp_enter_quickack_mode()
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Acked-by: Soheil Hassas Yeganeh <soheil@google.com>

Thank you, Eric!