From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Vyukov Subject: Re: x509 parsing bug + fuzzing crypto in the userspace Date: Wed, 22 Nov 2017 18:03:14 +0100 Message-ID: References: <20171121204628.GA56006@google.com> <8790288.6NrG2qtxDg@tauon.chronox.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Eric Biggers , Alexander Potapenko , linux-crypto@vger.kernel.org, Kostya Serebryany , keyrings@vger.kernel.org, Andrey Konovalov To: Stephan Mueller Return-path: Received: from mail-pg0-f49.google.com ([74.125.83.49]:32974 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbdKVRDf (ORCPT ); Wed, 22 Nov 2017 12:03:35 -0500 Received: by mail-pg0-f49.google.com with SMTP id s75so12843306pgs.0 for ; Wed, 22 Nov 2017 09:03:35 -0800 (PST) In-Reply-To: <8790288.6NrG2qtxDg@tauon.chronox.de> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Nov 22, 2017 at 5:54 PM, Stephan Mueller wrote: > Am Dienstag, 21. November 2017, 21:46:28 CET schrieb Eric Biggers: > > Hi Eric, > >> >> (There is probably more to improve for AF_ALG besides the algorithm names; >> this is just what I happened to notice for now.) > > Just grepping may not cover all possibilities. Attached is a script that I use > to invoke an array different tests for different cipher implementations. For > now, it only covers C, ASM and CPU-based cipher implementations. Hi Stephan, I see it has lots of names hardcoded. Is it possible to extract up-to-date list from kernel? Maybe at runtime from running kernel? What's the max number of arguments for a template? I see there is at least 2: rfc4106(gcm_base(ctr(aes-aesni),ghash-clmulni)) can there be more? Do you know answer to this question by any chance? what's the relation between alg names and type ("aead", "hash", "rng", "skcipher")? I remember I already looked at it before and could not figure it out. Are all algorithms and templates partitioned between types? Or they are orthogonal? Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Vyukov Date: Wed, 22 Nov 2017 17:03:14 +0000 Subject: Re: x509 parsing bug + fuzzing crypto in the userspace Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20171121204628.GA56006@google.com> <8790288.6NrG2qtxDg@tauon.chronox.de> In-Reply-To: <8790288.6NrG2qtxDg@tauon.chronox.de> To: Stephan Mueller Cc: Eric Biggers , Alexander Potapenko , linux-crypto@vger.kernel.org, Kostya Serebryany , keyrings@vger.kernel.org, Andrey Konovalov On Wed, Nov 22, 2017 at 5:54 PM, Stephan Mueller wrote: > Am Dienstag, 21. November 2017, 21:46:28 CET schrieb Eric Biggers: > > Hi Eric, > >> >> (There is probably more to improve for AF_ALG besides the algorithm names; >> this is just what I happened to notice for now.) > > Just grepping may not cover all possibilities. Attached is a script that I use > to invoke an array different tests for different cipher implementations. For > now, it only covers C, ASM and CPU-based cipher implementations. Hi Stephan, I see it has lots of names hardcoded. Is it possible to extract up-to-date list from kernel? Maybe at runtime from running kernel? What's the max number of arguments for a template? I see there is at least 2: rfc4106(gcm_base(ctr(aes-aesni),ghash-clmulni)) can there be more? Do you know answer to this question by any chance? what's the relation between alg names and type ("aead", "hash", "rng", "skcipher")? I remember I already looked at it before and could not figure it out. Are all algorithms and templates partitioned between types? Or they are orthogonal? Thanks