From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751601AbaJAOYZ (ORCPT ); Wed, 1 Oct 2014 10:24:25 -0400 Received: from mail-qc0-f178.google.com ([209.85.216.178]:59531 "EHLO mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbaJAOYX (ORCPT ); Wed, 1 Oct 2014 10:24:23 -0400 MIME-Version: 1.0 In-Reply-To: <542C0BA3.7000504@samsung.com> References: <1404905415-9046-1-git-send-email-a.ryabinin@samsung.com> <1411562649-28231-1-git-send-email-a.ryabinin@samsung.com> <1411562649-28231-12-git-send-email-a.ryabinin@samsung.com> <20141001103930.GG20364@e104818-lin.cambridge.arm.com> <542BE977.3040807@samsung.com> <542C0BA3.7000504@samsung.com> From: Dmitry Vyukov Date: Wed, 1 Oct 2014 18:24:02 +0400 Message-ID: Subject: Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak To: Andrey Ryabinin Cc: Catalin Marinas , Andrey Ryabinin , LKML , Konstantin Serebryany , Dmitry Chernenkov , Andrey Konovalov , Yuri Gribov , Konstantin Khlebnikov , Sasha Levin , Christoph Lameter , Joonsoo Kim , Andrew Morton , Dave Hansen , Andi Kleen , Vegard Nossum , "H. Peter Anvin" , Dave Jones , "x86@kernel.org" , "linux-mm@kvack.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 1, 2014 at 6:11 PM, Andrey Ryabinin wrote: >>>>>>> >>>>>>> We can disable kasan instrumentation of this file as well. >>>>>> >>>>>> Yes, but why? I don't think we need that. >>>>> >>>>> Just gut feeling. Such tools usually don't play well together. For >>>>> example, due to asan quarantine lots of leaks will be missed (if we >>>>> pretend that tools work together, end users will use them together and >>>>> miss bugs). I won't be surprised if leak detector touches freed >>>>> objects under some circumstances as well. >>>>> We can do this if/when discover actual compatibility issues, of course. >>>> >>>> I think it's worth testing them together first. >>>> >>> >>> I did test them together. With this patch applied both tools works without problems. >> >> What do you mean "works without problems"? Are you sure that kmemleak >> still detects all leaks it is intended to detect? >> > > Yes I'm sure about that. And how kasan could affect on kmemleak's capability to detect leaks? Ah, OK, we don't have quarantine. The idea is that redzones and quarantine will contain parasitical pointers (quarantine is exactly a linked list of freed objects). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f172.google.com (mail-qc0-f172.google.com [209.85.216.172]) by kanga.kvack.org (Postfix) with ESMTP id D36F76B0069 for ; Wed, 1 Oct 2014 10:24:24 -0400 (EDT) Received: by mail-qc0-f172.google.com with SMTP id o8so370984qcw.31 for ; Wed, 01 Oct 2014 07:24:24 -0700 (PDT) Received: from mail-qc0-x230.google.com (mail-qc0-x230.google.com [2607:f8b0:400d:c01::230]) by mx.google.com with ESMTPS id n69si1937038qge.21.2014.10.01.07.24.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 01 Oct 2014 07:24:23 -0700 (PDT) Received: by mail-qc0-f176.google.com with SMTP id r5so391849qcx.7 for ; Wed, 01 Oct 2014 07:24:22 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <542C0BA3.7000504@samsung.com> References: <1404905415-9046-1-git-send-email-a.ryabinin@samsung.com> <1411562649-28231-1-git-send-email-a.ryabinin@samsung.com> <1411562649-28231-12-git-send-email-a.ryabinin@samsung.com> <20141001103930.GG20364@e104818-lin.cambridge.arm.com> <542BE977.3040807@samsung.com> <542C0BA3.7000504@samsung.com> From: Dmitry Vyukov Date: Wed, 1 Oct 2014 18:24:02 +0400 Message-ID: Subject: Re: [PATCH v3 11/13] kmemleak: disable kasan instrumentation for kmemleak Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Andrey Ryabinin Cc: Catalin Marinas , Andrey Ryabinin , LKML , Konstantin Serebryany , Dmitry Chernenkov , Andrey Konovalov , Yuri Gribov , Konstantin Khlebnikov , Sasha Levin , Christoph Lameter , Joonsoo Kim , Andrew Morton , Dave Hansen , Andi Kleen , Vegard Nossum , "H. Peter Anvin" , Dave Jones , "x86@kernel.org" , "linux-mm@kvack.org" On Wed, Oct 1, 2014 at 6:11 PM, Andrey Ryabinin wrote: >>>>>>> >>>>>>> We can disable kasan instrumentation of this file as well. >>>>>> >>>>>> Yes, but why? I don't think we need that. >>>>> >>>>> Just gut feeling. Such tools usually don't play well together. For >>>>> example, due to asan quarantine lots of leaks will be missed (if we >>>>> pretend that tools work together, end users will use them together and >>>>> miss bugs). I won't be surprised if leak detector touches freed >>>>> objects under some circumstances as well. >>>>> We can do this if/when discover actual compatibility issues, of course. >>>> >>>> I think it's worth testing them together first. >>>> >>> >>> I did test them together. With this patch applied both tools works without problems. >> >> What do you mean "works without problems"? Are you sure that kmemleak >> still detects all leaks it is intended to detect? >> > > Yes I'm sure about that. And how kasan could affect on kmemleak's capability to detect leaks? Ah, OK, we don't have quarantine. The idea is that redzones and quarantine will contain parasitical pointers (quarantine is exactly a linked list of freed objects). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org