From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AF3C433EF for ; Fri, 17 Sep 2021 14:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 395BD60F6B for ; Fri, 17 Sep 2021 14:37:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243119AbhIQOif (ORCPT ); Fri, 17 Sep 2021 10:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbhIQOie (ORCPT ); Fri, 17 Sep 2021 10:38:34 -0400 Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBAA3C061574 for ; Fri, 17 Sep 2021 07:37:11 -0700 (PDT) Received: by mail-oo1-xc2e.google.com with SMTP id v20-20020a4a2554000000b0028f8cc17378so3277511ooe.0 for ; Fri, 17 Sep 2021 07:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CHasoNbCFWsiX9dMsKrnxNkdea5daLbcgcWNoEUJAKg=; b=DYn3EwXJtdkBVHXuZ1aStNkPPcUVZmW6AQ/X3JXnDFo4Nu3pQZeMPOI9uDfSO9+xZx jyuiw9sr27jq29Oz/ES/fgfI9Du6O6Jr813ACDSDlEjmhvlUU31zNB52SIFLyuDDC7Oh re++P1iqt7pzhJyWnMKoT8YvwtIsIvOChwB28km/oaqDbdlTE4G5SApBipmZmIcxiMFG BSDDD+vKZc9X8qrUjx0lhPi/8ZtVcMCXahlWmmF4inWRk3NLuBEK83KoXoWH8NwA4uuS H6pWTo4NQ3o83e0z6I24kXmAGTZLh9jZaBuHoEyyihkCjUcb/E2wUkJ4ShlzZZBPuWzs nbhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CHasoNbCFWsiX9dMsKrnxNkdea5daLbcgcWNoEUJAKg=; b=TSXanEQiiGXtRq3PFY/VHXSXOZq/GOqgxrIQhxWVXd9Rz6xeMkzz9OLJ8gSSdJ1Fyp aCrO0i7Z1VDcZD0JdY5OLcl7gZUSAZgfGyLOcYbxmHT9UiRhwPWjfWnBqJ/fokuSAaf2 s9ap5nwrWlS/S/B7iD/lZjJ2fdNl2nYXc45CVBnbAu4f9bMXqyGC4bfPsFs0elYWXoBE BusKnHIEXIqjVWAz2+tkq6XcqIG89XkCNDkvL0ndlOvH8OQ+5csV5Qgnj+2hE6IGQK3Y 0RKVHGGCD1nrABb0kgVPvQWdzVgDil+AAz+3RFbWj+TlV9fxoXK7gwOYSgvQWkntYIrK b04w== X-Gm-Message-State: AOAM530XQ53/0EPJQEfupK1N6SfkuZn8fL9UJlwj8Y/18mOxb3zUg3EX ENJk5FYm9EqHy6RL5pyfdKUNz00+Nz11UBnEkdfv9A== X-Google-Smtp-Source: ABdhPJy6BVBa1rtp9ko/Mki3AyMVFKOss9TpQQybtMS7fCiiPAGaON0g/z1nbJ8vHUHmoSGUy+tUXuBECv6J6FEBoHM= X-Received: by 2002:a4a:e3cf:: with SMTP id m15mr9150899oov.21.1631889431067; Fri, 17 Sep 2021 07:37:11 -0700 (PDT) MIME-Version: 1.0 References: <20210830172627.267989-1-bigeasy@linutronix.de> <20210830172627.267989-3-bigeasy@linutronix.de> In-Reply-To: <20210830172627.267989-3-bigeasy@linutronix.de> From: Dmitry Vyukov Date: Fri, 17 Sep 2021 16:37:00 +0200 Message-ID: Subject: Re: [PATCH 2/5] Documentation/kcov: Define `ip' in the example. To: Sebastian Andrzej Siewior Cc: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Andrey Konovalov , Thomas Gleixner , Steven Rostedt , Marco Elver , Clark Williams Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Aug 2021 at 19:26, Sebastian Andrzej Siewior wrote: > > The example code uses the variable `ip' but never declares it. > > Declare `ip' as a 64bit variable which is the same type as the array > from which it loads its value. > > Signed-off-by: Sebastian Andrzej Siewior Acked-by: Dmitry Vyukov > --- > Documentation/dev-tools/kcov.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/dev-tools/kcov.rst b/Documentation/dev-tools/kcov.rst > index 347f3b6de8d40..d83c9ab494275 100644 > --- a/Documentation/dev-tools/kcov.rst > +++ b/Documentation/dev-tools/kcov.rst > @@ -178,6 +178,8 @@ Comparison operands collection > /* Read number of comparisons collected. */ > n = __atomic_load_n(&cover[0], __ATOMIC_RELAXED); > for (i = 0; i < n; i++) { > + uint64_t ip; > + > type = cover[i * KCOV_WORDS_PER_CMP + 1]; > /* arg1 and arg2 - operands of the comparison. */ > arg1 = cover[i * KCOV_WORDS_PER_CMP + 2]; > -- > 2.33.0 >