From: Dmitry Vyukov <dvyukov@google.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
Andrey Konovalov <andreyknvl@google.com>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Kostya Serebryany <kcc@google.com>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: net/tcp: warning in tcp_try_coalesce/skb_try_coalesce
Date: Thu, 2 Feb 2017 13:59:29 +0100 [thread overview]
Message-ID: <CACT4Y+Z8uSWJaW+QXSOr7dCo5fSNrMu6fHxPcDBxL08qQUvRMw@mail.gmail.com> (raw)
In-Reply-To: <1486038029.13103.17.camel@edumazet-glaptop3.roam.corp.google.com>
On Thu, Feb 2, 2017 at 1:20 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Thu, 2017-02-02 at 10:05 +0100, Dmitry Vyukov wrote:
>> On Tue, Jan 31, 2017 at 3:27 PM, 'Eric Dumazet' via syzkaller
>> <syzkaller@googlegroups.com> wrote:
>> > On Tue, Jan 31, 2017 at 5:17 AM, Andrey Konovalov <andreyknvl@google.com> wrote:
>> >> Hi,
>> >>
>> >> I've got the following error report while running the syzkaller fuzzer.
>> >>
>> >> On commit 566cf877a1fcb6d6dc0126b076aad062054c2637 (4.10-rc6).
>> >>
>> >> The fuzzer hits this issue quite often, but I don't have a working reproducer.
>> >>
>> >> WARNING: CPU: 3 PID: 7091 at net/core/skbuff.c:4331
>> >> skb_try_coalesce+0x14b1/0x1f80 net/core/skbuff.c:4331
>> >> Kernel panic - not syncing: panic_on_warn set ...
>> ...
>> > Have you tried the patch we added recently into net-next ?
>> >
>> > https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=158f323b9868b59967ad96957c4ca388161be321
>>
>>
>> I've tried this patch, and it does _not_ help.
>> I am currently on a2ca3d617944417e9dd5f09fc8a4549cda115f4f, and I
>> applied the patch on top (had to do a little merging in af_netlink.c):
>> https://gist.githubusercontent.com/dvyukov/b4fd206f7dde763b3113a4543c57e7bb/raw/784c5b1bcb06f2a22c55eb4c4f8f83d627cd1ab9/gistfile1.txt
>> Still getting the same warning.
>>
>> But now I have a repro:
>> https://gist.githubusercontent.com/dvyukov/88fdb6d93507b36f81377191b0694f9b/raw/81cc11e8b78b6bbc5cffc79b442ce998c49af226/gistfile1.txt
>>
>
> Interesting. This repro does not trigger the bug on net-next.
Right, I can confirm that this is not happening on net-next tip
(62e13097c46c69dbd7544ab2cd585ccf48f360a4).
I reproduced it on a random month old commit on net-next, though
(23a8ed4a624324dc696c328f09bd502c4a3816f0). Let's consider that this
is accidentally fixed by something in that range.
next prev parent reply other threads:[~2017-02-02 12:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 13:17 net/tcp: warning in tcp_try_coalesce/skb_try_coalesce Andrey Konovalov
2017-01-31 14:27 ` Eric Dumazet
2017-02-02 9:05 ` Dmitry Vyukov
2017-02-02 12:20 ` Eric Dumazet
2017-02-02 12:59 ` Dmitry Vyukov [this message]
2017-02-02 13:40 ` Eric Dumazet
2017-02-02 13:56 ` Dmitry Vyukov
2017-02-02 14:03 ` Dmitry Vyukov
2017-02-02 17:34 ` Dmitry Vyukov
2017-04-26 12:08 ` Andrey Konovalov
2017-04-26 14:16 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+Z8uSWJaW+QXSOr7dCo5fSNrMu6fHxPcDBxL08qQUvRMw@mail.gmail.com \
--to=dvyukov@google.com \
--cc=andreyknvl@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kcc@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.