From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A578C433E2 for ; Wed, 20 May 2020 09:44:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EFAB207ED for ; Wed, 20 May 2020 09:44:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mcbr3U/r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbgETJo1 (ORCPT ); Wed, 20 May 2020 05:44:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbgETJo0 (ORCPT ); Wed, 20 May 2020 05:44:26 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A73CC061A0E for ; Wed, 20 May 2020 02:44:26 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id m64so2029593qtd.4 for ; Wed, 20 May 2020 02:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WK6Eeu4700pWxp3v6K/+5f6+X4R/4p2PtasXvzK5TIU=; b=mcbr3U/rpVihQgdZiC7qnWVVMXwIxxQb7nRmzfUITYjqIZN4zlAdEs2mpnBQWDt8iP FmCGe33/DyXfujDbBsKoArekqU+KPCWukVtwCnDONUruhnJmAqeYQtED6hTDNZZqY6DG v4fl9GEI/Ygt1PxzB69A7hC+QDY7mS0TpQP9awbwAbUXFZGDEuJ7QFi+7AGcHlj6+hZu +PXGlTBJNw+CpnLWuGx4oJX37KGjtsEkmOl9zCRgoTNQdZI++/Kvjwvw054Uan0rC/xU NidhppF3k8okE/qOK+QUY8wRIkKjtLNboTUUzau2xWmGyPu37pD4oTWwk9BSu6Eerjls sI8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WK6Eeu4700pWxp3v6K/+5f6+X4R/4p2PtasXvzK5TIU=; b=JYQ3azg+VEsfM2s5E+fV+dw5D5wiwHirOIMqB5z2HqmSsHXkOpY/7Z/cBtRZof9k9Y 7VOYSu8xI82LTawoqfLghKPKqzJFFvoHB3V/HF7QwIRHoAQZBvO7Z9yuKSN/Zi+eV3ob HQyKB3RvPjl3QC2/JDw2J+4Nl3F5vxfl66bFRwKaKQP8tTq2iSKzhoTGF4k+jaa1tsep 0q04jOmeagBdHQomB3nZL2Er6sKrHWAVV4NB035hOPoNFKkRmFWDg8EGDIqiQEhb+Wtt e3Lw7PvJqK3iufQXLQ5gFkwtohNaQ3Zwpc5vVCvlDpkXfPT+Ttvq8XLtyh+GcFzaIKTK 3uwQ== X-Gm-Message-State: AOAM530x7DaMMve/YXsTkNXamJgrZMgqt20eAcTgHjjWjTTkYU3p3xnx L+3VWoHc9vYs8zvBrupQfaxrwPERRYjDpLGBv0sn3ISbnt8= X-Google-Smtp-Source: ABdhPJyd7oIp5KuKbs5jLZIRdEkysdSCDUvBdHCQFqni6ZAF8rqvNnCyMZNSmFB2s7Iyxe6BvoxifyvnHnNp532+jtI= X-Received: by 2002:ac8:6642:: with SMTP id j2mr4313272qtp.158.1589967865169; Wed, 20 May 2020 02:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20200519022517.24182-1-walter-zh.wu@mediatek.com> <1589947387.29577.35.camel@mtksdccf07> <1589951659.4440.4.camel@mtksdccf07> <1589955526.4440.22.camel@mtksdccf07> <1589966220.14692.24.camel@mtksdccf07> In-Reply-To: <1589966220.14692.24.camel@mtksdccf07> From: Dmitry Vyukov Date: Wed, 20 May 2020 11:44:12 +0200 Message-ID: Subject: Re: [PATCH v4 2/4] kasan: record and print the free track To: Walter Wu Cc: Andrey Ryabinin , Alexander Potapenko , kasan-dev , Linux-MM , LKML , Linux ARM , wsd_upstream , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2020 at 11:17 AM Walter Wu wrote: > > > On Wed, 2020-05-20 at 13:14 +0800, Walter Wu wrote: > > > > > On Wed, May 20, 2020 at 6:03 AM Walter Wu wrote: > > > > > > > > > > > > > On Tue, May 19, 2020 at 4:25 AM Walter Wu wrote: > > > > > > > > > > > > > > > > Move free track from slub alloc meta-data to slub free meta-data in > > > > > > > > order to make struct kasan_free_meta size is 16 bytes. It is a good > > > > > > > > size because it is the minimal redzone size and a good number of > > > > > > > > alignment. > > > > > > > > > > > > > > > > For free track in generic KASAN, we do the modification in struct > > > > > > > > kasan_alloc_meta and kasan_free_meta: > > > > > > > > - remove free track from kasan_alloc_meta. > > > > > > > > - add free track into kasan_free_meta. > > > > > > > > > > > > > > > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > > > > > > > > > > > > > > > > Signed-off-by: Walter Wu > > > > > > > > Suggested-by: Dmitry Vyukov > > > > > > > > Cc: Andrey Ryabinin > > > > > > > > Cc: Dmitry Vyukov > > > > > > > > Cc: Alexander Potapenko > > > > > > > > --- > > > > > > > > mm/kasan/common.c | 22 ++-------------------- > > > > > > > > mm/kasan/generic.c | 18 ++++++++++++++++++ > > > > > > > > mm/kasan/kasan.h | 7 +++++++ > > > > > > > > mm/kasan/report.c | 20 -------------------- > > > > > > > > mm/kasan/tags.c | 37 +++++++++++++++++++++++++++++++++++++ > > > > > > > > 5 files changed, 64 insertions(+), 40 deletions(-) > > > > > > > > > > > > > > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > > > > > > > index 8bc618289bb1..47b53912f322 100644 > > > > > > > > --- a/mm/kasan/common.c > > > > > > > > +++ b/mm/kasan/common.c > > > > > > > > @@ -51,7 +51,7 @@ depot_stack_handle_t kasan_save_stack(gfp_t flags) > > > > > > > > return stack_depot_save(entries, nr_entries, flags); > > > > > > > > } > > > > > > > > > > > > > > > > -static inline void set_track(struct kasan_track *track, gfp_t flags) > > > > > > > > +void kasan_set_track(struct kasan_track *track, gfp_t flags) > > > > > > > > { > > > > > > > > track->pid = current->pid; > > > > > > > > track->stack = kasan_save_stack(flags); > > > > > > > > @@ -299,24 +299,6 @@ struct kasan_free_meta *get_free_info(struct kmem_cache *cache, > > > > > > > > return (void *)object + cache->kasan_info.free_meta_offset; > > > > > > > > } > > > > > > > > > > > > > > > > - > > > > > > > > -static void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > - void *object, u8 tag) > > > > > > > > -{ > > > > > > > > - struct kasan_alloc_meta *alloc_meta; > > > > > > > > - u8 idx = 0; > > > > > > > > - > > > > > > > > - alloc_meta = get_alloc_info(cache, object); > > > > > > > > - > > > > > > > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > - idx = alloc_meta->free_track_idx; > > > > > > > > - alloc_meta->free_pointer_tag[idx] = tag; > > > > > > > > - alloc_meta->free_track_idx = (idx + 1) % KASAN_NR_FREE_STACKS; > > > > > > > > -#endif > > > > > > > > - > > > > > > > > - set_track(&alloc_meta->free_track[idx], GFP_NOWAIT); > > > > > > > > -} > > > > > > > > - > > > > > > > > void kasan_poison_slab(struct page *page) > > > > > > > > { > > > > > > > > unsigned long i; > > > > > > > > @@ -492,7 +474,7 @@ static void *__kasan_kmalloc(struct kmem_cache *cache, const void *object, > > > > > > > > KASAN_KMALLOC_REDZONE); > > > > > > > > > > > > > > > > if (cache->flags & SLAB_KASAN) > > > > > > > > - set_track(&get_alloc_info(cache, object)->alloc_track, flags); > > > > > > > > + kasan_set_track(&get_alloc_info(cache, object)->alloc_track, flags); > > > > > > > > > > > > > > > > return set_tag(object, tag); > > > > > > > > } > > > > > > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > > > > > > index 3372bdcaf92a..763d8a13e0ac 100644 > > > > > > > > --- a/mm/kasan/generic.c > > > > > > > > +++ b/mm/kasan/generic.c > > > > > > > > @@ -344,3 +344,21 @@ void kasan_record_aux_stack(void *addr) > > > > > > > > alloc_info->aux_stack[1] = alloc_info->aux_stack[0]; > > > > > > > > alloc_info->aux_stack[0] = kasan_save_stack(GFP_NOWAIT); > > > > > > > > } > > > > > > > > + > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_free_meta *free_meta; > > > > > > > > + > > > > > > > > + free_meta = get_free_info(cache, object); > > > > > > > > + kasan_set_track(&free_meta->free_track, GFP_NOWAIT); > > > > > > > > +} > > > > > > > > + > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_free_meta *free_meta; > > > > > > > > + > > > > > > > > + free_meta = get_free_info(cache, object); > > > > > > > > + return &free_meta->free_track; > > > > > > > > +} > > > > > > > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > > > > > > > index a7391bc83070..ad897ec36545 100644 > > > > > > > > --- a/mm/kasan/kasan.h > > > > > > > > +++ b/mm/kasan/kasan.h > > > > > > > > @@ -127,6 +127,9 @@ struct kasan_free_meta { > > > > > > > > * Otherwise it might be used for the allocator freelist. > > > > > > > > */ > > > > > > > > struct qlist_node quarantine_link; > > > > > > > > +#ifdef CONFIG_KASAN_GENERIC > > > > > > > > + struct kasan_track free_track; > > > > > > > > +#endif > > > > > > > > }; > > > > > > > > > > > > > > > > struct kasan_alloc_meta *get_alloc_info(struct kmem_cache *cache, > > > > > > > > @@ -168,6 +171,10 @@ void kasan_report_invalid_free(void *object, unsigned long ip); > > > > > > > > struct page *kasan_addr_to_page(const void *addr); > > > > > > > > > > > > > > > > depot_stack_handle_t kasan_save_stack(gfp_t flags); > > > > > > > > +void kasan_set_track(struct kasan_track *track, gfp_t flags); > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, void *object, u8 tag); > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag); > > > > > > > > > > > > > > > > #if defined(CONFIG_KASAN_GENERIC) && \ > > > > > > > > (defined(CONFIG_SLAB) || defined(CONFIG_SLUB)) > > > > > > > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > > > > > > > index 6f8f2bf8f53b..96d2657fe70f 100644 > > > > > > > > --- a/mm/kasan/report.c > > > > > > > > +++ b/mm/kasan/report.c > > > > > > > > @@ -159,26 +159,6 @@ static void describe_object_addr(struct kmem_cache *cache, void *object, > > > > > > > > (void *)(object_addr + cache->object_size)); > > > > > > > > } > > > > > > > > > > > > > > > > -static struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > - void *object, u8 tag) > > > > > > > > -{ > > > > > > > > - struct kasan_alloc_meta *alloc_meta; > > > > > > > > - int i = 0; > > > > > > > > - > > > > > > > > - alloc_meta = get_alloc_info(cache, object); > > > > > > > > - > > > > > > > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > - for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > > > > > > > > - if (alloc_meta->free_pointer_tag[i] == tag) > > > > > > > > - break; > > > > > > > > - } > > > > > > > > - if (i == KASAN_NR_FREE_STACKS) > > > > > > > > - i = alloc_meta->free_track_idx; > > > > > > > > -#endif > > > > > > > > - > > > > > > > > - return &alloc_meta->free_track[i]; > > > > > > > > -} > > > > > > > > - > > > > > > > > #ifdef CONFIG_KASAN_GENERIC > > > > > > > > static void print_stack(depot_stack_handle_t stack) > > > > > > > > { > > > > > > > > diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c > > > > > > > > index 25b7734e7013..201dee5d6ae0 100644 > > > > > > > > --- a/mm/kasan/tags.c > > > > > > > > +++ b/mm/kasan/tags.c > > > > > > > > @@ -162,3 +162,40 @@ void __hwasan_tag_memory(unsigned long addr, u8 tag, unsigned long size) > > > > > > > > kasan_poison_shadow((void *)addr, size, tag); > > > > > > > > } > > > > > > > > EXPORT_SYMBOL(__hwasan_tag_memory); > > > > > > > > + > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_alloc_meta *alloc_meta; > > > > > > > > + u8 idx = 0; > > > > > > > > + > > > > > > > > + alloc_meta = get_alloc_info(cache, object); > > > > > > > > + > > > > > > > > +#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > + idx = alloc_meta->free_track_idx; > > > > > > > > + alloc_meta->free_pointer_tag[idx] = tag; > > > > > > > > + alloc_meta->free_track_idx = (idx + 1) % KASAN_NR_FREE_STACKS; > > > > > > > > +#endif > > > > > > > > + > > > > > > > > + kasan_set_track(&alloc_meta->free_track[idx], GFP_NOWAIT); > > > > > > > > +} > > > > > > > > + > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_alloc_meta *alloc_meta; > > > > > > > > + int i = 0; > > > > > > > > + > > > > > > > > + alloc_meta = get_alloc_info(cache, object); > > > > > > > > + > > > > > > > > +#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > + for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > > > > > > > > + if (alloc_meta->free_pointer_tag[i] == tag) > > > > > > > > + break; > > > > > > > > + } > > > > > > > > + if (i == KASAN_NR_FREE_STACKS) > > > > > > > > + i = alloc_meta->free_track_idx; > > > > > > > > +#endif > > > > > > > > + > > > > > > > > + return &alloc_meta->free_track[i]; > > > > > > > > +} > > > > > > > > > > > > > > Hi Walter, > > > > > > > > > > > > > > FTR I've uploaded this for review purposes here: > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2458 > > > > > > > > > > > > > > Diff from the previous version is available as: > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2458/1..2 > > > > > > > > > > > > > > I've tested this locally and with syzkaller. This is : > > > > > > > > > > > > > > [ 80.583021][ C3] Freed by task 0: > > > > > > > [ 80.583480][ C3] kasan_save_stack+0x1b/0x40 mm/kasan/common.c:49 > > > > > > > [ 80.584056][ C3] kasan_set_track+0x1c/0x30 mm/kasan/common.c:57 > > > > > > > [ 80.584617][ C3] kasan_set_free_info+0x1b/0x30 mm/kasan/generic.c:354 > > > > > > > [ 80.585221][ C3] __kasan_slab_free+0xd8/0x120 mm/kasan/common.c:438 > > > > > > > [ 80.585814][ C3] __cache_free mm/slab.c:3426 [inline] > > > > > > > [ 80.585814][ C3] kfree+0x10b/0x2b0 mm/slab.c:3757 > > > > > > > [ 80.586291][ C3] kasan_rcu_reclaim+0x16/0x43 [test_kasan] > > > > > > > [ 80.587009][ C3] rcu_do_batch kernel/rcu/tree.c:2207 [inline] > > > > > > > [ 80.587009][ C3] rcu_core+0x59f/0x1370 kernel/rcu/tree.c:2434 > > > > > > > [ 80.587537][ C3] __do_softirq+0x26c/0x9fa kernel/softirq.c:292 > > > > > > > [ 80.588085][ C3] > > > > > > > [ 80.588367][ C3] Last one call_rcu() call stack: > > > > > > > [ 80.589052][ C3] kasan_save_stack+0x1b/0x40 mm/kasan/common.c:49 > > > > > > > [ 80.589622][ C3] kasan_record_aux_stack+0x82/0xb0 mm/kasan/generic.c:345 > > > > > > > [ 80.590254][ C3] __call_rcu kernel/rcu/tree.c:2672 [inline] > > > > > > > [ 80.590254][ C3] call_rcu+0x14f/0x7f0 kernel/rcu/tree.c:2746 > > > > > > > [ 80.590782][ C3] kasan_rcu_uaf+0xe4/0xeb [test_kasan] > > > > > > > [ 80.591697][ C3] kmalloc_tests_init+0xbc/0x1097 [test_kasan] > > > > > > > [ 80.592900][ C3] do_one_initcall+0x10a/0x7d0 init/main.c:1196 > > > > > > > [ 80.593494][ C3] do_init_module+0x1e6/0x6d0 kernel/module.c:3539 > > > > > > > [ 80.594066][ C3] load_module+0x7464/0x9450 kernel/module.c:3890 > > > > > > > [ 80.594626][ C3] __do_sys_init_module+0x1e3/0x220 kernel/module.c:3953 > > > > > > > [ 80.595265][ C3] do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295 > > > > > > > [ 80.595822][ C3] entry_SYSCALL_64_after_hwframe+0x49/0xb3 > > > > > > > > > > > > > > > > > > > > > Overall this looks very good to me. > > > > > > > But there is one aspect that bothers me. In the previous patch you had > > > > > > > code that returned NULL from kasan_get_free_track() if the object is > > > > > > > live (which means free meta is not available, it's occupied by object > > > > > > > data). Now you dropped that code, but I think we still need it. > > > > > > > Otherwise we cast user object data to free meta and print the free > > > > > > > stack/pid from whatever garbage is there. This may lead to very > > > > > > > confusing output and potentially to crashes in stackdepot. > > > > > > > > > > > > > > > > > > > Yes, I totally agree with you. In the previous email I thought that > > > > > > there is a problem with free track, but I did not point it out. Thank > > > > > > you for pointing this problem. As you mentioned, we should fix it. > > > > > > > > > > > > > What do you think about this patch on top of your patches? > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2478 > > > > > > > This way we very precisely mark the period of time when the object has > > > > > > > free track live and set. > > > > > > > If it looks good to you, feel free to incorporate it into your series. > > > > > > > > > > > > > > > > > > > Thank you for providing good idea solution. > > > > > > > > > > > > I saw this patch, that is a great patch. I think it can fix the issue > > > > > > which has garbage stack. it should work as described below. > > > > > > > > > > > > 1). When object is live, then don't print free stack. > > > > > > 2). When object is NOT alive, after free object: > > > > > > 2a). when object is in quarantine, then it can print free stack > > > > > > 2b). when object is NOT in quarantine, then it can NOT print free stack. > > > > > > > > > > > > I have a question about 2), why we don't directly use > > > > > > KASAN_KMALLOC_FREE? if we directly use it, then 2b) can print free > > > > > > stack? 2b) may has use-after-free? so that it may need free stack. > > > > > > > > > > > About 2b), I see another question. When do qlink_free(), it will be > > > written KASAN_KMALLOC_FREE from KASAN_KMALLOC_FREETRACK? if we don't > > > write shadow memory, it is still KASAN_KMALLOC_FREETRACK, then 2b) will > > > have free stack? Because I see you add KASAN_KMALLOC_FREETRACK to get > > > use-after-free in get_shadow_bug_type(). so should it not write > > > KASAN_KMALLOC_FREE? > > > > It may or may not work. > > The potential problem is that when qlink_free calls ___cache_free, > > slab/slub may start using object memory for its own purposes, e.g. > > store the next link. This next link may overwrite part of free meta. > > It actually may work because the slab/slib next link is likely to > > overlap with kasan_free_meta.quarantine_link only. And we may have > > kasan_free_meta.free_track intact while KASAN_KMALLOC_FREE is set. But > > this needs careful checking for both slab and slub and if they may use > > more than 1 word in some configurations. > > > > This problem looks like existing, even without this change? currently > KASAN may get wrong free stack? No, we should not have this problem now. Currently free track is stored in alloc meta. Alloc meta does not overlap with the object. It's only free meta that overlaps with the object and slab metadata at different periods of the block lifetime. Schematically what we have is: struct block_t { alloc_meta kasan_alloc_meta; union { user_data char[N]; slab_meta slab_meta; free_meta kasan_free_meta; }; } free_meta shared storage space with 2 other things. > Regardless of whether the shadow memory content is > KASAN_KMALLOC_FREETRACK or KASAN_KMALLOC_FREE, it may have this problem? KASAN_KMALLOC_FREETRACK is set only when nobody else uses the storage. > But because of kasan_get_free_track() have conditions to get free track, > so that if shadow memory content is KASAN_KMALLOC_FREE, then it will > avoid this problem and always print right free stack. > > > > > We can't use KASAN_KMALLOC_FREE because of this part: > > > > > > > > > > static bool __kasan_slab_free(struct kmem_cache *cache, void *object, > > > > > unsigned long ip, bool quarantine) > > > > > { > > > > > ... > > > > > kasan_poison_shadow(object, rounded_up_size, KASAN_KMALLOC_FREE); > > > > > > > > > > if ((IS_ENABLED(CONFIG_KASAN_GENERIC) && !quarantine) || > > > > > unlikely(!(cache->flags & SLAB_KASAN))) > > > > > return false; > > > > > > > > > > kasan_set_free_info(cache, object, tag); > > > > > ... > > > > > > > > > > > > > Ok, I see. When return false, then the shadow memory content has > > > > KASAN_KMALLOC_FREE, but it doesn't set free stack, so that we need to > > > > avoid this situation. Thank for you reminder. > > > > > > > > > > > > > > We may set KASAN_KMALLOC_FREE, but not set the track (or even have > > > > > memory for the track!). > > > > > The object may not have free meta allocated at all, e.g. very large > > > > > object with ctor (no place to store meta), or it may be in a mempool: > > > > > https://elixir.bootlin.com/linux/v5.7-rc6/source/mm/mempool.c#L109 > > > > > and mempool may be using the object memory itself (for its own next > > > > > link or something). > > > > > > > > > > KASAN_KMALLOC_FREETRACK very explicitly tracks the exact condition we > > > > > want: we have meta info live now and we have free track set. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 321E4C433E0 for ; Wed, 20 May 2020 09:44:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BB1C42075F for ; Wed, 20 May 2020 09:44:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mcbr3U/r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB1C42075F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4A37E80007; Wed, 20 May 2020 05:44:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4498C900002; Wed, 20 May 2020 05:44:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33A2E80007; Wed, 20 May 2020 05:44:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 13A0A900002 for ; Wed, 20 May 2020 05:44:27 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B9DDA45CD for ; Wed, 20 May 2020 09:44:26 +0000 (UTC) X-FDA: 76836612132.15.bee59_7e11d5952922d X-HE-Tag: bee59_7e11d5952922d X-Filterd-Recvd-Size: 21859 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 May 2020 09:44:26 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id c24so2006307qtw.7 for ; Wed, 20 May 2020 02:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WK6Eeu4700pWxp3v6K/+5f6+X4R/4p2PtasXvzK5TIU=; b=mcbr3U/rpVihQgdZiC7qnWVVMXwIxxQb7nRmzfUITYjqIZN4zlAdEs2mpnBQWDt8iP FmCGe33/DyXfujDbBsKoArekqU+KPCWukVtwCnDONUruhnJmAqeYQtED6hTDNZZqY6DG v4fl9GEI/Ygt1PxzB69A7hC+QDY7mS0TpQP9awbwAbUXFZGDEuJ7QFi+7AGcHlj6+hZu +PXGlTBJNw+CpnLWuGx4oJX37KGjtsEkmOl9zCRgoTNQdZI++/Kvjwvw054Uan0rC/xU NidhppF3k8okE/qOK+QUY8wRIkKjtLNboTUUzau2xWmGyPu37pD4oTWwk9BSu6Eerjls sI8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WK6Eeu4700pWxp3v6K/+5f6+X4R/4p2PtasXvzK5TIU=; b=gAH3T7wQnX8T13CQ6MajEXsOW4TyW8Q9u9cx1FT7+EdbLlFhtB/pUbI82dpM5KXnIE RiYVA1WxBTC1UiXALdY5vfPq3bS9kSPTER4MM1IQwJ0Er+pERc7hoDWtA0f3HXgJ2QXO jjZeQ1WTn2+LA8fsrCWdnL8EBrdRDwODZaa5mWHyq9HU2Ykw1+LBUNCjL5/zTlph1kOV 3ZY8z43ORMkJifot7cunQFa+oFb9S/87Iuoc6v5xAtbxPwQUrPLTn/1jcuEekCQRPrDV tVOMSfw8NQrocI4Rz6qwsENVapxsWcXk2nsTnhsAVHXFFh8ZT1UxUbzGWiKV2DtBFy6T 2ZrA== X-Gm-Message-State: AOAM530oNmn2pXm4BIrfm0rIKS23pDg0VmE3MkjyWK42lxbrOgjxe80w uplkI/UsoyFm0GqPX3M3RoVu48ykSKE5rDD3q3p8ew== X-Google-Smtp-Source: ABdhPJyd7oIp5KuKbs5jLZIRdEkysdSCDUvBdHCQFqni6ZAF8rqvNnCyMZNSmFB2s7Iyxe6BvoxifyvnHnNp532+jtI= X-Received: by 2002:ac8:6642:: with SMTP id j2mr4313272qtp.158.1589967865169; Wed, 20 May 2020 02:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20200519022517.24182-1-walter-zh.wu@mediatek.com> <1589947387.29577.35.camel@mtksdccf07> <1589951659.4440.4.camel@mtksdccf07> <1589955526.4440.22.camel@mtksdccf07> <1589966220.14692.24.camel@mtksdccf07> In-Reply-To: <1589966220.14692.24.camel@mtksdccf07> From: Dmitry Vyukov Date: Wed, 20 May 2020 11:44:12 +0200 Message-ID: Subject: Re: [PATCH v4 2/4] kasan: record and print the free track To: Walter Wu Cc: Andrey Ryabinin , Alexander Potapenko , kasan-dev , Linux-MM , LKML , Linux ARM , wsd_upstream , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 20, 2020 at 11:17 AM Walter Wu wrote: > > > On Wed, 2020-05-20 at 13:14 +0800, Walter Wu wrote: > > > > > On Wed, May 20, 2020 at 6:03 AM Walter Wu wrote: > > > > > > > > > > > > > On Tue, May 19, 2020 at 4:25 AM Walter Wu wrote: > > > > > > > > > > > > > > > > Move free track from slub alloc meta-data to slub free meta-data in > > > > > > > > order to make struct kasan_free_meta size is 16 bytes. It is a good > > > > > > > > size because it is the minimal redzone size and a good number of > > > > > > > > alignment. > > > > > > > > > > > > > > > > For free track in generic KASAN, we do the modification in struct > > > > > > > > kasan_alloc_meta and kasan_free_meta: > > > > > > > > - remove free track from kasan_alloc_meta. > > > > > > > > - add free track into kasan_free_meta. > > > > > > > > > > > > > > > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > > > > > > > > > > > > > > > > Signed-off-by: Walter Wu > > > > > > > > Suggested-by: Dmitry Vyukov > > > > > > > > Cc: Andrey Ryabinin > > > > > > > > Cc: Dmitry Vyukov > > > > > > > > Cc: Alexander Potapenko > > > > > > > > --- > > > > > > > > mm/kasan/common.c | 22 ++-------------------- > > > > > > > > mm/kasan/generic.c | 18 ++++++++++++++++++ > > > > > > > > mm/kasan/kasan.h | 7 +++++++ > > > > > > > > mm/kasan/report.c | 20 -------------------- > > > > > > > > mm/kasan/tags.c | 37 +++++++++++++++++++++++++++++++++++++ > > > > > > > > 5 files changed, 64 insertions(+), 40 deletions(-) > > > > > > > > > > > > > > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > > > > > > > index 8bc618289bb1..47b53912f322 100644 > > > > > > > > --- a/mm/kasan/common.c > > > > > > > > +++ b/mm/kasan/common.c > > > > > > > > @@ -51,7 +51,7 @@ depot_stack_handle_t kasan_save_stack(gfp_t flags) > > > > > > > > return stack_depot_save(entries, nr_entries, flags); > > > > > > > > } > > > > > > > > > > > > > > > > -static inline void set_track(struct kasan_track *track, gfp_t flags) > > > > > > > > +void kasan_set_track(struct kasan_track *track, gfp_t flags) > > > > > > > > { > > > > > > > > track->pid = current->pid; > > > > > > > > track->stack = kasan_save_stack(flags); > > > > > > > > @@ -299,24 +299,6 @@ struct kasan_free_meta *get_free_info(struct kmem_cache *cache, > > > > > > > > return (void *)object + cache->kasan_info.free_meta_offset; > > > > > > > > } > > > > > > > > > > > > > > > > - > > > > > > > > -static void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > - void *object, u8 tag) > > > > > > > > -{ > > > > > > > > - struct kasan_alloc_meta *alloc_meta; > > > > > > > > - u8 idx = 0; > > > > > > > > - > > > > > > > > - alloc_meta = get_alloc_info(cache, object); > > > > > > > > - > > > > > > > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > - idx = alloc_meta->free_track_idx; > > > > > > > > - alloc_meta->free_pointer_tag[idx] = tag; > > > > > > > > - alloc_meta->free_track_idx = (idx + 1) % KASAN_NR_FREE_STACKS; > > > > > > > > -#endif > > > > > > > > - > > > > > > > > - set_track(&alloc_meta->free_track[idx], GFP_NOWAIT); > > > > > > > > -} > > > > > > > > - > > > > > > > > void kasan_poison_slab(struct page *page) > > > > > > > > { > > > > > > > > unsigned long i; > > > > > > > > @@ -492,7 +474,7 @@ static void *__kasan_kmalloc(struct kmem_cache *cache, const void *object, > > > > > > > > KASAN_KMALLOC_REDZONE); > > > > > > > > > > > > > > > > if (cache->flags & SLAB_KASAN) > > > > > > > > - set_track(&get_alloc_info(cache, object)->alloc_track, flags); > > > > > > > > + kasan_set_track(&get_alloc_info(cache, object)->alloc_track, flags); > > > > > > > > > > > > > > > > return set_tag(object, tag); > > > > > > > > } > > > > > > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > > > > > > index 3372bdcaf92a..763d8a13e0ac 100644 > > > > > > > > --- a/mm/kasan/generic.c > > > > > > > > +++ b/mm/kasan/generic.c > > > > > > > > @@ -344,3 +344,21 @@ void kasan_record_aux_stack(void *addr) > > > > > > > > alloc_info->aux_stack[1] = alloc_info->aux_stack[0]; > > > > > > > > alloc_info->aux_stack[0] = kasan_save_stack(GFP_NOWAIT); > > > > > > > > } > > > > > > > > + > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_free_meta *free_meta; > > > > > > > > + > > > > > > > > + free_meta = get_free_info(cache, object); > > > > > > > > + kasan_set_track(&free_meta->free_track, GFP_NOWAIT); > > > > > > > > +} > > > > > > > > + > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_free_meta *free_meta; > > > > > > > > + > > > > > > > > + free_meta = get_free_info(cache, object); > > > > > > > > + return &free_meta->free_track; > > > > > > > > +} > > > > > > > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > > > > > > > index a7391bc83070..ad897ec36545 100644 > > > > > > > > --- a/mm/kasan/kasan.h > > > > > > > > +++ b/mm/kasan/kasan.h > > > > > > > > @@ -127,6 +127,9 @@ struct kasan_free_meta { > > > > > > > > * Otherwise it might be used for the allocator freelist. > > > > > > > > */ > > > > > > > > struct qlist_node quarantine_link; > > > > > > > > +#ifdef CONFIG_KASAN_GENERIC > > > > > > > > + struct kasan_track free_track; > > > > > > > > +#endif > > > > > > > > }; > > > > > > > > > > > > > > > > struct kasan_alloc_meta *get_alloc_info(struct kmem_cache *cache, > > > > > > > > @@ -168,6 +171,10 @@ void kasan_report_invalid_free(void *object, unsigned long ip); > > > > > > > > struct page *kasan_addr_to_page(const void *addr); > > > > > > > > > > > > > > > > depot_stack_handle_t kasan_save_stack(gfp_t flags); > > > > > > > > +void kasan_set_track(struct kasan_track *track, gfp_t flags); > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, void *object, u8 tag); > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag); > > > > > > > > > > > > > > > > #if defined(CONFIG_KASAN_GENERIC) && \ > > > > > > > > (defined(CONFIG_SLAB) || defined(CONFIG_SLUB)) > > > > > > > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > > > > > > > index 6f8f2bf8f53b..96d2657fe70f 100644 > > > > > > > > --- a/mm/kasan/report.c > > > > > > > > +++ b/mm/kasan/report.c > > > > > > > > @@ -159,26 +159,6 @@ static void describe_object_addr(struct kmem_cache *cache, void *object, > > > > > > > > (void *)(object_addr + cache->object_size)); > > > > > > > > } > > > > > > > > > > > > > > > > -static struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > - void *object, u8 tag) > > > > > > > > -{ > > > > > > > > - struct kasan_alloc_meta *alloc_meta; > > > > > > > > - int i = 0; > > > > > > > > - > > > > > > > > - alloc_meta = get_alloc_info(cache, object); > > > > > > > > - > > > > > > > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > - for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > > > > > > > > - if (alloc_meta->free_pointer_tag[i] == tag) > > > > > > > > - break; > > > > > > > > - } > > > > > > > > - if (i == KASAN_NR_FREE_STACKS) > > > > > > > > - i = alloc_meta->free_track_idx; > > > > > > > > -#endif > > > > > > > > - > > > > > > > > - return &alloc_meta->free_track[i]; > > > > > > > > -} > > > > > > > > - > > > > > > > > #ifdef CONFIG_KASAN_GENERIC > > > > > > > > static void print_stack(depot_stack_handle_t stack) > > > > > > > > { > > > > > > > > diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c > > > > > > > > index 25b7734e7013..201dee5d6ae0 100644 > > > > > > > > --- a/mm/kasan/tags.c > > > > > > > > +++ b/mm/kasan/tags.c > > > > > > > > @@ -162,3 +162,40 @@ void __hwasan_tag_memory(unsigned long addr, u8 tag, unsigned long size) > > > > > > > > kasan_poison_shadow((void *)addr, size, tag); > > > > > > > > } > > > > > > > > EXPORT_SYMBOL(__hwasan_tag_memory); > > > > > > > > + > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_alloc_meta *alloc_meta; > > > > > > > > + u8 idx = 0; > > > > > > > > + > > > > > > > > + alloc_meta = get_alloc_info(cache, object); > > > > > > > > + > > > > > > > > +#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > + idx = alloc_meta->free_track_idx; > > > > > > > > + alloc_meta->free_pointer_tag[idx] = tag; > > > > > > > > + alloc_meta->free_track_idx = (idx + 1) % KASAN_NR_FREE_STACKS; > > > > > > > > +#endif > > > > > > > > + > > > > > > > > + kasan_set_track(&alloc_meta->free_track[idx], GFP_NOWAIT); > > > > > > > > +} > > > > > > > > + > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_alloc_meta *alloc_meta; > > > > > > > > + int i = 0; > > > > > > > > + > > > > > > > > + alloc_meta = get_alloc_info(cache, object); > > > > > > > > + > > > > > > > > +#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > + for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > > > > > > > > + if (alloc_meta->free_pointer_tag[i] == tag) > > > > > > > > + break; > > > > > > > > + } > > > > > > > > + if (i == KASAN_NR_FREE_STACKS) > > > > > > > > + i = alloc_meta->free_track_idx; > > > > > > > > +#endif > > > > > > > > + > > > > > > > > + return &alloc_meta->free_track[i]; > > > > > > > > +} > > > > > > > > > > > > > > Hi Walter, > > > > > > > > > > > > > > FTR I've uploaded this for review purposes here: > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2458 > > > > > > > > > > > > > > Diff from the previous version is available as: > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2458/1..2 > > > > > > > > > > > > > > I've tested this locally and with syzkaller. This is : > > > > > > > > > > > > > > [ 80.583021][ C3] Freed by task 0: > > > > > > > [ 80.583480][ C3] kasan_save_stack+0x1b/0x40 mm/kasan/common.c:49 > > > > > > > [ 80.584056][ C3] kasan_set_track+0x1c/0x30 mm/kasan/common.c:57 > > > > > > > [ 80.584617][ C3] kasan_set_free_info+0x1b/0x30 mm/kasan/generic.c:354 > > > > > > > [ 80.585221][ C3] __kasan_slab_free+0xd8/0x120 mm/kasan/common.c:438 > > > > > > > [ 80.585814][ C3] __cache_free mm/slab.c:3426 [inline] > > > > > > > [ 80.585814][ C3] kfree+0x10b/0x2b0 mm/slab.c:3757 > > > > > > > [ 80.586291][ C3] kasan_rcu_reclaim+0x16/0x43 [test_kasan] > > > > > > > [ 80.587009][ C3] rcu_do_batch kernel/rcu/tree.c:2207 [inline] > > > > > > > [ 80.587009][ C3] rcu_core+0x59f/0x1370 kernel/rcu/tree.c:2434 > > > > > > > [ 80.587537][ C3] __do_softirq+0x26c/0x9fa kernel/softirq.c:292 > > > > > > > [ 80.588085][ C3] > > > > > > > [ 80.588367][ C3] Last one call_rcu() call stack: > > > > > > > [ 80.589052][ C3] kasan_save_stack+0x1b/0x40 mm/kasan/common.c:49 > > > > > > > [ 80.589622][ C3] kasan_record_aux_stack+0x82/0xb0 mm/kasan/generic.c:345 > > > > > > > [ 80.590254][ C3] __call_rcu kernel/rcu/tree.c:2672 [inline] > > > > > > > [ 80.590254][ C3] call_rcu+0x14f/0x7f0 kernel/rcu/tree.c:2746 > > > > > > > [ 80.590782][ C3] kasan_rcu_uaf+0xe4/0xeb [test_kasan] > > > > > > > [ 80.591697][ C3] kmalloc_tests_init+0xbc/0x1097 [test_kasan] > > > > > > > [ 80.592900][ C3] do_one_initcall+0x10a/0x7d0 init/main.c:1196 > > > > > > > [ 80.593494][ C3] do_init_module+0x1e6/0x6d0 kernel/module.c:3539 > > > > > > > [ 80.594066][ C3] load_module+0x7464/0x9450 kernel/module.c:3890 > > > > > > > [ 80.594626][ C3] __do_sys_init_module+0x1e3/0x220 kernel/module.c:3953 > > > > > > > [ 80.595265][ C3] do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295 > > > > > > > [ 80.595822][ C3] entry_SYSCALL_64_after_hwframe+0x49/0xb3 > > > > > > > > > > > > > > > > > > > > > Overall this looks very good to me. > > > > > > > But there is one aspect that bothers me. In the previous patch you had > > > > > > > code that returned NULL from kasan_get_free_track() if the object is > > > > > > > live (which means free meta is not available, it's occupied by object > > > > > > > data). Now you dropped that code, but I think we still need it. > > > > > > > Otherwise we cast user object data to free meta and print the free > > > > > > > stack/pid from whatever garbage is there. This may lead to very > > > > > > > confusing output and potentially to crashes in stackdepot. > > > > > > > > > > > > > > > > > > > Yes, I totally agree with you. In the previous email I thought that > > > > > > there is a problem with free track, but I did not point it out. Thank > > > > > > you for pointing this problem. As you mentioned, we should fix it. > > > > > > > > > > > > > What do you think about this patch on top of your patches? > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2478 > > > > > > > This way we very precisely mark the period of time when the object has > > > > > > > free track live and set. > > > > > > > If it looks good to you, feel free to incorporate it into your series. > > > > > > > > > > > > > > > > > > > Thank you for providing good idea solution. > > > > > > > > > > > > I saw this patch, that is a great patch. I think it can fix the issue > > > > > > which has garbage stack. it should work as described below. > > > > > > > > > > > > 1). When object is live, then don't print free stack. > > > > > > 2). When object is NOT alive, after free object: > > > > > > 2a). when object is in quarantine, then it can print free stack > > > > > > 2b). when object is NOT in quarantine, then it can NOT print free stack. > > > > > > > > > > > > I have a question about 2), why we don't directly use > > > > > > KASAN_KMALLOC_FREE? if we directly use it, then 2b) can print free > > > > > > stack? 2b) may has use-after-free? so that it may need free stack. > > > > > > > > > > > About 2b), I see another question. When do qlink_free(), it will be > > > written KASAN_KMALLOC_FREE from KASAN_KMALLOC_FREETRACK? if we don't > > > write shadow memory, it is still KASAN_KMALLOC_FREETRACK, then 2b) will > > > have free stack? Because I see you add KASAN_KMALLOC_FREETRACK to get > > > use-after-free in get_shadow_bug_type(). so should it not write > > > KASAN_KMALLOC_FREE? > > > > It may or may not work. > > The potential problem is that when qlink_free calls ___cache_free, > > slab/slub may start using object memory for its own purposes, e.g. > > store the next link. This next link may overwrite part of free meta. > > It actually may work because the slab/slib next link is likely to > > overlap with kasan_free_meta.quarantine_link only. And we may have > > kasan_free_meta.free_track intact while KASAN_KMALLOC_FREE is set. But > > this needs careful checking for both slab and slub and if they may use > > more than 1 word in some configurations. > > > > This problem looks like existing, even without this change? currently > KASAN may get wrong free stack? No, we should not have this problem now. Currently free track is stored in alloc meta. Alloc meta does not overlap with the object. It's only free meta that overlaps with the object and slab metadata at different periods of the block lifetime. Schematically what we have is: struct block_t { alloc_meta kasan_alloc_meta; union { user_data char[N]; slab_meta slab_meta; free_meta kasan_free_meta; }; } free_meta shared storage space with 2 other things. > Regardless of whether the shadow memory content is > KASAN_KMALLOC_FREETRACK or KASAN_KMALLOC_FREE, it may have this problem? KASAN_KMALLOC_FREETRACK is set only when nobody else uses the storage. > But because of kasan_get_free_track() have conditions to get free track, > so that if shadow memory content is KASAN_KMALLOC_FREE, then it will > avoid this problem and always print right free stack. > > > > > We can't use KASAN_KMALLOC_FREE because of this part: > > > > > > > > > > static bool __kasan_slab_free(struct kmem_cache *cache, void *object, > > > > > unsigned long ip, bool quarantine) > > > > > { > > > > > ... > > > > > kasan_poison_shadow(object, rounded_up_size, KASAN_KMALLOC_FREE); > > > > > > > > > > if ((IS_ENABLED(CONFIG_KASAN_GENERIC) && !quarantine) || > > > > > unlikely(!(cache->flags & SLAB_KASAN))) > > > > > return false; > > > > > > > > > > kasan_set_free_info(cache, object, tag); > > > > > ... > > > > > > > > > > > > > Ok, I see. When return false, then the shadow memory content has > > > > KASAN_KMALLOC_FREE, but it doesn't set free stack, so that we need to > > > > avoid this situation. Thank for you reminder. > > > > > > > > > > > > > > We may set KASAN_KMALLOC_FREE, but not set the track (or even have > > > > > memory for the track!). > > > > > The object may not have free meta allocated at all, e.g. very large > > > > > object with ctor (no place to store meta), or it may be in a mempool: > > > > > https://elixir.bootlin.com/linux/v5.7-rc6/source/mm/mempool.c#L109 > > > > > and mempool may be using the object memory itself (for its own next > > > > > link or something). > > > > > > > > > > KASAN_KMALLOC_FREETRACK very explicitly tracks the exact condition we > > > > > want: we have meta info live now and we have free track set. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95808C433DF for ; Wed, 20 May 2020 11:01:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48D6B207D3 for ; Wed, 20 May 2020 11:01:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RB/zhj/l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="mcbr3U/r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48D6B207D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tgTqXm03a9XCJNbO0cs6sc+7lGtmjM3rw3JupqSgyGA=; b=RB/zhj/llYNIF8 GQFRqqw35isKrHbFHMNTU8KbqWNAOxxsFzXlPiXibHn/IytxyJ8KMLpCwDg1HgVL8B5+mLs5XyzYm zSpkpnBecB9UmZeXui/5avGmr1Q5CkroOlHqt9oJlGF33qLSWfad0tjLVxQiyCd2wV7+raa/mVFls Gz8lBOUYoJjqaH4K3xVkPJCfwdSctra0Adg5JATLiGVVELvFTYCIIob9X5w4dRxjBAn9R0oP1YmOc mILa3QietDJWXVmfxhewXWnniorxlyIBz7thctfvX2wpJ+JSuRkGqhH9Dvl2hLKHUA3KcL3oImbYl qOe/hxrduH0a5tSH4H0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbMTL-0003tu-Pd; Wed, 20 May 2020 11:01:15 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbLH0-0008Ds-MH for linux-mediatek@lists.infradead.org; Wed, 20 May 2020 09:44:36 +0000 Received: by mail-qt1-x843.google.com with SMTP id t25so2052569qtc.0 for ; Wed, 20 May 2020 02:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WK6Eeu4700pWxp3v6K/+5f6+X4R/4p2PtasXvzK5TIU=; b=mcbr3U/rpVihQgdZiC7qnWVVMXwIxxQb7nRmzfUITYjqIZN4zlAdEs2mpnBQWDt8iP FmCGe33/DyXfujDbBsKoArekqU+KPCWukVtwCnDONUruhnJmAqeYQtED6hTDNZZqY6DG v4fl9GEI/Ygt1PxzB69A7hC+QDY7mS0TpQP9awbwAbUXFZGDEuJ7QFi+7AGcHlj6+hZu +PXGlTBJNw+CpnLWuGx4oJX37KGjtsEkmOl9zCRgoTNQdZI++/Kvjwvw054Uan0rC/xU NidhppF3k8okE/qOK+QUY8wRIkKjtLNboTUUzau2xWmGyPu37pD4oTWwk9BSu6Eerjls sI8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WK6Eeu4700pWxp3v6K/+5f6+X4R/4p2PtasXvzK5TIU=; b=rC1oxEkB8nc0tfJ4p3YJEUZyzkJme5reOVDwfgXCLRlUUUa4uPoDhIZsVuh4BigFqq 5RAJUMl3SWQrN4rTpnFkJDuP3Vnj/RJLaRowo6z5fusOkV2+KrofUBtOPug+6pW+lDku mWaT5tr3tYmtylPoCOnmhLZYL4jKDVurq2E14iI8cP4Wl4Tek8m69Vt4y1USX4G+UJWH IZT85lMTkTURUlN1OVjuF/a8fDFI8mDUv9ta6uuwBlTIrcrFe47EL1gMzWRqkBe+tv0j xTIbQCGr3HvrpyvxetLI7mqP9AZhru3cjL/e/tqmNgpyRNUnAuz8/IFPmoB96Vrj0W2K in1A== X-Gm-Message-State: AOAM531Vkb2b6ROi6oCcdTumK7zqSeQ3+6fUggU32ilLgX6jefwer3f4 eLZNLNZvjBrMCVkOAJ2Sd1KWMC+lzHDS9+VtiwkVug== X-Google-Smtp-Source: ABdhPJyd7oIp5KuKbs5jLZIRdEkysdSCDUvBdHCQFqni6ZAF8rqvNnCyMZNSmFB2s7Iyxe6BvoxifyvnHnNp532+jtI= X-Received: by 2002:ac8:6642:: with SMTP id j2mr4313272qtp.158.1589967865169; Wed, 20 May 2020 02:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20200519022517.24182-1-walter-zh.wu@mediatek.com> <1589947387.29577.35.camel@mtksdccf07> <1589951659.4440.4.camel@mtksdccf07> <1589955526.4440.22.camel@mtksdccf07> <1589966220.14692.24.camel@mtksdccf07> In-Reply-To: <1589966220.14692.24.camel@mtksdccf07> From: Dmitry Vyukov Date: Wed, 20 May 2020 11:44:12 +0200 Message-ID: Subject: Re: [PATCH v4 2/4] kasan: record and print the free track To: Walter Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200520_024427_128069_50514EFD X-CRM114-Status: GOOD ( 21.78 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream , linux-mediatek@lists.infradead.org, LKML , kasan-dev , Linux-MM , Alexander Potapenko , Andrey Ryabinin , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, May 20, 2020 at 11:17 AM Walter Wu wrote: > > > On Wed, 2020-05-20 at 13:14 +0800, Walter Wu wrote: > > > > > On Wed, May 20, 2020 at 6:03 AM Walter Wu wrote: > > > > > > > > > > > > > On Tue, May 19, 2020 at 4:25 AM Walter Wu wrote: > > > > > > > > > > > > > > > > Move free track from slub alloc meta-data to slub free meta-data in > > > > > > > > order to make struct kasan_free_meta size is 16 bytes. It is a good > > > > > > > > size because it is the minimal redzone size and a good number of > > > > > > > > alignment. > > > > > > > > > > > > > > > > For free track in generic KASAN, we do the modification in struct > > > > > > > > kasan_alloc_meta and kasan_free_meta: > > > > > > > > - remove free track from kasan_alloc_meta. > > > > > > > > - add free track into kasan_free_meta. > > > > > > > > > > > > > > > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > > > > > > > > > > > > > > > > Signed-off-by: Walter Wu > > > > > > > > Suggested-by: Dmitry Vyukov > > > > > > > > Cc: Andrey Ryabinin > > > > > > > > Cc: Dmitry Vyukov > > > > > > > > Cc: Alexander Potapenko > > > > > > > > --- > > > > > > > > mm/kasan/common.c | 22 ++-------------------- > > > > > > > > mm/kasan/generic.c | 18 ++++++++++++++++++ > > > > > > > > mm/kasan/kasan.h | 7 +++++++ > > > > > > > > mm/kasan/report.c | 20 -------------------- > > > > > > > > mm/kasan/tags.c | 37 +++++++++++++++++++++++++++++++++++++ > > > > > > > > 5 files changed, 64 insertions(+), 40 deletions(-) > > > > > > > > > > > > > > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > > > > > > > index 8bc618289bb1..47b53912f322 100644 > > > > > > > > --- a/mm/kasan/common.c > > > > > > > > +++ b/mm/kasan/common.c > > > > > > > > @@ -51,7 +51,7 @@ depot_stack_handle_t kasan_save_stack(gfp_t flags) > > > > > > > > return stack_depot_save(entries, nr_entries, flags); > > > > > > > > } > > > > > > > > > > > > > > > > -static inline void set_track(struct kasan_track *track, gfp_t flags) > > > > > > > > +void kasan_set_track(struct kasan_track *track, gfp_t flags) > > > > > > > > { > > > > > > > > track->pid = current->pid; > > > > > > > > track->stack = kasan_save_stack(flags); > > > > > > > > @@ -299,24 +299,6 @@ struct kasan_free_meta *get_free_info(struct kmem_cache *cache, > > > > > > > > return (void *)object + cache->kasan_info.free_meta_offset; > > > > > > > > } > > > > > > > > > > > > > > > > - > > > > > > > > -static void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > - void *object, u8 tag) > > > > > > > > -{ > > > > > > > > - struct kasan_alloc_meta *alloc_meta; > > > > > > > > - u8 idx = 0; > > > > > > > > - > > > > > > > > - alloc_meta = get_alloc_info(cache, object); > > > > > > > > - > > > > > > > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > - idx = alloc_meta->free_track_idx; > > > > > > > > - alloc_meta->free_pointer_tag[idx] = tag; > > > > > > > > - alloc_meta->free_track_idx = (idx + 1) % KASAN_NR_FREE_STACKS; > > > > > > > > -#endif > > > > > > > > - > > > > > > > > - set_track(&alloc_meta->free_track[idx], GFP_NOWAIT); > > > > > > > > -} > > > > > > > > - > > > > > > > > void kasan_poison_slab(struct page *page) > > > > > > > > { > > > > > > > > unsigned long i; > > > > > > > > @@ -492,7 +474,7 @@ static void *__kasan_kmalloc(struct kmem_cache *cache, const void *object, > > > > > > > > KASAN_KMALLOC_REDZONE); > > > > > > > > > > > > > > > > if (cache->flags & SLAB_KASAN) > > > > > > > > - set_track(&get_alloc_info(cache, object)->alloc_track, flags); > > > > > > > > + kasan_set_track(&get_alloc_info(cache, object)->alloc_track, flags); > > > > > > > > > > > > > > > > return set_tag(object, tag); > > > > > > > > } > > > > > > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > > > > > > index 3372bdcaf92a..763d8a13e0ac 100644 > > > > > > > > --- a/mm/kasan/generic.c > > > > > > > > +++ b/mm/kasan/generic.c > > > > > > > > @@ -344,3 +344,21 @@ void kasan_record_aux_stack(void *addr) > > > > > > > > alloc_info->aux_stack[1] = alloc_info->aux_stack[0]; > > > > > > > > alloc_info->aux_stack[0] = kasan_save_stack(GFP_NOWAIT); > > > > > > > > } > > > > > > > > + > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_free_meta *free_meta; > > > > > > > > + > > > > > > > > + free_meta = get_free_info(cache, object); > > > > > > > > + kasan_set_track(&free_meta->free_track, GFP_NOWAIT); > > > > > > > > +} > > > > > > > > + > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_free_meta *free_meta; > > > > > > > > + > > > > > > > > + free_meta = get_free_info(cache, object); > > > > > > > > + return &free_meta->free_track; > > > > > > > > +} > > > > > > > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > > > > > > > index a7391bc83070..ad897ec36545 100644 > > > > > > > > --- a/mm/kasan/kasan.h > > > > > > > > +++ b/mm/kasan/kasan.h > > > > > > > > @@ -127,6 +127,9 @@ struct kasan_free_meta { > > > > > > > > * Otherwise it might be used for the allocator freelist. > > > > > > > > */ > > > > > > > > struct qlist_node quarantine_link; > > > > > > > > +#ifdef CONFIG_KASAN_GENERIC > > > > > > > > + struct kasan_track free_track; > > > > > > > > +#endif > > > > > > > > }; > > > > > > > > > > > > > > > > struct kasan_alloc_meta *get_alloc_info(struct kmem_cache *cache, > > > > > > > > @@ -168,6 +171,10 @@ void kasan_report_invalid_free(void *object, unsigned long ip); > > > > > > > > struct page *kasan_addr_to_page(const void *addr); > > > > > > > > > > > > > > > > depot_stack_handle_t kasan_save_stack(gfp_t flags); > > > > > > > > +void kasan_set_track(struct kasan_track *track, gfp_t flags); > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, void *object, u8 tag); > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag); > > > > > > > > > > > > > > > > #if defined(CONFIG_KASAN_GENERIC) && \ > > > > > > > > (defined(CONFIG_SLAB) || defined(CONFIG_SLUB)) > > > > > > > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > > > > > > > index 6f8f2bf8f53b..96d2657fe70f 100644 > > > > > > > > --- a/mm/kasan/report.c > > > > > > > > +++ b/mm/kasan/report.c > > > > > > > > @@ -159,26 +159,6 @@ static void describe_object_addr(struct kmem_cache *cache, void *object, > > > > > > > > (void *)(object_addr + cache->object_size)); > > > > > > > > } > > > > > > > > > > > > > > > > -static struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > - void *object, u8 tag) > > > > > > > > -{ > > > > > > > > - struct kasan_alloc_meta *alloc_meta; > > > > > > > > - int i = 0; > > > > > > > > - > > > > > > > > - alloc_meta = get_alloc_info(cache, object); > > > > > > > > - > > > > > > > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > - for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > > > > > > > > - if (alloc_meta->free_pointer_tag[i] == tag) > > > > > > > > - break; > > > > > > > > - } > > > > > > > > - if (i == KASAN_NR_FREE_STACKS) > > > > > > > > - i = alloc_meta->free_track_idx; > > > > > > > > -#endif > > > > > > > > - > > > > > > > > - return &alloc_meta->free_track[i]; > > > > > > > > -} > > > > > > > > - > > > > > > > > #ifdef CONFIG_KASAN_GENERIC > > > > > > > > static void print_stack(depot_stack_handle_t stack) > > > > > > > > { > > > > > > > > diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c > > > > > > > > index 25b7734e7013..201dee5d6ae0 100644 > > > > > > > > --- a/mm/kasan/tags.c > > > > > > > > +++ b/mm/kasan/tags.c > > > > > > > > @@ -162,3 +162,40 @@ void __hwasan_tag_memory(unsigned long addr, u8 tag, unsigned long size) > > > > > > > > kasan_poison_shadow((void *)addr, size, tag); > > > > > > > > } > > > > > > > > EXPORT_SYMBOL(__hwasan_tag_memory); > > > > > > > > + > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_alloc_meta *alloc_meta; > > > > > > > > + u8 idx = 0; > > > > > > > > + > > > > > > > > + alloc_meta = get_alloc_info(cache, object); > > > > > > > > + > > > > > > > > +#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > + idx = alloc_meta->free_track_idx; > > > > > > > > + alloc_meta->free_pointer_tag[idx] = tag; > > > > > > > > + alloc_meta->free_track_idx = (idx + 1) % KASAN_NR_FREE_STACKS; > > > > > > > > +#endif > > > > > > > > + > > > > > > > > + kasan_set_track(&alloc_meta->free_track[idx], GFP_NOWAIT); > > > > > > > > +} > > > > > > > > + > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_alloc_meta *alloc_meta; > > > > > > > > + int i = 0; > > > > > > > > + > > > > > > > > + alloc_meta = get_alloc_info(cache, object); > > > > > > > > + > > > > > > > > +#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > + for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > > > > > > > > + if (alloc_meta->free_pointer_tag[i] == tag) > > > > > > > > + break; > > > > > > > > + } > > > > > > > > + if (i == KASAN_NR_FREE_STACKS) > > > > > > > > + i = alloc_meta->free_track_idx; > > > > > > > > +#endif > > > > > > > > + > > > > > > > > + return &alloc_meta->free_track[i]; > > > > > > > > +} > > > > > > > > > > > > > > Hi Walter, > > > > > > > > > > > > > > FTR I've uploaded this for review purposes here: > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2458 > > > > > > > > > > > > > > Diff from the previous version is available as: > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2458/1..2 > > > > > > > > > > > > > > I've tested this locally and with syzkaller. This is : > > > > > > > > > > > > > > [ 80.583021][ C3] Freed by task 0: > > > > > > > [ 80.583480][ C3] kasan_save_stack+0x1b/0x40 mm/kasan/common.c:49 > > > > > > > [ 80.584056][ C3] kasan_set_track+0x1c/0x30 mm/kasan/common.c:57 > > > > > > > [ 80.584617][ C3] kasan_set_free_info+0x1b/0x30 mm/kasan/generic.c:354 > > > > > > > [ 80.585221][ C3] __kasan_slab_free+0xd8/0x120 mm/kasan/common.c:438 > > > > > > > [ 80.585814][ C3] __cache_free mm/slab.c:3426 [inline] > > > > > > > [ 80.585814][ C3] kfree+0x10b/0x2b0 mm/slab.c:3757 > > > > > > > [ 80.586291][ C3] kasan_rcu_reclaim+0x16/0x43 [test_kasan] > > > > > > > [ 80.587009][ C3] rcu_do_batch kernel/rcu/tree.c:2207 [inline] > > > > > > > [ 80.587009][ C3] rcu_core+0x59f/0x1370 kernel/rcu/tree.c:2434 > > > > > > > [ 80.587537][ C3] __do_softirq+0x26c/0x9fa kernel/softirq.c:292 > > > > > > > [ 80.588085][ C3] > > > > > > > [ 80.588367][ C3] Last one call_rcu() call stack: > > > > > > > [ 80.589052][ C3] kasan_save_stack+0x1b/0x40 mm/kasan/common.c:49 > > > > > > > [ 80.589622][ C3] kasan_record_aux_stack+0x82/0xb0 mm/kasan/generic.c:345 > > > > > > > [ 80.590254][ C3] __call_rcu kernel/rcu/tree.c:2672 [inline] > > > > > > > [ 80.590254][ C3] call_rcu+0x14f/0x7f0 kernel/rcu/tree.c:2746 > > > > > > > [ 80.590782][ C3] kasan_rcu_uaf+0xe4/0xeb [test_kasan] > > > > > > > [ 80.591697][ C3] kmalloc_tests_init+0xbc/0x1097 [test_kasan] > > > > > > > [ 80.592900][ C3] do_one_initcall+0x10a/0x7d0 init/main.c:1196 > > > > > > > [ 80.593494][ C3] do_init_module+0x1e6/0x6d0 kernel/module.c:3539 > > > > > > > [ 80.594066][ C3] load_module+0x7464/0x9450 kernel/module.c:3890 > > > > > > > [ 80.594626][ C3] __do_sys_init_module+0x1e3/0x220 kernel/module.c:3953 > > > > > > > [ 80.595265][ C3] do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295 > > > > > > > [ 80.595822][ C3] entry_SYSCALL_64_after_hwframe+0x49/0xb3 > > > > > > > > > > > > > > > > > > > > > Overall this looks very good to me. > > > > > > > But there is one aspect that bothers me. In the previous patch you had > > > > > > > code that returned NULL from kasan_get_free_track() if the object is > > > > > > > live (which means free meta is not available, it's occupied by object > > > > > > > data). Now you dropped that code, but I think we still need it. > > > > > > > Otherwise we cast user object data to free meta and print the free > > > > > > > stack/pid from whatever garbage is there. This may lead to very > > > > > > > confusing output and potentially to crashes in stackdepot. > > > > > > > > > > > > > > > > > > > Yes, I totally agree with you. In the previous email I thought that > > > > > > there is a problem with free track, but I did not point it out. Thank > > > > > > you for pointing this problem. As you mentioned, we should fix it. > > > > > > > > > > > > > What do you think about this patch on top of your patches? > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2478 > > > > > > > This way we very precisely mark the period of time when the object has > > > > > > > free track live and set. > > > > > > > If it looks good to you, feel free to incorporate it into your series. > > > > > > > > > > > > > > > > > > > Thank you for providing good idea solution. > > > > > > > > > > > > I saw this patch, that is a great patch. I think it can fix the issue > > > > > > which has garbage stack. it should work as described below. > > > > > > > > > > > > 1). When object is live, then don't print free stack. > > > > > > 2). When object is NOT alive, after free object: > > > > > > 2a). when object is in quarantine, then it can print free stack > > > > > > 2b). when object is NOT in quarantine, then it can NOT print free stack. > > > > > > > > > > > > I have a question about 2), why we don't directly use > > > > > > KASAN_KMALLOC_FREE? if we directly use it, then 2b) can print free > > > > > > stack? 2b) may has use-after-free? so that it may need free stack. > > > > > > > > > > > About 2b), I see another question. When do qlink_free(), it will be > > > written KASAN_KMALLOC_FREE from KASAN_KMALLOC_FREETRACK? if we don't > > > write shadow memory, it is still KASAN_KMALLOC_FREETRACK, then 2b) will > > > have free stack? Because I see you add KASAN_KMALLOC_FREETRACK to get > > > use-after-free in get_shadow_bug_type(). so should it not write > > > KASAN_KMALLOC_FREE? > > > > It may or may not work. > > The potential problem is that when qlink_free calls ___cache_free, > > slab/slub may start using object memory for its own purposes, e.g. > > store the next link. This next link may overwrite part of free meta. > > It actually may work because the slab/slib next link is likely to > > overlap with kasan_free_meta.quarantine_link only. And we may have > > kasan_free_meta.free_track intact while KASAN_KMALLOC_FREE is set. But > > this needs careful checking for both slab and slub and if they may use > > more than 1 word in some configurations. > > > > This problem looks like existing, even without this change? currently > KASAN may get wrong free stack? No, we should not have this problem now. Currently free track is stored in alloc meta. Alloc meta does not overlap with the object. It's only free meta that overlaps with the object and slab metadata at different periods of the block lifetime. Schematically what we have is: struct block_t { alloc_meta kasan_alloc_meta; union { user_data char[N]; slab_meta slab_meta; free_meta kasan_free_meta; }; } free_meta shared storage space with 2 other things. > Regardless of whether the shadow memory content is > KASAN_KMALLOC_FREETRACK or KASAN_KMALLOC_FREE, it may have this problem? KASAN_KMALLOC_FREETRACK is set only when nobody else uses the storage. > But because of kasan_get_free_track() have conditions to get free track, > so that if shadow memory content is KASAN_KMALLOC_FREE, then it will > avoid this problem and always print right free stack. > > > > > We can't use KASAN_KMALLOC_FREE because of this part: > > > > > > > > > > static bool __kasan_slab_free(struct kmem_cache *cache, void *object, > > > > > unsigned long ip, bool quarantine) > > > > > { > > > > > ... > > > > > kasan_poison_shadow(object, rounded_up_size, KASAN_KMALLOC_FREE); > > > > > > > > > > if ((IS_ENABLED(CONFIG_KASAN_GENERIC) && !quarantine) || > > > > > unlikely(!(cache->flags & SLAB_KASAN))) > > > > > return false; > > > > > > > > > > kasan_set_free_info(cache, object, tag); > > > > > ... > > > > > > > > > > > > > Ok, I see. When return false, then the shadow memory content has > > > > KASAN_KMALLOC_FREE, but it doesn't set free stack, so that we need to > > > > avoid this situation. Thank for you reminder. > > > > > > > > > > > > > > We may set KASAN_KMALLOC_FREE, but not set the track (or even have > > > > > memory for the track!). > > > > > The object may not have free meta allocated at all, e.g. very large > > > > > object with ctor (no place to store meta), or it may be in a mempool: > > > > > https://elixir.bootlin.com/linux/v5.7-rc6/source/mm/mempool.c#L109 > > > > > and mempool may be using the object memory itself (for its own next > > > > > link or something). > > > > > > > > > > KASAN_KMALLOC_FREETRACK very explicitly tracks the exact condition we > > > > > want: we have meta info live now and we have free track set. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57136C433DF for ; Wed, 20 May 2020 11:00:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19066206F1 for ; Wed, 20 May 2020 11:00:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZrHfDhHx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="mcbr3U/r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19066206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1/3wu31h8wFbCrPNZRvzkoyDDytKwQ4ogJ+GGtif9WM=; b=ZrHfDhHxlkBkGc TkjQr9qmQccZBkVG3eJaVS072LEDxqyUFmwIl2jd5153wa4RxFooPhijogPxw8OOLyjRNxXgl+vro f49rUsbchuStqP89/sFgmAjvjiqkq46BaEZuWFWGQDt3SAJJpYQmFNcDmW8+OIJp8txdv891VxkSO WUl0okCt+OL+MVf/ghUJqQaVFit3MUApaAS8sZLY4hmXTe437X8mtM+PcLWK3FKnhB1UgFyXyKE5t y8+nxK1zs0DYkeYFp3WdkYqtzGh9Gs3KsMwsyy39YUZs/K5r8TPkaVjE9yi7RQ92q8Nn0PkSb0klp lY3CWdGByG8Hedu4lJsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbMSu-0003TV-SK; Wed, 20 May 2020 11:00:48 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbLH0-0008Dt-Kj for linux-arm-kernel@lists.infradead.org; Wed, 20 May 2020 09:44:34 +0000 Received: by mail-qt1-x842.google.com with SMTP id l1so2013943qtp.6 for ; Wed, 20 May 2020 02:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WK6Eeu4700pWxp3v6K/+5f6+X4R/4p2PtasXvzK5TIU=; b=mcbr3U/rpVihQgdZiC7qnWVVMXwIxxQb7nRmzfUITYjqIZN4zlAdEs2mpnBQWDt8iP FmCGe33/DyXfujDbBsKoArekqU+KPCWukVtwCnDONUruhnJmAqeYQtED6hTDNZZqY6DG v4fl9GEI/Ygt1PxzB69A7hC+QDY7mS0TpQP9awbwAbUXFZGDEuJ7QFi+7AGcHlj6+hZu +PXGlTBJNw+CpnLWuGx4oJX37KGjtsEkmOl9zCRgoTNQdZI++/Kvjwvw054Uan0rC/xU NidhppF3k8okE/qOK+QUY8wRIkKjtLNboTUUzau2xWmGyPu37pD4oTWwk9BSu6Eerjls sI8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WK6Eeu4700pWxp3v6K/+5f6+X4R/4p2PtasXvzK5TIU=; b=mDoIBdD2XIQxPFWki+2PII8LDU1I2AVwtuCEjQa5VPbdPRx7dYqbF6fHwAdondLxlq Ca1kT6ZeYV/RbKWouj7OFCMoXA0K1bbQfn9qc0b2vvirkgCDR2Xg1vlrGOERDs2OC8J0 uNv8mOFvL9+yDyk66G4zTHuSj2UwcZFpcUxmX/6jDJ2TMP9up1W4jpQQYlYtf+RUIrWz TqaCK20HWTTIOj3S+/+z4jPQiwKyD+BgYOJy4mcr9CVEx50huMxO3hATDbBEBSoc8Bhq aX+la4DWuZboNMqfdfSiaRzvVan7VIcgfzDF72DAnIxWyUAdf7lhVub8NOUjZF4mvyjX CpZA== X-Gm-Message-State: AOAM530dgyIMzryj+NnkxqooVFqSj6mU18edw3oWAkZSgcgjhICqpA4r P2ljx2BJTRuJ/3jviqlmjsIHxSvWfR4xzV651j4CVA== X-Google-Smtp-Source: ABdhPJyd7oIp5KuKbs5jLZIRdEkysdSCDUvBdHCQFqni6ZAF8rqvNnCyMZNSmFB2s7Iyxe6BvoxifyvnHnNp532+jtI= X-Received: by 2002:ac8:6642:: with SMTP id j2mr4313272qtp.158.1589967865169; Wed, 20 May 2020 02:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20200519022517.24182-1-walter-zh.wu@mediatek.com> <1589947387.29577.35.camel@mtksdccf07> <1589951659.4440.4.camel@mtksdccf07> <1589955526.4440.22.camel@mtksdccf07> <1589966220.14692.24.camel@mtksdccf07> In-Reply-To: <1589966220.14692.24.camel@mtksdccf07> From: Dmitry Vyukov Date: Wed, 20 May 2020 11:44:12 +0200 Message-ID: Subject: Re: [PATCH v4 2/4] kasan: record and print the free track To: Walter Wu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200520_024426_915826_9CBCD2B4 X-CRM114-Status: GOOD ( 23.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream , linux-mediatek@lists.infradead.org, LKML , kasan-dev , Linux-MM , Alexander Potapenko , Andrey Ryabinin , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 20, 2020 at 11:17 AM Walter Wu wrote: > > > On Wed, 2020-05-20 at 13:14 +0800, Walter Wu wrote: > > > > > On Wed, May 20, 2020 at 6:03 AM Walter Wu wrote: > > > > > > > > > > > > > On Tue, May 19, 2020 at 4:25 AM Walter Wu wrote: > > > > > > > > > > > > > > > > Move free track from slub alloc meta-data to slub free meta-data in > > > > > > > > order to make struct kasan_free_meta size is 16 bytes. It is a good > > > > > > > > size because it is the minimal redzone size and a good number of > > > > > > > > alignment. > > > > > > > > > > > > > > > > For free track in generic KASAN, we do the modification in struct > > > > > > > > kasan_alloc_meta and kasan_free_meta: > > > > > > > > - remove free track from kasan_alloc_meta. > > > > > > > > - add free track into kasan_free_meta. > > > > > > > > > > > > > > > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > > > > > > > > > > > > > > > > Signed-off-by: Walter Wu > > > > > > > > Suggested-by: Dmitry Vyukov > > > > > > > > Cc: Andrey Ryabinin > > > > > > > > Cc: Dmitry Vyukov > > > > > > > > Cc: Alexander Potapenko > > > > > > > > --- > > > > > > > > mm/kasan/common.c | 22 ++-------------------- > > > > > > > > mm/kasan/generic.c | 18 ++++++++++++++++++ > > > > > > > > mm/kasan/kasan.h | 7 +++++++ > > > > > > > > mm/kasan/report.c | 20 -------------------- > > > > > > > > mm/kasan/tags.c | 37 +++++++++++++++++++++++++++++++++++++ > > > > > > > > 5 files changed, 64 insertions(+), 40 deletions(-) > > > > > > > > > > > > > > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > > > > > > > index 8bc618289bb1..47b53912f322 100644 > > > > > > > > --- a/mm/kasan/common.c > > > > > > > > +++ b/mm/kasan/common.c > > > > > > > > @@ -51,7 +51,7 @@ depot_stack_handle_t kasan_save_stack(gfp_t flags) > > > > > > > > return stack_depot_save(entries, nr_entries, flags); > > > > > > > > } > > > > > > > > > > > > > > > > -static inline void set_track(struct kasan_track *track, gfp_t flags) > > > > > > > > +void kasan_set_track(struct kasan_track *track, gfp_t flags) > > > > > > > > { > > > > > > > > track->pid = current->pid; > > > > > > > > track->stack = kasan_save_stack(flags); > > > > > > > > @@ -299,24 +299,6 @@ struct kasan_free_meta *get_free_info(struct kmem_cache *cache, > > > > > > > > return (void *)object + cache->kasan_info.free_meta_offset; > > > > > > > > } > > > > > > > > > > > > > > > > - > > > > > > > > -static void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > - void *object, u8 tag) > > > > > > > > -{ > > > > > > > > - struct kasan_alloc_meta *alloc_meta; > > > > > > > > - u8 idx = 0; > > > > > > > > - > > > > > > > > - alloc_meta = get_alloc_info(cache, object); > > > > > > > > - > > > > > > > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > - idx = alloc_meta->free_track_idx; > > > > > > > > - alloc_meta->free_pointer_tag[idx] = tag; > > > > > > > > - alloc_meta->free_track_idx = (idx + 1) % KASAN_NR_FREE_STACKS; > > > > > > > > -#endif > > > > > > > > - > > > > > > > > - set_track(&alloc_meta->free_track[idx], GFP_NOWAIT); > > > > > > > > -} > > > > > > > > - > > > > > > > > void kasan_poison_slab(struct page *page) > > > > > > > > { > > > > > > > > unsigned long i; > > > > > > > > @@ -492,7 +474,7 @@ static void *__kasan_kmalloc(struct kmem_cache *cache, const void *object, > > > > > > > > KASAN_KMALLOC_REDZONE); > > > > > > > > > > > > > > > > if (cache->flags & SLAB_KASAN) > > > > > > > > - set_track(&get_alloc_info(cache, object)->alloc_track, flags); > > > > > > > > + kasan_set_track(&get_alloc_info(cache, object)->alloc_track, flags); > > > > > > > > > > > > > > > > return set_tag(object, tag); > > > > > > > > } > > > > > > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > > > > > > > index 3372bdcaf92a..763d8a13e0ac 100644 > > > > > > > > --- a/mm/kasan/generic.c > > > > > > > > +++ b/mm/kasan/generic.c > > > > > > > > @@ -344,3 +344,21 @@ void kasan_record_aux_stack(void *addr) > > > > > > > > alloc_info->aux_stack[1] = alloc_info->aux_stack[0]; > > > > > > > > alloc_info->aux_stack[0] = kasan_save_stack(GFP_NOWAIT); > > > > > > > > } > > > > > > > > + > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_free_meta *free_meta; > > > > > > > > + > > > > > > > > + free_meta = get_free_info(cache, object); > > > > > > > > + kasan_set_track(&free_meta->free_track, GFP_NOWAIT); > > > > > > > > +} > > > > > > > > + > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_free_meta *free_meta; > > > > > > > > + > > > > > > > > + free_meta = get_free_info(cache, object); > > > > > > > > + return &free_meta->free_track; > > > > > > > > +} > > > > > > > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > > > > > > > index a7391bc83070..ad897ec36545 100644 > > > > > > > > --- a/mm/kasan/kasan.h > > > > > > > > +++ b/mm/kasan/kasan.h > > > > > > > > @@ -127,6 +127,9 @@ struct kasan_free_meta { > > > > > > > > * Otherwise it might be used for the allocator freelist. > > > > > > > > */ > > > > > > > > struct qlist_node quarantine_link; > > > > > > > > +#ifdef CONFIG_KASAN_GENERIC > > > > > > > > + struct kasan_track free_track; > > > > > > > > +#endif > > > > > > > > }; > > > > > > > > > > > > > > > > struct kasan_alloc_meta *get_alloc_info(struct kmem_cache *cache, > > > > > > > > @@ -168,6 +171,10 @@ void kasan_report_invalid_free(void *object, unsigned long ip); > > > > > > > > struct page *kasan_addr_to_page(const void *addr); > > > > > > > > > > > > > > > > depot_stack_handle_t kasan_save_stack(gfp_t flags); > > > > > > > > +void kasan_set_track(struct kasan_track *track, gfp_t flags); > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, void *object, u8 tag); > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag); > > > > > > > > > > > > > > > > #if defined(CONFIG_KASAN_GENERIC) && \ > > > > > > > > (defined(CONFIG_SLAB) || defined(CONFIG_SLUB)) > > > > > > > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > > > > > > > index 6f8f2bf8f53b..96d2657fe70f 100644 > > > > > > > > --- a/mm/kasan/report.c > > > > > > > > +++ b/mm/kasan/report.c > > > > > > > > @@ -159,26 +159,6 @@ static void describe_object_addr(struct kmem_cache *cache, void *object, > > > > > > > > (void *)(object_addr + cache->object_size)); > > > > > > > > } > > > > > > > > > > > > > > > > -static struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > - void *object, u8 tag) > > > > > > > > -{ > > > > > > > > - struct kasan_alloc_meta *alloc_meta; > > > > > > > > - int i = 0; > > > > > > > > - > > > > > > > > - alloc_meta = get_alloc_info(cache, object); > > > > > > > > - > > > > > > > > -#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > - for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > > > > > > > > - if (alloc_meta->free_pointer_tag[i] == tag) > > > > > > > > - break; > > > > > > > > - } > > > > > > > > - if (i == KASAN_NR_FREE_STACKS) > > > > > > > > - i = alloc_meta->free_track_idx; > > > > > > > > -#endif > > > > > > > > - > > > > > > > > - return &alloc_meta->free_track[i]; > > > > > > > > -} > > > > > > > > - > > > > > > > > #ifdef CONFIG_KASAN_GENERIC > > > > > > > > static void print_stack(depot_stack_handle_t stack) > > > > > > > > { > > > > > > > > diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c > > > > > > > > index 25b7734e7013..201dee5d6ae0 100644 > > > > > > > > --- a/mm/kasan/tags.c > > > > > > > > +++ b/mm/kasan/tags.c > > > > > > > > @@ -162,3 +162,40 @@ void __hwasan_tag_memory(unsigned long addr, u8 tag, unsigned long size) > > > > > > > > kasan_poison_shadow((void *)addr, size, tag); > > > > > > > > } > > > > > > > > EXPORT_SYMBOL(__hwasan_tag_memory); > > > > > > > > + > > > > > > > > +void kasan_set_free_info(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_alloc_meta *alloc_meta; > > > > > > > > + u8 idx = 0; > > > > > > > > + > > > > > > > > + alloc_meta = get_alloc_info(cache, object); > > > > > > > > + > > > > > > > > +#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > + idx = alloc_meta->free_track_idx; > > > > > > > > + alloc_meta->free_pointer_tag[idx] = tag; > > > > > > > > + alloc_meta->free_track_idx = (idx + 1) % KASAN_NR_FREE_STACKS; > > > > > > > > +#endif > > > > > > > > + > > > > > > > > + kasan_set_track(&alloc_meta->free_track[idx], GFP_NOWAIT); > > > > > > > > +} > > > > > > > > + > > > > > > > > +struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > > > > > > > + void *object, u8 tag) > > > > > > > > +{ > > > > > > > > + struct kasan_alloc_meta *alloc_meta; > > > > > > > > + int i = 0; > > > > > > > > + > > > > > > > > + alloc_meta = get_alloc_info(cache, object); > > > > > > > > + > > > > > > > > +#ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > > > > > > > + for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > > > > > > > > + if (alloc_meta->free_pointer_tag[i] == tag) > > > > > > > > + break; > > > > > > > > + } > > > > > > > > + if (i == KASAN_NR_FREE_STACKS) > > > > > > > > + i = alloc_meta->free_track_idx; > > > > > > > > +#endif > > > > > > > > + > > > > > > > > + return &alloc_meta->free_track[i]; > > > > > > > > +} > > > > > > > > > > > > > > Hi Walter, > > > > > > > > > > > > > > FTR I've uploaded this for review purposes here: > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2458 > > > > > > > > > > > > > > Diff from the previous version is available as: > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2458/1..2 > > > > > > > > > > > > > > I've tested this locally and with syzkaller. This is : > > > > > > > > > > > > > > [ 80.583021][ C3] Freed by task 0: > > > > > > > [ 80.583480][ C3] kasan_save_stack+0x1b/0x40 mm/kasan/common.c:49 > > > > > > > [ 80.584056][ C3] kasan_set_track+0x1c/0x30 mm/kasan/common.c:57 > > > > > > > [ 80.584617][ C3] kasan_set_free_info+0x1b/0x30 mm/kasan/generic.c:354 > > > > > > > [ 80.585221][ C3] __kasan_slab_free+0xd8/0x120 mm/kasan/common.c:438 > > > > > > > [ 80.585814][ C3] __cache_free mm/slab.c:3426 [inline] > > > > > > > [ 80.585814][ C3] kfree+0x10b/0x2b0 mm/slab.c:3757 > > > > > > > [ 80.586291][ C3] kasan_rcu_reclaim+0x16/0x43 [test_kasan] > > > > > > > [ 80.587009][ C3] rcu_do_batch kernel/rcu/tree.c:2207 [inline] > > > > > > > [ 80.587009][ C3] rcu_core+0x59f/0x1370 kernel/rcu/tree.c:2434 > > > > > > > [ 80.587537][ C3] __do_softirq+0x26c/0x9fa kernel/softirq.c:292 > > > > > > > [ 80.588085][ C3] > > > > > > > [ 80.588367][ C3] Last one call_rcu() call stack: > > > > > > > [ 80.589052][ C3] kasan_save_stack+0x1b/0x40 mm/kasan/common.c:49 > > > > > > > [ 80.589622][ C3] kasan_record_aux_stack+0x82/0xb0 mm/kasan/generic.c:345 > > > > > > > [ 80.590254][ C3] __call_rcu kernel/rcu/tree.c:2672 [inline] > > > > > > > [ 80.590254][ C3] call_rcu+0x14f/0x7f0 kernel/rcu/tree.c:2746 > > > > > > > [ 80.590782][ C3] kasan_rcu_uaf+0xe4/0xeb [test_kasan] > > > > > > > [ 80.591697][ C3] kmalloc_tests_init+0xbc/0x1097 [test_kasan] > > > > > > > [ 80.592900][ C3] do_one_initcall+0x10a/0x7d0 init/main.c:1196 > > > > > > > [ 80.593494][ C3] do_init_module+0x1e6/0x6d0 kernel/module.c:3539 > > > > > > > [ 80.594066][ C3] load_module+0x7464/0x9450 kernel/module.c:3890 > > > > > > > [ 80.594626][ C3] __do_sys_init_module+0x1e3/0x220 kernel/module.c:3953 > > > > > > > [ 80.595265][ C3] do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295 > > > > > > > [ 80.595822][ C3] entry_SYSCALL_64_after_hwframe+0x49/0xb3 > > > > > > > > > > > > > > > > > > > > > Overall this looks very good to me. > > > > > > > But there is one aspect that bothers me. In the previous patch you had > > > > > > > code that returned NULL from kasan_get_free_track() if the object is > > > > > > > live (which means free meta is not available, it's occupied by object > > > > > > > data). Now you dropped that code, but I think we still need it. > > > > > > > Otherwise we cast user object data to free meta and print the free > > > > > > > stack/pid from whatever garbage is there. This may lead to very > > > > > > > confusing output and potentially to crashes in stackdepot. > > > > > > > > > > > > > > > > > > > Yes, I totally agree with you. In the previous email I thought that > > > > > > there is a problem with free track, but I did not point it out. Thank > > > > > > you for pointing this problem. As you mentioned, we should fix it. > > > > > > > > > > > > > What do you think about this patch on top of your patches? > > > > > > > https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/2478 > > > > > > > This way we very precisely mark the period of time when the object has > > > > > > > free track live and set. > > > > > > > If it looks good to you, feel free to incorporate it into your series. > > > > > > > > > > > > > > > > > > > Thank you for providing good idea solution. > > > > > > > > > > > > I saw this patch, that is a great patch. I think it can fix the issue > > > > > > which has garbage stack. it should work as described below. > > > > > > > > > > > > 1). When object is live, then don't print free stack. > > > > > > 2). When object is NOT alive, after free object: > > > > > > 2a). when object is in quarantine, then it can print free stack > > > > > > 2b). when object is NOT in quarantine, then it can NOT print free stack. > > > > > > > > > > > > I have a question about 2), why we don't directly use > > > > > > KASAN_KMALLOC_FREE? if we directly use it, then 2b) can print free > > > > > > stack? 2b) may has use-after-free? so that it may need free stack. > > > > > > > > > > > About 2b), I see another question. When do qlink_free(), it will be > > > written KASAN_KMALLOC_FREE from KASAN_KMALLOC_FREETRACK? if we don't > > > write shadow memory, it is still KASAN_KMALLOC_FREETRACK, then 2b) will > > > have free stack? Because I see you add KASAN_KMALLOC_FREETRACK to get > > > use-after-free in get_shadow_bug_type(). so should it not write > > > KASAN_KMALLOC_FREE? > > > > It may or may not work. > > The potential problem is that when qlink_free calls ___cache_free, > > slab/slub may start using object memory for its own purposes, e.g. > > store the next link. This next link may overwrite part of free meta. > > It actually may work because the slab/slib next link is likely to > > overlap with kasan_free_meta.quarantine_link only. And we may have > > kasan_free_meta.free_track intact while KASAN_KMALLOC_FREE is set. But > > this needs careful checking for both slab and slub and if they may use > > more than 1 word in some configurations. > > > > This problem looks like existing, even without this change? currently > KASAN may get wrong free stack? No, we should not have this problem now. Currently free track is stored in alloc meta. Alloc meta does not overlap with the object. It's only free meta that overlaps with the object and slab metadata at different periods of the block lifetime. Schematically what we have is: struct block_t { alloc_meta kasan_alloc_meta; union { user_data char[N]; slab_meta slab_meta; free_meta kasan_free_meta; }; } free_meta shared storage space with 2 other things. > Regardless of whether the shadow memory content is > KASAN_KMALLOC_FREETRACK or KASAN_KMALLOC_FREE, it may have this problem? KASAN_KMALLOC_FREETRACK is set only when nobody else uses the storage. > But because of kasan_get_free_track() have conditions to get free track, > so that if shadow memory content is KASAN_KMALLOC_FREE, then it will > avoid this problem and always print right free stack. > > > > > We can't use KASAN_KMALLOC_FREE because of this part: > > > > > > > > > > static bool __kasan_slab_free(struct kmem_cache *cache, void *object, > > > > > unsigned long ip, bool quarantine) > > > > > { > > > > > ... > > > > > kasan_poison_shadow(object, rounded_up_size, KASAN_KMALLOC_FREE); > > > > > > > > > > if ((IS_ENABLED(CONFIG_KASAN_GENERIC) && !quarantine) || > > > > > unlikely(!(cache->flags & SLAB_KASAN))) > > > > > return false; > > > > > > > > > > kasan_set_free_info(cache, object, tag); > > > > > ... > > > > > > > > > > > > > Ok, I see. When return false, then the shadow memory content has > > > > KASAN_KMALLOC_FREE, but it doesn't set free stack, so that we need to > > > > avoid this situation. Thank for you reminder. > > > > > > > > > > > > > > We may set KASAN_KMALLOC_FREE, but not set the track (or even have > > > > > memory for the track!). > > > > > The object may not have free meta allocated at all, e.g. very large > > > > > object with ctor (no place to store meta), or it may be in a mempool: > > > > > https://elixir.bootlin.com/linux/v5.7-rc6/source/mm/mempool.c#L109 > > > > > and mempool may be using the object memory itself (for its own next > > > > > link or something). > > > > > > > > > > KASAN_KMALLOC_FREETRACK very explicitly tracks the exact condition we > > > > > want: we have meta info live now and we have free track set. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel