From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Vyukov Date: Mon, 21 Oct 2019 16:05:41 +0000 Subject: Re: WARNING: refcount bug in find_key_to_update Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <000000000000830fe50595115344@google.com> <8509.1571673553@warthog.procyon.org.uk> In-Reply-To: <8509.1571673553@warthog.procyon.org.uk> To: David Howells Cc: syzbot , Jarkko Sakkinen , James Morris , keyrings@vger.kernel.org, LKML , linux-security-module , "Serge E. Hallyn" , syzkaller-bugs On Mon, Oct 21, 2019 at 5:59 PM David Howells wrote: > > syzbot wrote: > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?xc8adab600000 > > How do I tell what's been passed into the add_key for the encrypted key? Hi David, The easiest and most reliable would be to run it and dump the data in the kernel function. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF69BCA9EAF for ; Mon, 21 Oct 2019 16:06:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 993842084C for ; Mon, 21 Oct 2019 16:06:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="J7m8XyLb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729604AbfJUQFz (ORCPT ); Mon, 21 Oct 2019 12:05:55 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:34441 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbfJUQFy (ORCPT ); Mon, 21 Oct 2019 12:05:54 -0400 Received: by mail-qt1-f194.google.com with SMTP id e14so2025419qto.1 for ; Mon, 21 Oct 2019 09:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=531cCBl4i9yQxVHY6Fc4jmInfUcTFsMFBRwLLqkbbsA=; b=J7m8XyLbnCcCFa+RkEUdG5aQ77qhKM2xKK6QuM8oOcwpzcbiNdS/9JQ7KHm5eohZ+g 0KPgSRseqMPuYQ07ppyBTTjVZ+dlpfWvPN5i8MFVoOVMdK6LVvzEBtlJxbZBiE3ShkEi I0stg3FSjNkckzSGuEwjilGaEm1Uv+080YwkGYmY2q9688JWtfo6YO6wTTOyKRGLoHCA 4wF0ppmavgG3PZYTMg3dNwAqDzBzpBoLpEXUkC/8VdD+K0KvVqulh4h/2Oi6M6hpiTQ5 UPzd7k0Iy84JOsG/yGm8aHLFC4AS/owz2/KzFs2D6M7pSTnx7w988q0bGHsDrpv/M7pu ViTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=531cCBl4i9yQxVHY6Fc4jmInfUcTFsMFBRwLLqkbbsA=; b=GmNqzKvM1/r1wp/BO5vb7mh2823lMXugEuYgiHSUibCMEAzBzelxf+JuBXXUCZNCTK brz7Z+y1mR304W488DrvNFDqYPZOJBsLxJNqFy8tDKaNLiADh/EOmkupIdLh3pEkdCkL d5FdrievglxTAsDc+vI7ypOkd5z/nnJjdI9MmB6mHuMFxM8MIEafJfg6PMHXVJZtXv/E vj3rAHnDfk02QkiAhV9GtbUGxxPGw8Sy55HgGrJAC/OpmDeUvHBMBZ2rVLkF9z9cvzLF MTSb0TpJWHSS8fsiV06hnzsqnJ8jDsp4UvLCVaa/3GksW5vQWV+LLSxHdF6g56dXUDEM DWSQ== X-Gm-Message-State: APjAAAXJmq1QSQqNCqRExY/lyokKwKXU1By7pPYn1wlZuqB63IsfWv+3 NKKJpJHs95JLFh2GLI8Nhxr27S/E6fiUiVm4A6k5PQ== X-Google-Smtp-Source: APXvYqx+V80R0g8ka4mvuphFpmFxHIfFs0r+6m1My9wPI75glpXldHuxqSk3nZBPJ2DOnrYuuGI+ifd5vi7AHNKn2uE= X-Received: by 2002:ac8:3408:: with SMTP id u8mr25315451qtb.380.1571673953322; Mon, 21 Oct 2019 09:05:53 -0700 (PDT) MIME-Version: 1.0 References: <000000000000830fe50595115344@google.com> <8509.1571673553@warthog.procyon.org.uk> In-Reply-To: <8509.1571673553@warthog.procyon.org.uk> From: Dmitry Vyukov Date: Mon, 21 Oct 2019 18:05:41 +0200 Message-ID: Subject: Re: WARNING: refcount bug in find_key_to_update To: David Howells Cc: syzbot , Jarkko Sakkinen , James Morris , keyrings@vger.kernel.org, LKML , linux-security-module , "Serge E. Hallyn" , syzkaller-bugs Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 21, 2019 at 5:59 PM David Howells wrote: > > syzbot wrote: > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11c8adab600000 > > How do I tell what's been passed into the add_key for the encrypted key? Hi David, The easiest and most reliable would be to run it and dump the data in the kernel function.