From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF75CA9ECF for ; Fri, 1 Nov 2019 18:03:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 037CB21897 for ; Fri, 1 Nov 2019 18:03:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="f+FQf0a/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727079AbfKASD1 (ORCPT ); Fri, 1 Nov 2019 14:03:27 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:34862 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbfKASDZ (ORCPT ); Fri, 1 Nov 2019 14:03:25 -0400 Received: by mail-qt1-f194.google.com with SMTP id r22so3939989qtt.2 for ; Fri, 01 Nov 2019 11:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k8D0kxdveIpuC6UigtyTU7urwvjnhy2BPAZbxffIYkA=; b=f+FQf0a/ifANPLSwBV+ZkSgxM5Jp/onawYBupphq/LsTjIej2U+EoZiplzDJaj+w9f f+HNklqSQZF2LnhTGh7KLY0AgjSJJzx2aI4Hn67VjCULaV+wlrwW2pf4YAr/1vY0DU+H O69QaL/E2EfY4PDEOhF0PmKMeT/GqXZeYkLWyjeGmh84W4mLY39849znwYXB3Fd4ApvX kV0JygyDXSgMrkVC+vPJcBomOufJZwPeHCOl80eSjh8PAx1zeAmiwhTd6SV2DOpohy6a V1sA4A5q91zDXDOsrN+gypNTEucv0fgbKEUPi6AZLEvMGgH6SuL6ap6GoYm9uHPF2Tcv ZSBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k8D0kxdveIpuC6UigtyTU7urwvjnhy2BPAZbxffIYkA=; b=V8i9lv4gadSZyS0Ch8JrdM6oFBjgVRvStqNf/baKcw4yMZvZvIGf5WbhILXtiaEuGr yoEY+hLCDiJK2qqKQ2Ymq06zSUiDvr+TTxrvoL0p7qHO6EnJG+Ff2YPz9u+fwv1geRiz 2Oj8acNh6GYTNX8ACDJtpMdeE41rLX8qCTvCPQcIxkXB72SbPM/YEGChQhRVD6ZhoVfY 8gR828Z0x3qQyQ/aUKWUp/EHxdc1p0bJsDNEonkrTvXwleDQo874Hbfao1UBU4CzkL06 evJPYBQ5sJwt9S0cp7oT7KFTGfcetvyD9Ua03R7/sURCsQo69rp16QLFbCMovf+kHbdL Girw== X-Gm-Message-State: APjAAAVRFOdtNju1FOE8TAh5QA06cvONWNQtHEqgRuHiqwLXuHvDgUNl nlCqjFnPkChKdw1PO/fciUPhn3r2AeO/i90BkvaxAQ== X-Google-Smtp-Source: APXvYqzRbyd6XaGiNNRA/t8TJsdO3rNYFVp/yOubJZnZL7YPB7EhMjaMtD1BiKpR716ZDhtNj0+0ij3ku29znK/XFIg= X-Received: by 2002:ac8:1103:: with SMTP id c3mr676808qtj.50.1572631402359; Fri, 01 Nov 2019 11:03:22 -0700 (PDT) MIME-Version: 1.0 References: <00000000000069801e05961be5fb@google.com> <0e2bc2bf-2a7a-73c5-03e2-9d08f89f0ffa@kernel.dk> <7fe298b7-4bc9-58e7-4173-63e3cbcbef25@kernel.dk> In-Reply-To: <7fe298b7-4bc9-58e7-4173-63e3cbcbef25@kernel.dk> From: Dmitry Vyukov Date: Fri, 1 Nov 2019 19:03:10 +0100 Message-ID: Subject: Re: BUG: unable to handle kernel paging request in io_wq_cancel_all To: Jens Axboe Cc: syzbot , Andrew Morton , Dan Williams , David Howells , Greg Kroah-Hartman , Johannes Weiner , Joel Fernandes , linux-block , linux-fsdevel , LKML , mchehab+samsung@kernel.org, Ingo Molnar , patrick.bellasi@arm.com, Richard Guy Briggs , Steven Rostedt , syzkaller-bugs , Al Viro , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Nov 1, 2019 at 6:56 PM Jens Axboe wrote: > > On 11/1/19 11:50 AM, Dmitry Vyukov wrote: > > On Wed, Oct 30, 2019 at 3:41 PM Jens Axboe wrote: > >> > >> On 10/30/19 1:44 AM, syzbot wrote: > >>> syzbot has bisected this bug to: > >>> > >>> commit ef0524d3654628ead811f328af0a4a2953a8310f > >>> Author: Jens Axboe > >>> Date: Thu Oct 24 13:25:42 2019 +0000 > >>> > >>> io_uring: replace workqueue usage with io-wq > >>> > >>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16acf5d0e00000 > >>> start commit: c57cf383 Add linux-next specific files for 20191029 > >>> git tree: linux-next > >>> final crash: https://syzkaller.appspot.com/x/report.txt?x=15acf5d0e00000 > >>> console output: https://syzkaller.appspot.com/x/log.txt?x=11acf5d0e00000 > >>> kernel config: https://syzkaller.appspot.com/x/.config?x=cb86688f30db053d > >>> dashboard link: https://syzkaller.appspot.com/bug?extid=221cc24572a2fed23b6b > >>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=168671d4e00000 > >>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=140f4898e00000 > >>> > >>> Reported-by: syzbot+221cc24572a2fed23b6b@syzkaller.appspotmail.com > >>> Fixes: ef0524d36546 ("io_uring: replace workqueue usage with io-wq") > >> > >> Good catch, it's a case of NULL vs ERR_PTR() confusion. I'll fold in > >> the below fix. > > > > Hi Jens, > > > > Please either add the syzbot tag to commit, or close manually with > > "#syz fix" (though requires waiting until the fixed commit is in > > linux-next). > > See https://goo.gl/tpsmEJ#rebuilt-treesamended-patches for details. > > Otherwise, the bug will be considered open and will waste time of > > humans looking at open bugs and prevent syzbot from reporting new bugs > > in io_uring. > > It's queued up since two days ago: > > http://git.kernel.dk/cgit/linux-block/commit/?h=for-5.5/io_uring&id=975c99a570967dd48e917dd7853867fee3febabd > > and should have the right attributions, so hopefully it'll catch up > eventually. > > -- > Jens Axboe > Cool! Thanks! I've seen "fold in" and historically lots of developers did not add the tag during amending, so wanted to double check.