From: Dmitry Vyukov <dvyukov@google.com>
To: Hao Xu <haoxu@linux.alibaba.com>
Cc: syzbot <syzbot+ea2f1484cffe5109dc10@syzkaller.appspotmail.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [syzbot] WARNING in io_wqe_enqueue
Date: Tue, 8 Jun 2021 14:01:19 +0200 [thread overview]
Message-ID: <CACT4Y+az0ZsTRyj+FjA08ZjpoesoxSde+1vxn-WQnTgXM1rPGQ@mail.gmail.com> (raw)
In-Reply-To: <b9cb6dc4-3dfe-de60-a933-1f423301b3ca@linux.alibaba.com>
On Tue, Jun 8, 2021 at 11:47 AM Hao Xu <haoxu@linux.alibaba.com> wrote:
>
> 在 2021/6/5 上午4:22, syzbot 写道:
> > syzbot has bisected this issue to:
> >
> > commit 24369c2e3bb06d8c4e71fd6ceaf4f8a01ae79b7c
> > Author: Pavel Begunkov <asml.silence@gmail.com>
> > Date: Tue Jan 28 00:15:48 2020 +0000
> >
> > io_uring: add io-wq workqueue sharing
> >
> > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17934777d00000
> > start commit: f88cd3fb Merge tag 'vfio-v5.13-rc5' of git://github.com/aw..
> > git tree: upstream
> > final oops: https://syzkaller.appspot.com/x/report.txt?x=14534777d00000
> > console output: https://syzkaller.appspot.com/x/log.txt?x=10534777d00000
> > kernel config: https://syzkaller.appspot.com/x/.config?x=82d85e75046e5e64
> > dashboard link: https://syzkaller.appspot.com/bug?extid=ea2f1484cffe5109dc10
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16d5772fd00000
> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10525947d00000
> >
> > Reported-by: syzbot+ea2f1484cffe5109dc10@syzkaller.appspotmail.com
> > Fixes: 24369c2e3bb0 ("io_uring: add io-wq workqueue sharing")
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> >
> This is not a bug, the repro program first set RLIMIT_NPROC to 0, then
> submits an unbound work whcih raises a warning of
> WARN_ON_ONCE(!acct->max_workers). Since unbound->max_workers is
> task_rlimit(current, RLIMIT_NPROC), so it is expected.
Hi Hao,
Then this is a mis-use of WARN_ON. If this check is intended for end
users, it needs to use pr_err (also print understandable message and
no stack trace which is most likely not useful for end users):
https://elixir.bootlin.com/linux/v5.13-rc5/source/include/asm-generic/bug.h#L71
next prev parent reply other threads:[~2021-06-08 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 9:11 [syzbot] WARNING in io_wqe_enqueue syzbot
2021-06-04 9:22 ` syzbot
2021-06-04 20:22 ` syzbot
2021-06-08 9:47 ` Hao Xu
2021-06-08 12:01 ` Dmitry Vyukov [this message]
2021-06-10 3:03 ` Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+az0ZsTRyj+FjA08ZjpoesoxSde+1vxn-WQnTgXM1rPGQ@mail.gmail.com \
--to=dvyukov@google.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=haoxu@linux.alibaba.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+ea2f1484cffe5109dc10@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.