From: Dmitry Vyukov <dvyukov@google.com> To: Johannes Berg <johannes@sipsolutions.net> Cc: David Gow <davidgow@google.com>, Vincent Whitchurch <vincent.whitchurch@axis.com>, Patricia Alfonso <trishalfonso@google.com>, Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>, anton.ivanov@cambridgegreys.com, Brendan Higgins <brendanhiggins@google.com>, kasan-dev <kasan-dev@googlegroups.com>, linux-um@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>, Daniel Latypov <dlatypov@google.com> Subject: Re: [RFC PATCH v3] UML: add support for KASAN under x86_64 Date: Fri, 27 May 2022 15:18:34 +0200 [thread overview] Message-ID: <CACT4Y+bhBMDn80u=W8VBbn4uZg1oD8zsE3RJJC-YJRS2i8Q2oA@mail.gmail.com> (raw) In-Reply-To: <6fa1ebe49b8d574fb1c82aefeeb54439d9c98750.camel@sipsolutions.net> On Fri, 27 May 2022 at 15:15, Johannes Berg <johannes@sipsolutions.net> wrote: > > On Fri, 2022-05-27 at 15:09 +0200, Dmitry Vyukov wrote: > > > I did note (this is more for kasan-dev@) that the "freed by" is fairly > > > much useless when using kfree_rcu(), it might be worthwhile to annotate > > > that somehow, so the stack trace is recorded by kfree_rcu() already, > > > rather than just showing the RCU callback used for that. > > > > KASAN is doing it for several years now, see e.g.: > > https://groups.google.com/g/syzkaller-bugs/c/eTW9zom4O2o/m/_v7cOo2RFwAJ > > > > Hm. It didn't for me: Please post a full report with line numbers and kernel version. > > BUG: KASAN: use-after-free in ieee80211_vif_use_reserved_context+0x32d/0x40f [mac80211] > > Read of size 4 at addr 0000000065c73340 by task kworker/u2:1/17 > > Yes. > > > CPU: 0 PID: 17 Comm: kworker/u2:1 Tainted: G O 5.18.0-rc1 #5 > > Workqueue: phy0 ieee80211_chswitch_work [mac80211] > > Stack: > > 60ba783f 00000000 10000c268f4e 60ba783f > > 60e60847 70dc9928 719f6e99 00000000 > > 71883b20 60bb0b42 60bb0b19 65c73340 > > Call Trace: > > [<600447ea>] show_stack+0x13e/0x14d > > [<60bb0b42>] dump_stack_lvl+0x29/0x2e > > [<602ef7c0>] print_report+0x15d/0x60b > > [<602efdc0>] kasan_report+0x98/0xbd > > [<602f0cc2>] __asan_report_load4_noabort+0x1b/0x1d > > [<719f6e99>] ieee80211_vif_use_reserved_context+0x32d/0x40f [mac80211] > > This is the user, it just got freed during a function call a few lines > up. > > > Allocated by task 16: > > save_stack_trace+0x2e/0x30 > > stack_trace_save+0x81/0x9b > > kasan_save_stack+0x2d/0x54 > > kasan_set_track+0x34/0x3e > > ____kasan_kmalloc+0x8d/0x99 > > __kasan_kmalloc+0x10/0x12 > > __kmalloc+0x1f6/0x20b > > ieee80211_alloc_chanctx+0xdc/0x35f [mac80211] > > This makes sense too. > > > Freed by task 8: > > save_stack_trace+0x2e/0x30 > > stack_trace_save+0x81/0x9b > > kasan_save_stack+0x2d/0x54 > > kasan_set_track+0x34/0x3e > > kasan_set_free_info+0x33/0x44 > > ____kasan_slab_free+0x12b/0x149 > > __kasan_slab_free+0x19/0x1b > > slab_free_freelist_hook+0x10b/0x16a > > kfree+0x10d/0x1fa > > kvfree+0x38/0x3a > > rcu_process_callbacks+0x2c5/0x349 > > This is the RCU callback. > > > Last potentially related work creation: > > save_stack_trace+0x2e/0x30 > > stack_trace_save+0x81/0x9b > > kasan_save_stack+0x2d/0x54 > > __kasan_record_aux_stack+0xd5/0xe2 > > kasan_record_aux_stack_noalloc+0x12/0x14 > > insert_work+0x50/0xd7 > > __queue_work+0x805/0x95c > > queue_work_on+0xba/0x131 > > call_usermodehelper_exec+0x242/0x361 > > kobject_uevent_env+0xe46/0xeaf > > kobject_uevent+0x12/0x14 > > driver_register+0x37e/0x38d > > pcie_port_service_register+0x19d/0x1a5 > > This stuff is completely unrelated. > > > The buggy address belongs to the object at 0000000065c73300 > > which belongs to the cache kmalloc-192 of size 192 > > The buggy address is located 64 bytes inside of > > 192-byte region [0000000065c73300, 0000000065c733c0) > > > > and that's it? > > johannes > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/6fa1ebe49b8d574fb1c82aefeeb54439d9c98750.camel%40sipsolutions.net.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Vyukov <dvyukov@google.com> To: Johannes Berg <johannes@sipsolutions.net> Cc: David Gow <davidgow@google.com>, Vincent Whitchurch <vincent.whitchurch@axis.com>, Patricia Alfonso <trishalfonso@google.com>, Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>, anton.ivanov@cambridgegreys.com, Brendan Higgins <brendanhiggins@google.com>, kasan-dev <kasan-dev@googlegroups.com>, linux-um@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>, Daniel Latypov <dlatypov@google.com> Subject: Re: [RFC PATCH v3] UML: add support for KASAN under x86_64 Date: Fri, 27 May 2022 15:18:34 +0200 [thread overview] Message-ID: <CACT4Y+bhBMDn80u=W8VBbn4uZg1oD8zsE3RJJC-YJRS2i8Q2oA@mail.gmail.com> (raw) In-Reply-To: <6fa1ebe49b8d574fb1c82aefeeb54439d9c98750.camel@sipsolutions.net> On Fri, 27 May 2022 at 15:15, Johannes Berg <johannes@sipsolutions.net> wrote: > > On Fri, 2022-05-27 at 15:09 +0200, Dmitry Vyukov wrote: > > > I did note (this is more for kasan-dev@) that the "freed by" is fairly > > > much useless when using kfree_rcu(), it might be worthwhile to annotate > > > that somehow, so the stack trace is recorded by kfree_rcu() already, > > > rather than just showing the RCU callback used for that. > > > > KASAN is doing it for several years now, see e.g.: > > https://groups.google.com/g/syzkaller-bugs/c/eTW9zom4O2o/m/_v7cOo2RFwAJ > > > > Hm. It didn't for me: Please post a full report with line numbers and kernel version. > > BUG: KASAN: use-after-free in ieee80211_vif_use_reserved_context+0x32d/0x40f [mac80211] > > Read of size 4 at addr 0000000065c73340 by task kworker/u2:1/17 > > Yes. > > > CPU: 0 PID: 17 Comm: kworker/u2:1 Tainted: G O 5.18.0-rc1 #5 > > Workqueue: phy0 ieee80211_chswitch_work [mac80211] > > Stack: > > 60ba783f 00000000 10000c268f4e 60ba783f > > 60e60847 70dc9928 719f6e99 00000000 > > 71883b20 60bb0b42 60bb0b19 65c73340 > > Call Trace: > > [<600447ea>] show_stack+0x13e/0x14d > > [<60bb0b42>] dump_stack_lvl+0x29/0x2e > > [<602ef7c0>] print_report+0x15d/0x60b > > [<602efdc0>] kasan_report+0x98/0xbd > > [<602f0cc2>] __asan_report_load4_noabort+0x1b/0x1d > > [<719f6e99>] ieee80211_vif_use_reserved_context+0x32d/0x40f [mac80211] > > This is the user, it just got freed during a function call a few lines > up. > > > Allocated by task 16: > > save_stack_trace+0x2e/0x30 > > stack_trace_save+0x81/0x9b > > kasan_save_stack+0x2d/0x54 > > kasan_set_track+0x34/0x3e > > ____kasan_kmalloc+0x8d/0x99 > > __kasan_kmalloc+0x10/0x12 > > __kmalloc+0x1f6/0x20b > > ieee80211_alloc_chanctx+0xdc/0x35f [mac80211] > > This makes sense too. > > > Freed by task 8: > > save_stack_trace+0x2e/0x30 > > stack_trace_save+0x81/0x9b > > kasan_save_stack+0x2d/0x54 > > kasan_set_track+0x34/0x3e > > kasan_set_free_info+0x33/0x44 > > ____kasan_slab_free+0x12b/0x149 > > __kasan_slab_free+0x19/0x1b > > slab_free_freelist_hook+0x10b/0x16a > > kfree+0x10d/0x1fa > > kvfree+0x38/0x3a > > rcu_process_callbacks+0x2c5/0x349 > > This is the RCU callback. > > > Last potentially related work creation: > > save_stack_trace+0x2e/0x30 > > stack_trace_save+0x81/0x9b > > kasan_save_stack+0x2d/0x54 > > __kasan_record_aux_stack+0xd5/0xe2 > > kasan_record_aux_stack_noalloc+0x12/0x14 > > insert_work+0x50/0xd7 > > __queue_work+0x805/0x95c > > queue_work_on+0xba/0x131 > > call_usermodehelper_exec+0x242/0x361 > > kobject_uevent_env+0xe46/0xeaf > > kobject_uevent+0x12/0x14 > > driver_register+0x37e/0x38d > > pcie_port_service_register+0x19d/0x1a5 > > This stuff is completely unrelated. > > > The buggy address belongs to the object at 0000000065c73300 > > which belongs to the cache kmalloc-192 of size 192 > > The buggy address is located 64 bytes inside of > > 192-byte region [0000000065c73300, 0000000065c733c0) > > > > and that's it? > > johannes > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/6fa1ebe49b8d574fb1c82aefeeb54439d9c98750.camel%40sipsolutions.net. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2022-05-27 13:18 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-26 0:46 [PATCH] UML: add support for KASAN under x86_64 Patricia Alfonso 2020-02-26 0:46 ` Patricia Alfonso 2020-02-26 1:19 ` Brendan Higgins 2020-02-26 1:19 ` Brendan Higgins 2020-02-26 15:24 ` Dmitry Vyukov 2020-02-26 15:24 ` Dmitry Vyukov 2020-03-06 0:03 ` Patricia Alfonso 2020-03-06 0:03 ` Patricia Alfonso 2020-03-11 10:32 ` Johannes Berg 2020-03-11 10:32 ` Johannes Berg 2020-03-11 10:46 ` Dmitry Vyukov 2020-03-11 10:46 ` Dmitry Vyukov 2020-03-11 11:18 ` Johannes Berg 2020-03-11 11:18 ` Johannes Berg 2020-03-11 11:40 ` Johannes Berg 2020-03-11 11:40 ` Johannes Berg 2020-03-11 17:34 ` Dmitry Vyukov 2020-03-11 17:34 ` Dmitry Vyukov 2020-03-20 13:39 ` Johannes Berg 2020-03-20 13:39 ` Johannes Berg 2020-03-20 15:18 ` Dmitry Vyukov 2020-03-20 15:18 ` Dmitry Vyukov 2020-03-30 7:43 ` Johannes Berg 2020-03-30 7:43 ` Johannes Berg 2020-03-30 8:38 ` Dmitry Vyukov 2020-03-30 8:38 ` Dmitry Vyukov 2020-03-30 8:41 ` Johannes Berg 2020-03-30 8:41 ` Johannes Berg 2020-03-31 6:14 ` David Gow 2020-03-31 6:14 ` David Gow 2020-03-31 7:43 ` Johannes Berg 2020-03-31 7:43 ` Johannes Berg 2020-03-31 16:39 ` Patricia Alfonso 2020-03-31 16:39 ` Patricia Alfonso 2020-03-31 16:54 ` Richard Weinberger 2020-03-11 22:32 ` Patricia Alfonso 2020-03-11 22:32 ` Patricia Alfonso 2020-03-11 22:44 ` Johannes Berg 2020-03-11 22:44 ` Johannes Berg 2022-05-24 10:34 ` Vincent Whitchurch 2022-05-24 10:34 ` Vincent Whitchurch 2022-05-24 10:45 ` Johannes Berg 2022-05-24 10:45 ` Johannes Berg 2022-05-24 19:35 ` David Gow 2022-05-24 19:35 ` David Gow 2022-05-25 11:17 ` Vincent Whitchurch 2022-05-25 11:17 ` Vincent Whitchurch 2022-05-26 1:01 ` [RFC PATCH v3] " David Gow 2022-05-26 1:01 ` David Gow 2022-05-26 9:29 ` Johannes Berg 2022-05-26 9:29 ` Johannes Berg 2022-05-27 5:31 ` Dmitry Vyukov 2022-05-27 5:31 ` Dmitry Vyukov 2022-05-27 7:32 ` Johannes Berg 2022-05-27 7:32 ` Johannes Berg 2022-05-27 10:36 ` Johannes Berg 2022-05-27 10:36 ` Johannes Berg 2022-05-27 13:05 ` Johannes Berg 2022-05-27 13:05 ` Johannes Berg 2022-05-27 13:09 ` Dmitry Vyukov 2022-05-27 13:09 ` Dmitry Vyukov 2022-05-27 13:15 ` Johannes Berg 2022-05-27 13:15 ` Johannes Berg 2022-05-27 13:18 ` Dmitry Vyukov [this message] 2022-05-27 13:18 ` Dmitry Vyukov 2022-05-27 13:27 ` Johannes Berg 2022-05-27 13:27 ` Johannes Berg 2022-05-27 13:52 ` Dmitry Vyukov 2022-05-27 13:52 ` Dmitry Vyukov 2022-05-27 14:27 ` Johannes Berg 2022-05-27 14:27 ` Johannes Berg 2022-05-27 15:46 ` Dmitry Vyukov 2022-05-27 15:46 ` Dmitry Vyukov 2020-03-29 19:06 ` [PATCH] " Richard Weinberger 2020-03-29 19:06 ` Richard Weinberger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACT4Y+bhBMDn80u=W8VBbn4uZg1oD8zsE3RJJC-YJRS2i8Q2oA@mail.gmail.com' \ --to=dvyukov@google.com \ --cc=anton.ivanov@cambridgegreys.com \ --cc=brendanhiggins@google.com \ --cc=davidgow@google.com \ --cc=dlatypov@google.com \ --cc=jdike@addtoit.com \ --cc=johannes@sipsolutions.net \ --cc=kasan-dev@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-um@lists.infradead.org \ --cc=richard@nod.at \ --cc=trishalfonso@google.com \ --cc=vincent.whitchurch@axis.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.