All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Vyukov <dvyukov@google.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: syzbot <syzbot+5027de09e0964fd78ce1@syzkaller.appspotmail.com>,
	andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
	daniel@iogearbox.net, "David S. Miller" <davem@davemloft.net>,
	fgheet255t@gmail.com, hawk@kernel.org, jakub@cloudflare.com,
	john.fastabend@gmail.com, kafai@fb.com, kpsingh@kernel.org,
	kuba@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	lmb@cloudflare.com, Linux Netdev List <netdev@vger.kernel.org>,
	songliubraving@fb.com, syzkaller-bugs@googlegroups.com,
	yhs@fb.com
Subject: Re: [syzbot] KASAN: vmalloc-out-of-bounds Read in __bpf_prog_put
Date: Thu, 19 May 2022 17:01:35 +0200	[thread overview]
Message-ID: <CACT4Y+biE2wCBcD6Z4vdVfKRpJMsRWYGjCjiiC+Ho2D91Qv-Qg@mail.gmail.com> (raw)
In-Reply-To: <CAOMGZ=E9Gmv6Fb_pi4p9RhQ_MvJVYs_6rkf37XfG0DYEMFNbNA@mail.gmail.com>

On Mon, 24 Jan 2022 at 12:42, Vegard Nossum <vegard.nossum@gmail.com> wrote:
>
> On Thu, 20 Jan 2022 at 15:17, syzbot
> <syzbot+5027de09e0964fd78ce1@syzkaller.appspotmail.com> wrote:
> >
> > syzbot suspects this issue was fixed by commit:
> >
> > commit 218d747a4142f281a256687bb513a135c905867b
> > Author: John Fastabend <john.fastabend@gmail.com>
> > Date:   Tue Jan 4 21:46:45 2022 +0000
> >
> >     bpf, sockmap: Fix double bpf_prog_put on error case in map_link
>
> I can confirm the above commit fixes the issue, but it references a
> slightly different report. Looks like the only difference is
> __bpf_prog_put instead of bpf_prog_put:
>
> KASAN: vmalloc-out-of-bounds Read in __bpf_prog_put
> KASAN: vmalloc-out-of-bounds Read in bpf_prog_put
>
> However, looking at the stack traces for the two bugs shows that
> __bpf_prog_put() is really the location for both reports, see:
>
> https://syzkaller.appspot.com/bug?id=797cd651dd0d9bd921e4fa51b792f5afdc3f390f
>  kasan_report.cold+0x83/0xdf mm/kasan/report.c:450 mm/kasan/report.c:450
>  __bpf_prog_put.constprop.0+0x1dd/0x220 kernel/bpf/syscall.c:1812
> kernel/bpf/syscall.c:1812
>  bpf_prog_put kernel/bpf/syscall.c:1829 [inline]
>  bpf_prog_put kernel/bpf/syscall.c:1829 [inline] kernel/bpf/syscall.c:1837
>
> vs.
>
> https://syzkaller.appspot.com/bug?extid=bb73e71cf4b8fd376a4f
>  kasan_report+0x19a/0x1f0 mm/kasan/report.c:450 mm/kasan/report.c:450
>  __bpf_prog_put kernel/bpf/syscall.c:1812 [inline]
>  __bpf_prog_put kernel/bpf/syscall.c:1812 [inline] kernel/bpf/syscall.c:1829
>  bpf_prog_put+0x8c/0x4f0 kernel/bpf/syscall.c:1829 kernel/bpf/syscall.c:1829
>
> Looks to me like the compiler's inlining decision caused syzbot to see
> __bpf_prog_put() instead of bpf_prog_put(), but I can't tell if it's
> because it got inlined or because of the .constprop.0 suffix... I
> guess syzbot skips the [inline] entries when deciding which function
> to report the bug in?

Not sure if you are still interested in this or not...
But, yes, it's inline frames that are a problem, ".constprop.0" should
be stripped.
syzkaller parses non-symbolized kernel output w/o inlined frames to
extract the title. This was a very early decision, not sure if it's
the right one or not. On the other hand using inline frames can cause
attribution to all the common one-liners.
Now it's somewhat hard to change b/c if we change it, new crashes will
be parsed differently and it will cause a storm of duplicates for
already reported bugs.


> In any case:
>
> #syz dup: KASAN: vmalloc-out-of-bounds Read in bpf_prog_put
>
> Vegard

      reply	other threads:[~2022-05-19 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-04 16:35 [syzbot] KASAN: vmalloc-out-of-bounds Read in __bpf_prog_put syzbot
2021-12-06 19:02 ` John Fastabend
2021-12-07 17:36 ` syzbot
2022-01-20 14:17 ` syzbot
2022-01-24 11:42   ` Vegard Nossum
2022-05-19 15:01     ` Dmitry Vyukov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACT4Y+biE2wCBcD6Z4vdVfKRpJMsRWYGjCjiiC+Ho2D91Qv-Qg@mail.gmail.com \
    --to=dvyukov@google.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=fgheet255t@gmail.com \
    --cc=hawk@kernel.org \
    --cc=jakub@cloudflare.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lmb@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=syzbot+5027de09e0964fd78ce1@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=vegard.nossum@gmail.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.