All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Vyukov <dvyukov@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	syzkaller <syzkaller@googlegroups.com>,
	Eric Dumazet <edumazet@google.com>,
	Eric Biggers <ebiggers3@gmail.com>,
	Kostya Serebryany <kcc@google.com>,
	Alexander Potapenko <glider@google.com>,
	andreyknvl <andreyknvl@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	David Miller <davem@davemloft.net>,
	Willem de Bruijn <willemb@google.com>,
	Guenter Roeck <groeck@google.com>,
	Stephan Mueller <smueller@chronox.de>
Subject: Re: [RFC] syzbot process
Date: Thu, 28 Dec 2017 11:14:08 +0100	[thread overview]
Message-ID: <CACT4Y+bvcHFwURDaz8Zt1nnEcG9NH00QYGvD8JqHNBzjbiXRJw@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFxC1VEMZkg6v4WpAVMq6yaKWzs_5dSpZzTnQFSgbjzsxQ@mail.gmail.com>

On Thu, Dec 21, 2017 at 7:08 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Thu, Dec 21, 2017 at 5:22 AM, Andrey Ryabinin <ryabinin.a.a@gmail.com> wrote:
>>
>>      instead of
>>      From: syzbot <syzkaller@googlegroups.com>
>>
>>      make it
>>      From: syzbot-{hash} <syzkaller@googlegroups.com>
>
> That is probably good, but people drop the name all the time.
>
> But with a very simple tweak, I think this would be close to perfect:
> put the hash in the original email instead, and use "+" instead of
> "-", because that's the standard email ("latter part doesn't matter").
> Skip the proper name part entirely, since it doesn't really add
> anything.
>
> And then make it show up in the "Cc:" part or "Reported-by:", so it
> would just look something like
>
>     Reported-by: syzkaller+1234abc@googlegroups.com
>
> and you're all done. I think that would be easiest for us to track
> (just one email that we're supposed to put in the commit message
> _anyway_), and I hope/think that all email clients and servers will
> still maintain the original full "syzkaller+xyz" part of the email, so
> it doesn't get lost.
>
> Because the "proper name" part definitely does get lost occasionally.
> I'm not sure why it happens, but it definitely happens quite often.


Hi Linus,

This sound like a plan. I like that we piggy-back on the existing
process so _theoretically_ don't increase burden on developers. Also
may probably help improving general practice of properly crediting
people (which is now at around 50% from our experience). So new emails
now include (and that's also actual email sender):

====================
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+4396883fa8c4f64e0175@syzkaller.appspotmail.com
It will help syzbot understand when the bug is fixed. See footer for details.
If you forward the report, please keep this part and the footer.
====================

Thanks

  reply	other threads:[~2017-12-28 10:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 12:52 [RFC] syzbot process Dmitry Vyukov
2017-12-21 13:22 ` Andrey Ryabinin
2017-12-21 13:36   ` Stephan Mueller
2017-12-28 10:19     ` Dmitry Vyukov
2017-12-21 18:08   ` Linus Torvalds
2017-12-28 10:14     ` Dmitry Vyukov [this message]
2017-12-28 10:15   ` Dmitry Vyukov
2017-12-21 17:05 ` Greg Kroah-Hartman
2017-12-28 10:23   ` Dmitry Vyukov
2017-12-22  3:32 ` Eric Biggers
2017-12-28 10:41   ` Dmitry Vyukov
2017-12-28 10:51     ` Ozgur
2017-12-28 11:45       ` Dmitry Vyukov
2017-12-28 12:26         ` Ozgur
2017-12-28 12:30           ` Dmitry Vyukov
2017-12-28 12:55             ` Ozgur
2018-01-08 12:51               ` Dmitry Vyukov
2017-12-28 12:27         ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACT4Y+bvcHFwURDaz8Zt1nnEcG9NH00QYGvD8JqHNBzjbiXRJw@mail.gmail.com \
    --to=dvyukov@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=davem@davemloft.net \
    --cc=ebiggers3@gmail.com \
    --cc=edumazet@google.com \
    --cc=glider@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@google.com \
    --cc=kcc@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=ryabinin.a.a@gmail.com \
    --cc=smueller@chronox.de \
    --cc=syzkaller@googlegroups.com \
    --cc=torvalds@linux-foundation.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.