From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Schwierzeck Date: Fri, 8 Jul 2011 13:34:13 +0200 Subject: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile In-Reply-To: <20110708090838.E92A9126F38F@gemini.denx.de> References: <1309352967-5719-1-git-send-email-aneesh@ti.com> <1309883182-12854-1-git-send-email-daniel.schwierzeck@googlemail.com> <1309883182-12854-2-git-send-email-daniel.schwierzeck@googlemail.com> <20110708090838.E92A9126F38F@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, On Fri, Jul 8, 2011 at 11:08 AM, Wolfgang Denk wrote: > Dear Daniel Schwierzeck, > > In message <1309883182-12854-2-git-send-email-daniel.schwierzeck@googlemail.com> you wrote: >> [aneesh at ti.com: >> 1. Changed the definition of OBJTREE and the way 'obj' is defined. >> 2. Defined a flag to identify regular U-Boot build >> 3. Taking care of autoconf.mk etc for SPL due to changed OBJTREE >> ] >> >> [daniel.schwierzeck at googlemail.com: >> 1. reverted changes on implicite make rules >> 2. readded definition of -DCONFIG_UBOOT_SPL_BUILD in CPPFLAGS >> ] > ... >> +# Allow compiling of C and ASM code parts in different way. >> +# Serves also as a replacement for CONFIG_PRELOADER. >> +ifneq ($(CONFIG_UBOOT_SPL_BUILD),) >> +CPPFLAGS += -DCONFIG_UBOOT_SPL_BUILD >> +endif > > I don't understand this comment. Currently we have CONFIG_PRELOADER (and maybe others?) to conditionally compile start.S and other code. The idea here is to consolidate those defines and to use a common name convention for SPL. My suggestion is something like CONFIG_UBOOT_SPL_BUILD. Are there better ideas? Best regards, Daniel