From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Schwierzeck Date: Mon, 18 Jul 2011 18:22:39 +0200 Subject: [U-Boot] [RFC PATCH v2 2/9] spl: add initial support for a generic SPL framework In-Reply-To: <20110718160633.530B617E88C6@gemini.denx.de> References: <1310569869-31810-3-git-send-email-daniel.schwierzeck@googlemail.com> <1310746944-32711-1-git-send-email-daniel.schwierzeck@googlemail.com> <20110718160633.530B617E88C6@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, sorry, I sent the new series too early and missed your answer. I'll address your comments. On Mon, Jul 18, 2011 at 6:06 PM, Wolfgang Denk wrote: > Dear Daniel Schwierzeck, > > In message <1310746944-32711-1-git-send-email-daniel.schwierzeck@googlemail.com> you wrote: >> Signed-off-by: Aneesh V >> Signed-off-by: Daniel Schwierzeck > > Thanks. > >> +Overview >> +-------- >> + >> +To unify all existing implementations for a secondary program loader (SPL) >> +and to allow simply adding of new implementations this generic SPL framework >> +have been created. With this framework almost all source files for a board > > s/have/has/ > >> +How it works >> +------------ >> + >> +There is a new directory TOPDIR/spl which contains only a Makefile. >> +All source files needed by SPL are recompiled inside this directory >> +and linked to the final binaries named u-boot-spl[.bin|.map]. > > The "recompiled inside this directory" might be misinterpreted. ?How > about: "are compiled such that the resulting object files are placed > into this directory" or similar? > >> +Thus makefiles and source files are able to build things differently for SPL. > > Strictly speaking, the source files don't build anything themself.How > about: "This way we can compile the source files with different > settings for SPL." ? > >> +Because SPL images normally have a different test base, one have to be > > s/test/text/ > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de > Marriage is the sole cause of divorce. >