From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754408AbaFIHxd (ORCPT ); Mon, 9 Jun 2014 03:53:33 -0400 Received: from mail-ve0-f172.google.com ([209.85.128.172]:36166 "EHLO mail-ve0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475AbaFIHxb convert rfc822-to-8bit (ORCPT ); Mon, 9 Jun 2014 03:53:31 -0400 MIME-Version: 1.0 In-Reply-To: References: <1402057225-7312-1-git-send-email-m@bjorling.me> <1402057225-7312-2-git-send-email-m@bjorling.me> Date: Mon, 9 Jun 2014 15:53:29 +0800 Message-ID: Subject: Re: [PATCH v6] NVMe: conversion to blk-mq From: Ming Lei To: =?UTF-8?Q?Matias_Bj=C3=B8rling?= Cc: Matthew Wilcox , Keith Busch , "Sam Bradshaw (sbradshaw)" , Jens Axboe , Linux Kernel Mailing List , linux-nvme Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 9, 2014 at 3:50 PM, Ming Lei wrote: > On Mon, Jun 9, 2014 at 2:00 PM, Matias Bjørling wrote: >> On Mon, Jun 9, 2014 at 6:35 AM, Ming Lei wrote: >>> On Fri, Jun 6, 2014 at 8:20 PM, Matias Bjørling wrote: >>>> This converts the current NVMe driver to utilize the blk-mq layer. >>> >>> Looks it can't be applied cleanly against 3.15-rc8 + Jens's for-linux >>> branch, when I fix the conflict manually, below failure is triggered: >>> >>> [ 487.696057] nvme 0000:00:07.0: Cancelling I/O 202 QID 1 >>> [ 487.699005] nvme 0000:00:07.0: Aborting I/O 202 QID 1 >>> [ 487.704074] nvme 0000:00:07.0: Cancelling I/O 202 QID 1 >>> [ 487.717881] nvme 0000:00:07.0: Aborting I/O 202 QID 1 >>> [ 487.736093] end_request: I/O error, dev nvme0n1, sector 91532352 >>> [ 487.747378] nvme 0000:00:07.0: completed id 0 twice on queue 0 >>> >>> >>> when running fio randread(libaio, iodepth:64) with more than 3 jobs. >>> >>> And looks no such failure when jobs is 1 or 2. >> >> Can you try with the nvmemq_review branch at >> >> https://github.com/MatiasBjorling/linux-collab.git > > Looks git-pull from the branch does work, so you > might have out-of-tree patches. After pulling from your tree, the problem still persists. I test nvme over qemu, and both linus/next tree can work well with qemu nvme. Thanks, -- Ming Lei From mboxrd@z Thu Jan 1 00:00:00 1970 From: tom.leiming@gmail.com (Ming Lei) Date: Mon, 9 Jun 2014 15:53:29 +0800 Subject: [PATCH v6] NVMe: conversion to blk-mq In-Reply-To: References: <1402057225-7312-1-git-send-email-m@bjorling.me> <1402057225-7312-2-git-send-email-m@bjorling.me> Message-ID: On Mon, Jun 9, 2014@3:50 PM, Ming Lei wrote: > On Mon, Jun 9, 2014@2:00 PM, Matias Bj?rling wrote: >> On Mon, Jun 9, 2014@6:35 AM, Ming Lei wrote: >>> On Fri, Jun 6, 2014@8:20 PM, Matias Bj?rling wrote: >>>> This converts the current NVMe driver to utilize the blk-mq layer. >>> >>> Looks it can't be applied cleanly against 3.15-rc8 + Jens's for-linux >>> branch, when I fix the conflict manually, below failure is triggered: >>> >>> [ 487.696057] nvme 0000:00:07.0: Cancelling I/O 202 QID 1 >>> [ 487.699005] nvme 0000:00:07.0: Aborting I/O 202 QID 1 >>> [ 487.704074] nvme 0000:00:07.0: Cancelling I/O 202 QID 1 >>> [ 487.717881] nvme 0000:00:07.0: Aborting I/O 202 QID 1 >>> [ 487.736093] end_request: I/O error, dev nvme0n1, sector 91532352 >>> [ 487.747378] nvme 0000:00:07.0: completed id 0 twice on queue 0 >>> >>> >>> when running fio randread(libaio, iodepth:64) with more than 3 jobs. >>> >>> And looks no such failure when jobs is 1 or 2. >> >> Can you try with the nvmemq_review branch at >> >> https://github.com/MatiasBjorling/linux-collab.git > > Looks git-pull from the branch does work, so you > might have out-of-tree patches. After pulling from your tree, the problem still persists. I test nvme over qemu, and both linus/next tree can work well with qemu nvme. Thanks, -- Ming Lei