From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753936AbbCLHsl (ORCPT ); Thu, 12 Mar 2015 03:48:41 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:43357 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753371AbbCLHsd (ORCPT ); Thu, 12 Mar 2015 03:48:33 -0400 MIME-Version: 1.0 In-Reply-To: <1426132602-34331-2-git-send-email-snitzer@redhat.com> References: <1426132602-34331-1-git-send-email-snitzer@redhat.com> <1426132602-34331-2-git-send-email-snitzer@redhat.com> Date: Thu, 12 Mar 2015 15:48:32 +0800 Message-ID: Subject: Re: [PATCH 1/7] blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path From: Ming Lei To: Mike Snitzer Cc: Jens Axboe , Keith Busch , Linux Kernel Mailing List , Linux SCSI List , dm-devel@redhat.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer wrote: > If percpu_ref_init() fails the 'err_hctxs' label should be used instead > of 'err_map'. > > Signed-off-by: Mike Snitzer > --- > block/blk-mq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 4f4bea2..459840c 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -1938,7 +1938,7 @@ struct request_queue *blk_mq_init_queue(struct blk_mq_tag_set *set) > */ > if (percpu_ref_init(&q->mq_usage_counter, blk_mq_usage_counter_release, > PERCPU_REF_INIT_ATOMIC, GFP_KERNEL)) > - goto err_map; > + goto err_hctxs; If it is changed to 'goto err_hctxs', percpu_ref_init() need to move before blk_alloc_queue_node(), otherwise just 'goto err_hw' is enough, but the former is better. Thanks,