From: Ming Lei <tom.leiming@gmail.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"yizhan@redhat.com" <yizhan@redhat.com>,
"axboe@fb.com" <axboe@fb.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler
Date: Fri, 17 Mar 2017 08:07:42 +0800 [thread overview]
Message-ID: <CACVXFVNHA4Dh-rx8VsVnwaY4iZJY2tucKF7V-WcNNa4=F5twfA@mail.gmail.com> (raw)
In-Reply-To: <1489700141.2574.16.camel@sandisk.com>
On Fri, Mar 17, 2017 at 5:35 AM, Bart Van Assche
<Bart.VanAssche@sandisk.com> wrote:
> On Thu, 2017-03-16 at 08:07 +0800, Ming Lei wrote:
>> > * Check whether REQ_ATOM_STARTED has been set.
>> > * Check whether REQ_ATOM_COMPLETE has not yet been set.
>> > * If both conditions have been met, set REQ_ATOM_COMPLETE.
>> >
>> > I don't think there is another solution than using a single state variable to
>> > represent the REQ_ATOM_STARTED and REQ_ATOM_COMPLETE states instead of two
>> > independent bits. How about the patch below?
>>
>> I would review it if you can confirm me that it is a real issue, :-)
>
> Hello Ming,
>
> I was chasing a v4.11 regression in the SCSI stack. Since my tests of today
> revealed that it's probably not a block layer issue, let's proceed with your
> patch.
Yeah, it shouldn't have been related with blk-mq timeout handler which
isn't changed much
recently, and thanks for your review!
Thanks,
Ming Lei
next prev parent reply other threads:[~2017-03-17 0:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 13:02 [PATCH 0/2] blk-mq: dying queue fix & improvement Ming Lei
2017-03-09 13:02 ` Ming Lei
2017-03-09 13:02 ` [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei
2017-03-15 0:07 ` Bart Van Assche
2017-03-15 0:07 ` Bart Van Assche
2017-03-15 12:18 ` Ming Lei
2017-03-15 12:40 ` Ming Lei
2017-03-15 15:36 ` Bart Van Assche
2017-03-15 15:36 ` Bart Van Assche
2017-03-15 16:22 ` Ming Lei
2017-03-15 16:22 ` Ming Lei
2017-03-15 16:46 ` Ming Lei
2017-03-15 21:35 ` Bart Van Assche
2017-03-15 21:35 ` Bart Van Assche
2017-03-16 0:07 ` Ming Lei
2017-03-16 0:07 ` Ming Lei
2017-03-16 21:35 ` Bart Van Assche
2017-03-16 21:35 ` Bart Van Assche
2017-03-17 0:07 ` Ming Lei [this message]
2017-03-15 21:34 ` Bart Van Assche
2017-03-15 21:34 ` Bart Van Assche
2017-03-15 23:41 ` Ming Lei
2017-03-15 14:11 ` Yi Zhang
2017-03-16 21:37 ` Bart Van Assche
2017-03-16 21:37 ` Bart Van Assche
2017-03-09 13:02 ` [PATCH 2/2] blk-mq: start to freeze queue just after setting dying Ming Lei
2017-03-09 16:58 ` Bart Van Assche
2017-03-09 16:58 ` Bart Van Assche
2017-03-10 2:16 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACVXFVNHA4Dh-rx8VsVnwaY4iZJY2tucKF7V-WcNNa4=F5twfA@mail.gmail.com' \
--to=tom.leiming@gmail.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yizhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.