From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbaFJOrR (ORCPT ); Tue, 10 Jun 2014 10:47:17 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:58672 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbaFJOrO (ORCPT ); Tue, 10 Jun 2014 10:47:14 -0400 MIME-Version: 1.0 In-Reply-To: <20140610124508.GA5671@lst.de> References: <1402375925-21720-1-git-send-email-tom.leiming@gmail.com> <20140610112827.GA359@lst.de> <20140610124508.GA5671@lst.de> Date: Tue, 10 Jun 2014 22:47:13 +0800 Message-ID: Subject: Re: [PATCH] blk-mq: kick requeue list in blk_mq_requeue_request() From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Linux Kernel Mailing List , =?UTF-8?Q?Matias_Bj=C3=B8rling?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 10, 2014 at 8:45 PM, Christoph Hellwig wrote: > On Tue, Jun 10, 2014 at 07:45:47PM +0800, Ming Lei wrote: >> OK, but the API name is a bit confusing, and that is easy to cause >> misuse, like in nvme. >> >> Also requeue one request in completion handler may be a >> common case, so maybe it is better to let blk_mq_requeue_request() >> handle both adding to request list and kicking off, and introduce >> blk_mq_prep_requeue_req()(or better name) to batch operations. > > For now please just add some documentation. I'm happy to revisit > these once we have a few user in tree, but for now I'd like to keep > blk-mq a little more stable to not impact the merges of the major > users. There are two users: one is nvme, another is scsi-mq, and both don't need batch operations now. Thanks, -- Ming Lei