From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755777AbcC2BdU (ORCPT ); Mon, 28 Mar 2016 21:33:20 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:55657 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbcC2BdP (ORCPT ); Mon, 28 Mar 2016 21:33:15 -0400 MIME-Version: 1.0 In-Reply-To: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> References: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> Date: Tue, 29 Mar 2016 09:33:13 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/8] block: prepare for multipage bvecs From: Ming Lei To: Jens Axboe , Linux Kernel Mailing List Cc: linux-block@vger.kernel.org, Christoph Hellwig , Al Viro , Anton Altaparmakov , xfs@oss.sgi.com, Dave Chinner , drbd-dev@lists.linbit.com, Philipp Reisner , Lars Ellenberg , Boaz Harrosh Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2016 at 2:12 PM, Ming Lei wrote: > Hi, > > Interests[1] have been shown in multipage bvecs, so this patchset > try to prepare for the support and do two things: > > 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), > then we can drop the non-standard way for iterating bvec > > 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only > one user for each. Once multipage bvecs is introduced, one bio > may hold lots of sectors, and we should always use sort of BIO_MAX_VECS > which should be introduced in future and is similiar with current > BIO_MAX_PAGES. > > xfstests(-a auto) have been run and no regression found by this > patchset against linus v4.5+. Hi Jens, Looks no one objects this patchset, and the change of iov_iter.c is a good cleanup too, so what do you think of the patchset? Thanks, Ming > > drivers/block/drbd/drbd_int.h | 4 +-- > fs/xfs/xfs_buf.c | 2 +- > include/linux/bio.h | 55 +------------------------------ > include/linux/blk_types.h | 4 +-- > include/linux/bvec_iter.h | 77 +++++++++++++++++++++++++++++++++++++++++++ > lib/iov_iter.c | 31 +++++++---------- > 6 files changed, 94 insertions(+), 79 deletions(-) > > > [1], http://marc.info/?w=2&r=1&s=++[LSF%2FMM+ATTEND]+block%3A+multipage+bvecs&q=t > > > Thanks, > Ming > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 7DDDB7CA3 for ; Mon, 28 Mar 2016 20:33:18 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id F290CAC004 for ; Mon, 28 Mar 2016 18:33:17 -0700 (PDT) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by cuda.sgi.com with ESMTP id IsDbm5gIiQoFdFfq (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 28 Mar 2016 18:33:15 -0700 (PDT) Received: from mail-yw0-f172.google.com ([209.85.161.172]) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1akiWw-0002rk-3D for xfs@oss.sgi.com; Tue, 29 Mar 2016 01:33:14 +0000 Received: by mail-yw0-f172.google.com with SMTP id g127so1699018ywf.2 for ; Mon, 28 Mar 2016 18:33:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> References: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> Date: Tue, 29 Mar 2016 09:33:13 +0800 Message-ID: Subject: Re: [PATCH 0/8] block: prepare for multipage bvecs From: Ming Lei List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jens Axboe , Linux Kernel Mailing List Cc: Christoph Hellwig , Boaz Harrosh , Philipp Reisner , xfs@oss.sgi.com, linux-block@vger.kernel.org, Al Viro , Lars Ellenberg , Anton Altaparmakov , drbd-dev@lists.linbit.com On Tue, Mar 22, 2016 at 2:12 PM, Ming Lei wrote: > Hi, > > Interests[1] have been shown in multipage bvecs, so this patchset > try to prepare for the support and do two things: > > 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(), > then we can drop the non-standard way for iterating bvec > > 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only > one user for each. Once multipage bvecs is introduced, one bio > may hold lots of sectors, and we should always use sort of BIO_MAX_VECS > which should be introduced in future and is similiar with current > BIO_MAX_PAGES. > > xfstests(-a auto) have been run and no regression found by this > patchset against linus v4.5+. Hi Jens, Looks no one objects this patchset, and the change of iov_iter.c is a good cleanup too, so what do you think of the patchset? Thanks, Ming > > drivers/block/drbd/drbd_int.h | 4 +-- > fs/xfs/xfs_buf.c | 2 +- > include/linux/bio.h | 55 +------------------------------ > include/linux/blk_types.h | 4 +-- > include/linux/bvec_iter.h | 77 +++++++++++++++++++++++++++++++++++++++++++ > lib/iov_iter.c | 31 +++++++---------- > 6 files changed, 94 insertions(+), 79 deletions(-) > > > [1], http://marc.info/?w=2&r=1&s=++[LSF%2FMM+ATTEND]+block%3A+multipage+bvecs&q=t > > > Thanks, > Ming > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs