All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"axboe@fb.com" <axboe@fb.com>, "hare@suse.de" <hare@suse.de>
Subject: Re: [PATCH v2 3/4] block: rename blk_mq_freeze_queue_start()
Date: Sat, 25 Mar 2017 01:52:02 +0800	[thread overview]
Message-ID: <CACVXFVPAJsChTvDRvS8=PiciNVOXU1U=zOm9y=cgk8Ujo6Vr3g@mail.gmail.com> (raw)
In-Reply-To: <1490376549.3312.3.camel@sandisk.com>

On Sat, Mar 25, 2017 at 1:29 AM, Bart Van Assche
<Bart.VanAssche@sandisk.com> wrote:
> On Fri, 2017-03-24 at 20:36 +0800, Ming Lei wrote:
>> As the .q_usage_counter is used by both legacy and
>> mq path, we need to block new I/O if queue becomes
>> dead in blk_queue_enter().
>>
>> So rename it and we can use this function in both
>> pathes.
>
> Should "pathes" be changed into "paths" in the commit message? Additionally,
> this patch breaks the symmetry the comment in blk_mq_freeze_queue() refers
> to. Anyway:

Really? Is there one function named as blk_mq_freeze_queue_end()?

The comment means blk_mq_freeze_queue() vs. blk_mq_unfreeze_queue(), which can't
be affected by this patch.


Thanks,
Ming Lei

  reply	other threads:[~2017-03-24 17:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 12:36 [PATCH v2 0/4] block: misc changes Ming Lei
2017-03-24 12:36 ` [PATCH v2 1/4] blk-mq: comment on races related with timeout handler Ming Lei
2017-03-24 12:36 ` [PATCH v2 2/4] block: add a read barrier in blk_queue_enter() Ming Lei
2017-03-24 15:18   ` Hannes Reinecke
2017-03-24 17:24   ` Bart Van Assche
2017-03-24 17:38     ` Ming Lei
2017-03-24 18:45       ` Bart Van Assche
2017-03-27 11:31         ` Ming Lei
2017-03-24 12:36 ` [PATCH v2 3/4] block: rename blk_mq_freeze_queue_start() Ming Lei
2017-03-24 15:20   ` Hannes Reinecke
2017-03-24 17:29   ` Bart Van Assche
2017-03-24 17:52     ` Ming Lei [this message]
2017-03-24 12:36 ` [PATCH v2 4/4] block: block new I/O just after queue is set as dying Ming Lei
2017-03-24 17:45   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACVXFVPAJsChTvDRvS8=PiciNVOXU1U=zOm9y=cgk8Ujo6Vr3g@mail.gmail.com' \
    --to=tom.leiming@gmail.com \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=axboe@fb.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.