All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Adam Borowski <kilobyte@angband.pl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: hard-ban creating files with control characters in the name
Date: Thu, 5 Oct 2017 14:07:31 +0200	[thread overview]
Message-ID: <CACVxJT-7EQAwe1DaC_TFAN1gkk5k93nbZgpK7-sNSE24od5YRA@mail.gmail.com> (raw)

> Anything with bytes 1-31,127 will get -EACCES.

You're making a mistake of catering to Unix shells which are pure garbage
as programming languages instead of fixing them or switching to saner
alternatives and then "fixing" kernel to sort-of workaround Unix shells
deficiencies.

Formally, you patch will break every program which creates git-style files
with filenames only fixing up for \0 and '/'. Now such program should
account for low ASCII as well.

             reply	other threads:[~2017-10-05 12:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 12:07 Alexey Dobriyan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-10-03  0:50 [PATCH] vfs: hard-ban creating files with control characters in the name Adam Borowski
2017-10-03  2:07 ` Al Viro
2017-10-03  3:22   ` Adam Borowski
2017-10-05 10:07     ` Olivier Galibert
2017-10-06 14:54       ` Matthew Wilcox
2017-10-03 16:40   ` Theodore Ts'o
2017-10-03 17:32     ` Adam Borowski
2017-10-03 18:58       ` Theodore Ts'o
2017-10-03 19:12         ` Casey Schaufler
2017-10-05 16:16         ` J. Bruce Fields
2017-10-06  2:09           ` Dave Chinner
2017-10-06 14:38             ` J. Bruce Fields
2017-10-06 14:57             ` Matthew Wilcox
2017-10-06 20:00               ` Theodore Ts'o
2017-10-08 22:03               ` Dave Chinner
2017-10-05 13:47       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACVxJT-7EQAwe1DaC_TFAN1gkk5k93nbZgpK7-sNSE24od5YRA@mail.gmail.com \
    --to=adobriyan@gmail.com \
    --cc=kilobyte@angband.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.