Re: [Ksummit-discuss] [CORE TOPIC] Testing

[Alexey Dobriyan <adobriyan@gmail.com>]

On Fri, Jul 10, 2015 at 5:02 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 07/10/2015 04:39 AM, Alexey Dobriyan wrote:
>> On Thu, Jul 9, 2015 at 1:24 PM, Masami Hiramatsu
>> <masami.hiramatsu.pt@hitachi.com> wrote:
>>
>>> This may be an off-topic, but I'd like to ask the selftest for tools.
>>> Currently tools/testing/selftests tests the kernel itself, but
>>> there are many tools under tools/, like perf too.
>>>
>>> Those are not configured by the kconfig, but selftests are also needed
>>> for tools. I have a runtests script which is just a bit modified
>>> ftracetest for perf-probe. I'd like to integrate it to selftests
>>> but I'm not sure that is a scope of kselftests.
>>
>> This confusion is partially created by peculiar place where people
>> who wrote testsuite put it.
>>
>> Gentlemen,
>> testsuite should be first class citizen in toplevel test/ directory,
>> command to run it should be "make test" not "make kselftest".
>> Only placing it in very visible place and using names which are intuitive
>> and familiar from userspace (git's t/ directory, glibc "make test") will give
>> hope that other developers will notice it and start using and improving it.
>> Excuse me, but tools/testing/selftests is hopeless.
>
> selftests are intended for kernel developers primarily. If developers
> and users don't want to figure out what are the ways to test, then it
> doesn't matter what the option is named. I would like to hear some
> concrete data on why naming test would make it lot more usable.

Not usable, but visible. Top level implies "important", 3 directories deep
implies some obscure driver you didn't even hear about.

And it's easier to type.

git gets it right:

test: all
        $(MAKE) -C t/ all

    Alexey