All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Tanous <ed@tanous.net>
To: "Udupa.Ashwini ISV" <udupa.ashwini@inventec.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: Redfish v1/Systems/system/EthernetInterfaces
Date: Wed, 17 Feb 2021 12:24:11 -0800	[thread overview]
Message-ID: <CACWQX80r9dYEGbwftH32Sc6fRmDLHeYg24tdO+8hME9V_bDDCg@mail.gmail.com> (raw)
In-Reply-To: <SG2PR02MB2796736A2D3DCEB0AC9AEC9985869@SG2PR02MB2796.apcprd02.prod.outlook.com>

On Wed, Feb 17, 2021 at 12:13 PM Udupa.Ashwini ISV
<udupa.ashwini@inventec.com> wrote:
>
> Hi Ed,
>
>
>
> Its Inventec platform.
>
> https://github.com/openbmc/openbmc/tree/master/meta-inventec
>
> I just wanted to know how to implement /redfish/v1/Systems/system/EthernetInterfaces.

Excellent, that helps.  I originally misread, and thought the
interface was missing on the platform, not that you were trying to add
it to redfish.

>
>
>
> Regards,
>
> Ashwini

Please don't top post.

>
>
>
> From: Ed Tanous <ed@tanous.net>
> Sent: Saturday, February 13, 2021 10:18 AM
> To: Udupa.Ashwini ISV <udupa.ashwini@inventec.com>
> Cc: openbmc@lists.ozlabs.org
> Subject: Re: Redfish v1/Systems/system/EthernetInterfaces
>
>
>
>
>
>
>
> On Sat, Feb 13, 2021 at 10:11 AM Udupa.Ashwini ISV <udupa.ashwini@inventec.com> wrote:
>
>
>
> Hi,
>
>
>
> I am new to OpenBmc and Redfish.
>
> I saw in bmcweb/Redfish.md, that below Redfish is targeted for OpenBmc:

This doc is really old, and was originally written as an initial stab
at what interfaces we should write.  Unfortunately, when it got
converted into a "here's the interfaces we support today" doc, that
path didn't get scrubbed.  We don't have an implementation of it
today.  I can get a review open to update the doc.

>
> /redfish/v1/Systems/system/EthernetInterfaces
>
>
>
> But, in redfish-core/lib/systems.hpp, I don’t see EthernetInterfaces and I don’t see it on my server Redfish too.

Today, we don't have this implemented because we don't really have a
path to get that information from the host.  Doing that would require
either an in-band application running on the main processor to send
new ip addresses to the bmc, or an NCSI, MCTP, or PLDM connection
directly to the NIC that supported getting that level of information.
Both of which likely require a new daemon to expose those APIs to
debug.

We do have /redfish/v1/Systems/hypervisor/EthernetInterfaces today.
We'd ideally want to follow very closely to what that does, expose a
new path on DBus that implements the
xyz.openbmc_project.Network.EthernetInterface interface, and grab the
data from it.

>
>
>
> What upstream system are you trying this on?  If your platform isn’t upstream, can you point at the code review where you’re adding it?
>
>
>
> If you don’t have either, take note that it’s really difficult to help debug or make suggestions for platforms that we can’t see the code for.
>
>
>
> Its only present in Managers/bmc/EthernetInterfaces.
>
>
>
> How do I add Systems/system/EthernetInterfaces Redfish support? What changes do I need to make?
>
>
>
> Regards,
>
> Ashwini
>
>
>
> --
>
> -Ed

  reply	other threads:[~2021-02-17 20:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12  2:51 Redfish v1/Systems/system/EthernetInterfaces Udupa.Ashwini ISV
2021-02-13 18:08 ` Udupa.Ashwini ISV
2021-02-13 18:17   ` Ed Tanous
2021-02-17 20:13     ` Udupa.Ashwini ISV
2021-02-17 20:24       ` Ed Tanous [this message]
2021-02-17 20:51         ` Udupa.Ashwini ISV
2021-02-17 21:04           ` Ed Tanous
2021-02-17 21:22             ` Udupa.Ashwini ISV
2021-02-17 21:32               ` Ed Tanous
2021-02-18  4:04                 ` Udupa.Ashwini ISV

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACWQX80r9dYEGbwftH32Sc6fRmDLHeYg24tdO+8hME9V_bDDCg@mail.gmail.com \
    --to=ed@tanous.net \
    --cc=openbmc@lists.ozlabs.org \
    --cc=udupa.ashwini@inventec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.