Re: [Buildroot] [PATCH v1 2/3] package/libgtk3: re-enable atk-bridge

[Thomas Devoogdt <thomas@devoogdt.com>]

Hi,

I see that X11 support is optional and is automatically detected:
https://github.com/GNOME/at-spi2-core/blob/main/meson_options.txt#L31-L34
So it would be better to append a commit to this one to remove the
Xorg dependency on at-spi2-core.

Kr,

Thomas Devoogdt

Op ma 20 feb. 2023 om 18:22 schreef Peter Korsgaard <peter@korsgaard.com>:
>
> >>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:
>
>  > The reason why it was not used was that at-spi2-core and at-spi2-atk were not available,
>  > since then, it is, so drop this patch. This will also avoid warnings in webkitgtk.
>
>  > Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
>  > ---
>  >  package/libgtk3/0001-disable-atk-bridge.patch | 41 -------------------
>  >  package/libgtk3/Config.in                     |  2 +
>  >  package/libgtk3/libgtk3.mk                    |  4 +-
>  >  3 files changed, 4 insertions(+), 43 deletions(-)
>  >  delete mode 100644 package/libgtk3/0001-disable-atk-bridge.patch
>
>  > diff --git a/package/libgtk3/0001-disable-atk-bridge.patch b/package/libgtk3/0001-disable-atk-bridge.patch
>  > deleted file mode 100644
>  > index f3e9bff2ba..0000000000
>  > --- a/package/libgtk3/0001-disable-atk-bridge.patch
>  > +++ /dev/null
>  > @@ -1,41 +0,0 @@
>  > -Remove atk-bridge support.
>  > -
>  > -atk-bridge doesn't seem useful for now in Buildroot and requires to
>  > -add two new packages just for it: at-spi2-core and at-spi2-atk.
>  > -
>  > -Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
>  > -
>  > ---- a/gtk/a11y/gtkaccessibility.c
>  > -+++ b/gtk/a11y/gtkaccessibility.c
>  > -@@ -37,10 +37,6 @@
>  > - #include <gtk/gtktogglebutton.h>
>  > - #include <gtk/gtkaccessible.h>
>  > -
>  > --#ifdef GDK_WINDOWING_X11
>  > --#include <atk-bridge.h>
>  > --#endif
>  > --
>  > - static gboolean gail_focus_watcher      (GSignalInvocationHint *ihint,
>  > -                                          guint                  n_param_values,
>  > -                                          const GValue          *param_values,
>  > -@@ -988,9 +984,5 @@ _gtk_accessibility_init (void)
>  > -   _gtk_accessibility_override_atk_util ();
>  > -   do_window_event_initialization ();
>  > -
>  > --#ifdef GDK_WINDOWING_X11
>  > --  atk_bridge_adaptor_init (NULL, NULL);
>
>  > --#endif
>  > --
>  > -   atk_misc_instance = g_object_new (GTK_TYPE_MISC_IMPL, NULL);
>  > - }
>  > ---- a/meson.build
>  > -+++ b/meson.build
>  > -@@ -564,7 +564,7 @@ if x11_enabled
>  > -   xfixes_dep     = dependency('xfixes', required: false)
>  > -   xcomposite_dep = dependency('xcomposite', required: false)
>  > -   fontconfig_dep = dependency('fontconfig', fallback: ['fontconfig', 'fontconfig_dep'])
>  > --  atkbridge_dep  = dependency('atk-bridge-2.0', version: at_spi2_atk_req)
>  > -+  atkbridge_dep  = dependency('atk-bridge-2.0', version: at_spi2_atk_req, required: false)
>  > -
>  > -   backend_immodules += ['xim']
>  > -
>
>  > diff --git a/package/libgtk3/Config.in b/package/libgtk3/Config.in
>  > index 82ca68d2da..d921f79226 100644
>  > --- a/package/libgtk3/Config.in
>  > +++ b/package/libgtk3/Config.in
>  > @@ -24,6 +24,8 @@ config BR2_PACKAGE_LIBGTK3
>  >      depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
>  >              BR2_PACKAGE_HAS_LIBGL
>  >      select BR2_PACKAGE_ATK
>  > +    select BR2_PACKAGE_AT_SPI2_ATK
>  > +    select BR2_PACKAGE_AT_SPI2_CORE
>
> at-spi2-core depends on xorg7 / xlib-libXtst, so that would mean that we
> would pull that in even for libgtk3 builds with the broadway/wayland
> backends, is that sensible?
>
> Maybe it is? Does at-spi2 work under wayland?
>
> --
> Bye, Peter Korsgaard
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot