All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sandy Harris <sandyinchina@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	"Ted Ts'o" <tytso@mit.edu>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] random: In _extract_crng() mix in 64 bits if possible
Date: Mon, 13 Sep 2021 10:52:25 +0800	[thread overview]
Message-ID: <CACXcFmmsOM-jcWNBh=H+TBg1U4A1SfYDfYxkqiyre5gYUZTecA@mail.gmail.com> (raw)
In-Reply-To: <CACXcFmnnOK43qvVPPmMhB8+wWre062z-voyahUqX96Zy7byrFQ@mail.gmail.com>

Declare a variable that should have been in commit
 af4047981c61831da73f41d755fbf1f9f20b666a

---
 drivers/char/random.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 2c6b56cf8b27..a2360fb83dbe 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -989,7 +989,8 @@ static void _extract_crng(struct crng_state *crng,
               __u8 out[CHACHA_BLOCK_SIZE])
 {
     unsigned long v, flags;
-        u32 *q ;
+        u32 *p, *q ;
+        p = &crng->state[0] ;
         q = (u32 *) &v ;

     if (crng_ready() &&

      reply	other threads:[~2021-09-13  2:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  2:49 [PATCH] In _extract-crng mix in 64 bits if possible Sandy Harris
2021-09-09  3:43 ` Eric Biggers
2021-09-09  5:14   ` Sandy Harris
2021-09-11  7:19     ` [PATCH] random: In _extract_crng() " Sandy Harris
2021-09-13  2:52       ` Sandy Harris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACXcFmmsOM-jcWNBh=H+TBg1U4A1SfYDfYxkqiyre5gYUZTecA@mail.gmail.com' \
    --to=sandyinchina@gmail.com \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.