All of lore.kernel.org
 help / color / mirror / Atom feed
From: KP Singh <kpsingh@kernel.org>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>,
	Stanislav Fomichev <sdf@google.com>,
	Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH bpf-next] bpf: Fix usage of trace RCU in local storage.
Date: Mon, 18 Apr 2022 17:45:17 +0200	[thread overview]
Message-ID: <CACYkzJ55WjmPtUsozYQQwU5ZwYe2GnY8OyUHseRfcnW_1EVnRA@mail.gmail.com> (raw)
In-Reply-To: <20220418142929.2600589-1-kpsingh@kernel.org>

On Mon, Apr 18, 2022 at 5:25 PM KP Singh <kpsingh@kernel.org> wrote:
>
> From: KP Singh <kpsingh@google.com>
>
> bpf_{sk,task,inode}_storage_free() do not need to use
> call_rcu_tasks_trace as no BPF program should be accessing the owner
> as it's being destroyed. The only other reader at this point is
> bpf_local_storage_map_free() which uses normal RCU.
>
> The only path that needs trace RCU are:
>
> * bpf_local_storage_{delete,update} helpers
> * map_{delete,update}_elem() syscalls
>
> Fixes: 8553c67b1b54 ("bpf: Reduce usage of trace RCU in local storage.")
> Signed-off-by: KP Singh <kpsingh@google.com>

Please ignore. I messed up gitconfig today. Apologies for the noise.
Sending a v2 today with the right Fixes commit.

  reply	other threads:[~2022-04-18 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18 14:29 [PATCH bpf-next] bpf: Fix usage of trace RCU in local storage KP Singh
2022-04-18 15:45 ` KP Singh [this message]
2022-04-18 14:52 KP Singh
2022-04-18 15:44 ` KP Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACYkzJ55WjmPtUsozYQQwU5ZwYe2GnY8OyUHseRfcnW_1EVnRA@mail.gmail.com \
    --to=kpsingh@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=edumazet@google.com \
    --cc=kafai@fb.com \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.