From: KP Singh <kpsingh@kernel.org>
To: Song Liu <songliubraving@fb.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>,
"acme@kernel.org" <acme@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH] perf/core: allow ftrace for functions in kernel/event/core.c
Date: Wed, 13 Oct 2021 18:33:05 +0200 [thread overview]
Message-ID: <CACYkzJ5AVFFnD9fQmjFNrkgxN2qR_k1TshoxhNkku4N9hta1wg@mail.gmail.com> (raw)
In-Reply-To: <A2707216-E8F3-4D91-87AF-6F09CA63415C@fb.com>
On Wed, Oct 13, 2021 at 5:47 PM Song Liu <songliubraving@fb.com> wrote:
>
>
>
> > On Oct 12, 2021, at 5:42 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Wed, Oct 06, 2021 at 02:07:32PM -0700, Song Liu wrote:
> >> It is useful to trace functions in kernel/event/core.c. Allow ftrace for
> >> them by removing $(CC_FLAGS_FTRACE) from Makefile.
> >>
> >> ---
> >> We had some discussions about this last year [1]. Seems that enabling
> >> ftrace in kernel/events won't really cause fatal recursion in the tests.
> >> Shall we give it another try?
> >
> > I suppose we can give it a go..
>
> Yes, please. :-) Shall we ship it with 5.16?
This would be super useful for us, perf_event_* functions are very nicely placed
for tracing events like mmap.
>
> Thanks,
> Song
>
>
next prev parent reply other threads:[~2021-10-13 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 21:07 [PATCH] perf/core: allow ftrace for functions in kernel/event/core.c Song Liu
2021-10-12 12:42 ` Peter Zijlstra
2021-10-13 15:46 ` Song Liu
2021-10-13 16:33 ` KP Singh [this message]
2021-10-13 16:47 ` Steven Rostedt
2021-10-15 13:27 ` Peter Zijlstra
2021-10-15 14:06 ` Steven Rostedt
2021-10-15 9:31 ` [tip: perf/core] perf/core: Allow " tip-bot2 for Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACYkzJ5AVFFnD9fQmjFNrkgxN2qR_k1TshoxhNkku4N9hta1wg@mail.gmail.com \
--to=kpsingh@kernel.org \
--cc=Kernel-team@fb.com \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.