From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7C8C433ED for ; Sat, 24 Apr 2021 19:06:39 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 0F789611CB for ; Sat, 24 Apr 2021 19:06:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F789611CB Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30EDD4013F; Sat, 24 Apr 2021 21:06:38 +0200 (CEST) Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by mails.dpdk.org (Postfix) with ESMTP id D595B40040 for ; Sat, 24 Apr 2021 21:06:36 +0200 (CEST) Received: by mail-qt1-f182.google.com with SMTP id z25so16075111qtn.8 for ; Sat, 24 Apr 2021 12:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aWICIH1HkDdRRUrGZDVcilesmXbr8b9GmLdv2wFEu/A=; b=Ht6p1BB1MsQYJJVU7h7eqjPUfrU1ZoiyEH4Owbqi9QEHwm1hj+RG9RTVYB3Fwjs4fu SWicQmNijdTkl+BQvikYtxLPhdNzNy4jPFCqPnxrxKLn+ePbtX8gt4qHo0Fv3hVK2FxV jfJYC25qhvBLNShPLxCPsCpDcxnQA3zBblS5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aWICIH1HkDdRRUrGZDVcilesmXbr8b9GmLdv2wFEu/A=; b=txTXTEQcKLTwbuxnuJE4nJxfFToA41bm++l/nbfytWb4u9yRZsel6TxSOA4ZYZfCMe 2ish5pBxIHTd0Z/2h4ZaNhO3T0hpUcH24FwBKcxhQFo0YPCjQS1X9LK3QtoVBURTBQd3 EoV63tWVoPjkUYysAHSB2reKYv6kzGe1oQ1h6nY0d0CkYdrdrxxYxiO+Znd12v2UpjNy 5F02zRMB3+s5D6F8efy3nqqaNlKnpS2SeJ7T113sB5loCIEBMJBTeXqSA9bbVvLZxM7h 2qPWfYilMVFgD0suX7sUKMJHTN8TrtfNaSzqljhmbAWkdrqnhRlJ00x1ZCaDZWE8fC/M /drw== X-Gm-Message-State: AOAM530uh6g4qNd5VV7srTp96q1A0cgg/JqJhh0NgWNc+A8BifPMO3zF lWSgmvH/UzKbU/9beQbcDpb+ichjgBzH4oop0+zuuw== X-Google-Smtp-Source: ABdhPJw/3yXsZh9EU/Nhl/Ut3hE1WGgN3PQKha8tGbK1bOclCO/tMhK3NUKix54W12dJCpCSsGxAqIZZqtadKuneyDY= X-Received: by 2002:ac8:6f4c:: with SMTP id n12mr9373833qtv.22.1619291196100; Sat, 24 Apr 2021 12:06:36 -0700 (PDT) MIME-Version: 1.0 References: <20210423051929.12734-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210423051929.12734-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Sat, 24 Apr 2021 12:06:19 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000008d608405c0bc9cf1" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to remove unused function parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000008d608405c0bc9cf1 Content-Type: text/plain; charset="UTF-8" On Thu, Apr 22, 2021 at 9:57 PM Kalesh A P wrote: > > From: Kalesh AP > > 1. Clean up unused function parameters. > 2. Declare no external referenced function as static and remove > their prototye from the header file. > > Fixes: ec77c6298301 ("net/bnxt: add stats context allocation") > Fixes: 200b64ba0be8 ("net/bnxt: free statistics context") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Khaparde Fixed typo - s/prototye/prototype during merge. Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_hwrm.c | 10 ++++------ > drivers/net/bnxt/bnxt_hwrm.h | 4 ---- > 2 files changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index cb2064d..931ecea 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -1899,8 +1899,7 @@ int bnxt_hwrm_stat_clear(struct bnxt *bp, struct bnxt_cp_ring_info *cpr) > return rc; > } > > -int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, > - unsigned int idx __rte_unused) > +static int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, struct bnxt_cp_ring_info *cpr) > { > int rc; > struct hwrm_stat_ctx_alloc_input req = {.req_type = 0 }; > @@ -1923,8 +1922,7 @@ int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, > return rc; > } > > -int bnxt_hwrm_stat_ctx_free(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, > - unsigned int idx __rte_unused) > +static int bnxt_hwrm_stat_ctx_free(struct bnxt *bp, struct bnxt_cp_ring_info *cpr) > { > int rc; > struct hwrm_stat_ctx_free_input req = {.req_type = 0 }; > @@ -2594,7 +2592,7 @@ bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp) > bp->grp_info[i].fw_stats_ctx = -1; > } > if (cpr->hw_stats_ctx_id != HWRM_NA_SIGNATURE) { > - rc = bnxt_hwrm_stat_ctx_free(bp, cpr, i); > + rc = bnxt_hwrm_stat_ctx_free(bp, cpr); > cpr->hw_stats_ctx_id = HWRM_NA_SIGNATURE; > if (rc) > return rc; > @@ -2621,7 +2619,7 @@ int bnxt_alloc_all_hwrm_stat_ctxs(struct bnxt *bp) > cpr = rxq->cp_ring; > } > > - rc = bnxt_hwrm_stat_ctx_alloc(bp, cpr, i); > + rc = bnxt_hwrm_stat_ctx_alloc(bp, cpr); > > if (rc) > return rc; > diff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h > index 0c2e32c..61b3050 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.h > +++ b/drivers/net/bnxt/bnxt_hwrm.h > @@ -168,10 +168,6 @@ int bnxt_hwrm_ring_grp_alloc(struct bnxt *bp, unsigned int idx); > int bnxt_hwrm_ring_grp_free(struct bnxt *bp, unsigned int idx); > > int bnxt_hwrm_stat_clear(struct bnxt *bp, struct bnxt_cp_ring_info *cpr); > -int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, > - struct bnxt_cp_ring_info *cpr, unsigned int idx); > -int bnxt_hwrm_stat_ctx_free(struct bnxt *bp, > - struct bnxt_cp_ring_info *cpr, unsigned int idx); > int bnxt_hwrm_ctx_qstats(struct bnxt *bp, uint32_t cid, int idx, > struct rte_eth_stats *stats, uint8_t rx); > > -- > 2.10.1 > --0000000000008d608405c0bc9cf1--