From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEAB9C433E0 for ; Fri, 12 Mar 2021 00:17:30 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 63CCF64F86 for ; Fri, 12 Mar 2021 00:17:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63CCF64F86 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89A604067E; Fri, 12 Mar 2021 01:17:29 +0100 (CET) Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by mails.dpdk.org (Postfix) with ESMTP id 45C044014D for ; Fri, 12 Mar 2021 01:17:28 +0100 (CET) Received: by mail-qt1-f173.google.com with SMTP id m7so2581174qtq.11 for ; Thu, 11 Mar 2021 16:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Yoa69Wt2hjBkEoRLaxCUFciWCjwZuaLRHubnAeUSlzc=; b=UPvKw88bibtkp+LjTg25yFHVY3DbDNaLREQaBZ97NjWEeF+UorzMMtMM7l/bEumuRT Kycx6R3Qdxh6qe34mi2ahOgwZL5E3/l+SoMWd5RBHRnK+YF2mhWJWdAHIQr8aHFdeVZf 3uqyj2PMgGx85OoAu7eYuznCoYaM01n8TV4Ik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yoa69Wt2hjBkEoRLaxCUFciWCjwZuaLRHubnAeUSlzc=; b=T8axIeUTlx6w6e6EVGk+77IXJyZqVrlIRNIH2qLZEch1gIC82qX4e4w4g2KlP3FzTS syl3Q1cesvditeAVu1betQ5OuwGv0Ik/EOMt9YeYRfJ5HbS9V79KPbACHU5pVDoHQEnE s3oVTHtPHpc0rWTgBfyU+7ae8c4nAvbtBWwjAcn819UKCTktLQfkTZfbti/tE20t13MX xj85Gve36PRDxeLvTOkR1efuK/eS/0xK3JRjRyKKY9+AfQ0gVSS2EtoN1/0LB708fwHu W34UfTFFvOeL4gIQTg0o0ErYNVkQfUUTt6cP9bwOPWcfwAeNlWzWhK7jYNO56Q12QNwi qe6g== X-Gm-Message-State: AOAM5316/GDuXBsYhONUCJqNgYuEAEmNLGgwmUKKqVOs2PqTqZw4CxRv 46znMQfnfvroVPNWOoDTdnkfgJgkHd5TqSdGTnvs+Q== X-Google-Smtp-Source: ABdhPJzaDlr69m8Lhyv+eFDGK2Pdi2Thlide35oqQx/CX3fhziiMKGE6hrcbTaM25hbXpe0eQTSZbhs64oGXc89+UMg= X-Received: by 2002:ac8:71d2:: with SMTP id i18mr9737816qtp.371.1615508247495; Thu, 11 Mar 2021 16:17:27 -0800 (PST) MIME-Version: 1.0 References: <20210310212637.72205-1-ajit.khaparde@broadcom.com> <20210310212637.72205-7-ajit.khaparde@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Thu, 11 Mar 2021 16:17:11 -0800 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Kalesh Anakkur Purayil Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000003f12fd05bd4bd3b5" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2 06/12] net/bnxt: update HWRM structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000003f12fd05bd4bd3b5 Content-Type: text/plain; charset="UTF-8" On Thu, Mar 11, 2021 at 4:08 PM Ferruh Yigit wrote: > > On 3/10/2021 9:26 PM, Ajit Khaparde wrote: > > From: Kalesh AP > > > > Patch brings in the latest hsi_struct_def_dpdk.h. > > HWRM API is now updated to version 1.10.2.15. > > > > Signed-off-by: Kalesh AP > > Reviewed-by: Ajit Khaparde > > --- > > doc/guides/rel_notes/release_21_05.rst | 4 + > > drivers/net/bnxt/hsi_struct_def_dpdk.h | 3689 +++++++++++++++++++----- > > 2 files changed, 2972 insertions(+), 721 deletions(-) > > > > diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst > > index 9fc5e0d6ca..d5cdb2cd2c 100644 > > --- a/doc/guides/rel_notes/release_21_05.rst > > +++ b/doc/guides/rel_notes/release_21_05.rst > > @@ -80,6 +80,10 @@ New Features > > > > * Added support for preferred busy polling. > > > > +* **Updated Broadcom bnxt driver.** > > + > > + * Updated HWRM structures to 1.10.2.15 version. > > + > > Can you please chage the order in the release notes, the order is: > ethdev library, pysical PMDs (alphabetical order for vendor), vitual PMDs, apps > (like testpms) > Acording this order, in current release notes the PMD should be first item in > the section. Ok. Will do. > > > @@ -45297,8 +47545,8 @@ struct hwrm_nvm_mod_dir_entry_input { > > */ > > uint16_t dir_ext; > > /* > > - * Directory Entry Attribute flags (see BNX_DIR_ATTR_* for attribute flag > > - * definitions). > > + * Directory Entry Attribute flags (see BNX_DIR_ATTR_* for attribute > > + * flag definitions). > > */ > > uint16_t dir_attr; > > /* > > @@ -45474,8 +47722,7 @@ struct hwrm_nvm_install_update_input { > > #define HWRM_NVM_INSTALL_UPDATE_INPUT_FLAGS_REMOVE_UNUSED_PKG \ > > UINT32_C(0x2) > > /* > > - * If set to 1, FW will defragment the NVM if defragmentation is required > > - * for the update. > > + * If set to 1, FW will defragment the NVM if defragmentation is required for the update. > > * Allow additional time for this command to complete if this bit is set to 1. > > */ > > #define HWRM_NVM_INSTALL_UPDATE_INPUT_FLAGS_ALLOWED_TO_DEFRAG \ > > > > These changes are only because of word wrapping, there are many samples in the > patch. > I guess the original code has long lines, as the first version, and when they > are converted to shorter lines, it has been done differently from previous time > causing these diffs. > Can you keep the previous version wrapping to prevent the unnecesarry diffs? Ideally I wanted to get this from the auto-generator script. But that was going to take time, so I edited the file manually. And yes, I modified a few extra lines which checkpatch was not complaining about. I will send another version to minimize the changes. --0000000000003f12fd05bd4bd3b5--