Re: [dpdk-dev] [PATCH] net/bnxt: remove unnecessary forward declaration

From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove unnecessary forward declaration
Date: Sat, 24 Apr 2021 12:01:35 -0700	[thread overview]
Message-ID: <CACZ4nhtDfs12SCg2rOnSaE3Xhjic_vjAPjs+VeOYArn6Y5-jaA@mail.gmail.com> (raw)
In-Reply-To: <20210422041200.2470-1-kalesh-anakkur.purayil@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 3356 bytes --]

On Wed, Apr 21, 2021 at 8:50 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> This patch removes several redundant forward declarations of
> functions and structure.
>
> Fixes: 0b42b92ae429 ("net/bnxt: fix xstats by id")
> Fixes: cf4f055a6578 ("net/bnxt: remove EEM system memory support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks

> ---
>  drivers/net/bnxt/bnxt.h       | 8 --------
>  drivers/net/bnxt/bnxt_hwrm.h  | 1 -
>  drivers/net/bnxt/bnxt_stats.h | 5 -----
>  3 files changed, 14 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
> index dfdfa9f..bd2dec4 100644
> --- a/drivers/net/bnxt/bnxt.h
> +++ b/drivers/net/bnxt/bnxt.h
> @@ -597,13 +597,6 @@ struct bnxt_rep_info {
>                                      DEV_RX_OFFLOAD_SCATTER | \
>                                      DEV_RX_OFFLOAD_RSS_HASH)
>
> -#define  MAX_TABLE_SUPPORT 4
> -#define  MAX_DIR_SUPPORT   2
> -struct bnxt_dmabuf_info {
> -       uint32_t entry_num;
> -       int      fd[MAX_DIR_SUPPORT][MAX_TABLE_SUPPORT];
> -};
> -
>  #define BNXT_HWRM_SHORT_REQ_LEN                sizeof(struct hwrm_short_input)
>
>  struct bnxt_flow_stat_info {
> @@ -834,7 +827,6 @@ struct bnxt {
>         uint16_t                port_svif;
>
>         struct tf               tfp;
> -       struct bnxt_dmabuf_info dmabuf;
>         struct bnxt_ulp_context *ulp_ctx;
>         struct bnxt_flow_stat_info *flow_stat;
>         uint16_t                max_num_kflows;
> diff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h
> index 0c2e32c..d9771ea 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.h
> +++ b/drivers/net/bnxt/bnxt_hwrm.h
> @@ -294,7 +294,6 @@ int bnxt_hwrm_get_dflt_vnic_svif(struct bnxt *bp, uint16_t fid,
>                                  uint16_t *vnic_id, uint16_t *svif);
>  int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp);
>  int bnxt_hwrm_port_phy_qcaps(struct bnxt *bp);
> -int bnxt_hwrm_oem_cmd(struct bnxt *bp, uint32_t entry_num);
>  int bnxt_clear_one_vnic_filter(struct bnxt *bp,
>                                struct bnxt_filter_info *filter);
>  void bnxt_free_vf_info(struct bnxt *bp);
> diff --git a/drivers/net/bnxt/bnxt_stats.h b/drivers/net/bnxt/bnxt_stats.h
> index 0ee2269..e9e5636 100644
> --- a/drivers/net/bnxt/bnxt_stats.h
> +++ b/drivers/net/bnxt/bnxt_stats.h
> @@ -18,11 +18,6 @@ int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
>  int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
>                            struct rte_eth_xstat *xstats, unsigned int n);
>  int bnxt_dev_xstats_reset_op(struct rte_eth_dev *eth_dev);
> -int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t *ids,
> -                               uint64_t *values, unsigned int limit);
> -int bnxt_dev_xstats_get_names_by_id_op(struct rte_eth_dev *dev,
> -                               struct rte_eth_xstat_name *xstats_names,
> -                               const uint64_t *ids, unsigned int limit);
>
>  struct bnxt_xstats_name_off {
>         char name[RTE_ETH_XSTATS_NAME_SIZE];
> --
> 2.10.1
>