From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Ori Kam <orika@nvidia.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ray Kinsella <mdr@ashroe.eu>, dpdk-dev <dev@dpdk.org>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Akhil Goyal <gakhil@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data
Date: Tue, 3 Aug 2021 11:10:57 -0700 [thread overview]
Message-ID: <CACZ4nhtqiWh1ccToU2H+=5wuB-Af0Hms8iNPGgeWmvOxehFHEA@mail.gmail.com> (raw)
In-Reply-To: <20210803085754.643180-1-orika@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]
On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote:
>
> In the current implementation,
> the action rte_flow_action_modify_field is not well defined
> for fields larger than 64 bits (for example IPv6 source)
> In addition, the byte order is also not well defined.
>
> Both of those issue should be fixed.
>
> Signed-off-by: Ori Kam <orika@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> V2:
> Fix typo.
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index d9c0e65921..b530616281 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -158,3 +158,7 @@ Deprecation Notices
> * security: The functions ``rte_security_set_pkt_metadata`` and
> ``rte_security_get_userdata`` will be made inline functions and additional
> flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> +
> +* ethdev: The struct ``rte_flow_action_modify_data`` will be modified
> + to support modifying larger fields than 64 bits.
> + In addition, documentation will be updated to clarify byte order.
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-08-03 18:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 14:10 [dpdk-dev] [PATCH 1/2] ethdev: announce change to action modify data Matan Azrad
2021-08-02 14:10 ` [dpdk-dev] [PATCH 2/2] ethdev: announce moving to general modify function Matan Azrad
2021-08-03 8:57 ` [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data Ori Kam
2021-08-03 8:57 ` [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function Ori Kam
2021-08-03 18:05 ` Ajit Khaparde
2021-08-07 13:33 ` Jerin Jacob
2021-08-07 19:34 ` Thomas Monjalon
2021-08-03 18:10 ` Ajit Khaparde [this message]
2021-08-04 12:10 ` [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data Andrew Rybchenko
2021-08-07 13:33 ` Jerin Jacob
2021-08-07 19:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhtqiWh1ccToU2H+=5wuB-Af0Hms8iNPGgeWmvOxehFHEA@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gakhil@marvell.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.