Re: [PATCH] net/bnxt: add back dependency to virt kmods

From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: "Geoffrey Le Gourriérec" <geoffrey.le_gourrierec@6wind.com>
Cc: dpdk-dev <dev@dpdk.org>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	 Ferruh Yigit <ferruh.yigit@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	 Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH] net/bnxt: add back dependency to virt kmods
Date: Fri, 14 Jan 2022 09:46:20 -0800	[thread overview]
Message-ID: <CACZ4nhtwTjCFQWH+GyFTHF7bqsDkv1+cPfg7-XV04yvmd6P-DA@mail.gmail.com> (raw)
In-Reply-To: <20220112134152.3850-1-geoffrey.le_gourrierec@6wind.com>

On Wed, Jan 12, 2022 at 5:42 AM Geoffrey Le Gourriérec
<geoffrey.le_gourrierec@6wind.com> wrote:
>
> During a large refactoring sweep for 21.11, a previous commit
> removed the dependency the bnxt driver had on Linux virtual
> bus drivers, such as vfio-pci. This breaks port detection.
>
> This patch adds the kmod dependency back as it was.
>
> Fixes: 295968d17407 ("ethdev: add namespace")
> Signed-off-by: Geoffrey Le Gourriérec <geoffrey.le_gourrierec@6wind.com>

Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Thanks. Patch applied to dpdk-next-net-brcm.

>
> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index f79f33ab4e17..3ca6b7be7b6a 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -6302,4 +6302,5 @@ bool is_bnxt_supported(struct rte_eth_dev *dev)
>  RTE_LOG_REGISTER_SUFFIX(bnxt_logtype_driver, driver, NOTICE);
>  RTE_PMD_REGISTER_PCI(net_bnxt, bnxt_rte_pmd);
>  RTE_PMD_REGISTER_PCI_TABLE(net_bnxt, bnxt_pci_id_map);
> +RTE_PMD_REGISTER_KMOD_DEP(net_bnxt, "* igb_uio | uio_pci_generic | vfio-pci");
>
> --
> 2.30.2
>