From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH] net/bnxt: fix uninitialized variable access
Date: Mon, 5 Nov 2018 09:38:13 -0800
Message-ID: <CACZ4nhuAg5ucbHUny+MgRpSZ=HScbKURw=YXqWAT3fgxAioXEg@mail.gmail.com>
References: <20181028043542.87350-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Somnath Kotur <somnath.kotur@broadcom.com>, dev@dpdk.org,
 dpdk stable <stable@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com
 [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id 3E60E4CC5
 for <dev@dpdk.org>; Mon,  5 Nov 2018 18:38:30 +0100 (CET)
Received: by mail-ot1-f66.google.com with SMTP id 40so8545456oth.4
 for <dev@dpdk.org>; Mon, 05 Nov 2018 09:38:30 -0800 (PST)
In-Reply-To: <20181028043542.87350-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, Oct 27, 2018 at 8:36 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> ag_cons is used uninitialized, it is used when DEBUG enabled, remove
> debug code.
>
> Fixes: 0958d8b6435d ("net/bnxt: support LRO")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

We have not enabled this for debug for a while now.
We can remove this. Thanks



> ---
>  drivers/net/bnxt/bnxt_rxr.c | 24 ------------------------
>  1 file changed, 24 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index c7bc88481..1bfc63d93 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -102,25 +102,6 @@ static inline void bnxt_reuse_rx_mbuf(struct
> bnxt_rx_ring_info *rxr,
>         rxr->rx_prod = prod;
>  }
>
> -#ifdef BNXT_DEBUG
> -static void bnxt_reuse_ag_mbuf(struct bnxt_rx_ring_info *rxr, uint16_t
> cons,
> -                              struct rte_mbuf *mbuf)
> -{
> -       uint16_t prod = rxr->ag_prod;
> -       struct bnxt_sw_rx_bd *prod_rx_buf;
> -       struct rx_prod_pkt_bd *prod_bd, *cons_bd;
> -
> -       prod_rx_buf = &rxr->ag_buf_ring[prod];
> -
> -       prod_rx_buf->mbuf = mbuf;
> -
> -       prod_bd = &rxr->ag_desc_ring[prod];
> -       cons_bd = &rxr->ag_desc_ring[cons];
> -
> -       prod_bd->address = cons_bd->addr;
> -}
> -#endif
> -
>  static inline
>  struct rte_mbuf *bnxt_consume_rx_buf(struct bnxt_rx_ring_info *rxr,
>                                      uint16_t cons)
> @@ -377,9 +358,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
>         uint32_t tmp_raw_cons = *raw_cons;
>         uint16_t cons, prod, cp_cons =
>             RING_CMP(cpr->cp_ring_struct, tmp_raw_cons);
> -#ifdef BNXT_DEBUG
> -       uint16_t ag_cons;
> -#endif
>         struct rte_mbuf *mbuf;
>         int rc = 0;
>         uint8_t agg_buf = 0;
> @@ -482,8 +460,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
>         if (rxcmp1->errors_v2 & RX_CMP_L2_ERRORS) {
>                 /* Re-install the mbuf back to the rx ring */
>                 bnxt_reuse_rx_mbuf(rxr, cons, mbuf);
> -               if (agg_buf)
> -                       bnxt_reuse_ag_mbuf(rxr, ag_cons, mbuf);
>
>                 rc = -EIO;
>                 goto next_rx;
> --
> 2.17.2
>
>