Re: [dpdk-dev] [PATCH] [RFC, v2]: adds support PPS(packet per second) on meter

From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Li Zhang <lizh@nvidia.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
	"Ferruh Yigit" <ferruh.yigit@intel.com>,
	"Dekel Peled" <dekelp@nvidia.com>, "Ori Kam" <orika@nvidia.com>,
	"Slava Ovsiienko" <viacheslavo@nvidia.com>,
	"Matan Azrad" <matan@nvidia.com>,
	"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"NBU-Contact-Thomas Monjalon" <thomas@monjalon.net>,
	"Raslan Darawsheh" <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] [RFC, v2]: adds support PPS(packet per second) on meter
Date: Sun, 28 Feb 2021 19:31:03 -0800	[thread overview]
Message-ID: <CACZ4nhuJqi_1x0vj_WKik2xpxcBJVRAgi7HTJnc2qDCREGjj0A@mail.gmail.com> (raw)
In-Reply-To: <DM6PR12MB4090CF8BFD3DABB699B59CDDBF9A9@DM6PR12MB4090.namprd12.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

On Sun, Feb 28, 2021 at 7:16 PM Li Zhang <lizh@nvidia.com> wrote:
>
> Hi Morten,
>
> Thank you for your comments.
> It is packet count instead of frames count.
> So 4K TCP packet should be handle as one instead of 3 Ethernet Frames.
So it is not dependent on the MTU?

>
> We will update the struct as below:
> enum rte_mtr_algorithm {
> ......
>         /** Single Rate Three Color Marker, Packet based (srTCMp).
+1

>          * - - similar to IETF RFC 2697 but rate is packet per second.
s/rate is/measured in

>          */
>         RTE_MTR_SRTCMP,
> }
>
> struct rte_mtr_meter_profile {
> ......
>                 /** Items only valid when *alg* is set to srTCMp. */
>                 struct {
>                         /** Committed Information Rate (CIR)
>                          * (packets/second).
>                          */
>                         uint64_t cir;
>
>                         /** Committed Burst Size (CBS) (packets). */
>                         uint64_t cbs;
>
>                         /** Excess Burst Size (EBS) (packets). */
>                         uint64_t ebs;
>                 } srtcmp;
> }
>
::::[snip]::::