All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Gaurav Singh <gaurav1086@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove redundant null check in bnxt_validate_and_parse_flow_type
Date: Tue, 1 Sep 2020 21:03:56 -0700	[thread overview]
Message-ID: <CACZ4nhupd+0+ino7=Vi3mnSgcH2bO05WTYg-R+E6Puf9cT9m4Q@mail.gmail.com> (raw)
In-Reply-To: <20200806035213.22538-1-gaurav1086@gmail.com>

On Wed, Aug 5, 2020 at 8:52 PM Gaurav Singh <gaurav1086@gmail.com> wrote:

> vxlan_spec cannot be NULL since its already being accessed
> before. Remove the redundant NULL check.
>
> Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
>
Patch applied to dpdk-next-net-brcm. Thanks


> ---
>  drivers/net/bnxt/bnxt_flow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> index 320b53d94..c1c59bbe5 100644
> --- a/drivers/net/bnxt/bnxt_flow.c
> +++ b/drivers/net/bnxt/bnxt_flow.c
> @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
>                         }
>
>                         /* Check if VNI is masked. */
> -                       if (vxlan_spec && vxlan_mask) {
> +                       if (vxlan_mask != NULL) {
>                                 vni_masked =
>                                         !!memcmp(vxlan_mask->vni, vni_mask,
>                                                  RTE_DIM(vni_mask));
> --
> 2.17.1
>
>

      reply	other threads:[~2020-09-02  4:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31  2:34 [dpdk-dev] [PATCH] net/bxnt: remove redundant null check Gaurav Singh
2020-07-31  5:03 ` Ajit Khaparde
2020-08-05 20:11   ` Thomas Monjalon
2020-08-06  3:50     ` [dpdk-dev] [PATCH] net/bnxt: remove redundant null check in bnxt_validate_and_parse_flow_type Gaurav Singh
2020-08-06  3:52 ` Gaurav Singh
2020-09-02  4:03   ` Ajit Khaparde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACZ4nhupd+0+ino7=Vi3mnSgcH2bO05WTYg-R+E6Puf9cT9m4Q@mail.gmail.com' \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=gaurav1086@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.