From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A845C433EF for ; Sun, 26 Sep 2021 21:17:07 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id B732860F6B for ; Sun, 26 Sep 2021 21:17:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B732860F6B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A67DC4003D; Sun, 26 Sep 2021 23:17:05 +0200 (CEST) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by mails.dpdk.org (Postfix) with ESMTP id 237BC4003C for ; Sun, 26 Sep 2021 23:17:04 +0200 (CEST) Received: by mail-il1-f181.google.com with SMTP id a11so5627085ilk.9 for ; Sun, 26 Sep 2021 14:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mzrCyE6/FCHCC7Mlx11sDL3IEb1Hz3vD+AqYgkJ6JY0=; b=D43RSjPsOZdma3tMbjQkT8+Y7gK8B2HkeTlROdX87Gd7NsHOMD9ePVzJ/yJmiBhAsE /MjvDgdbneUaco5/HDD9m4zv4lCp/OIH8SeS29fV2GilvH779AON2HZuFqTbEVPmExbE O96ZracnQhIwPUvoeikm4rmGPIORGtuiBXVL0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mzrCyE6/FCHCC7Mlx11sDL3IEb1Hz3vD+AqYgkJ6JY0=; b=QpJdUgx3J6b1tfDsF6Gp9EtMP1Ji53Ozqkq8p/3JdGLrDbxvdGIKqQTtbclIIXTetY AS7prWfQWC4s0D2j4c5dT8HwzZfXmpEOpUqeT/ak0b9tApzRym9lB12R5wwHxDkPHYk9 V/+r52rcT2Ly0xvjU8Wqn+z2ReZfMNyU3EcpS5PhV75Iatwi1yr2lQB3cXWhjfAX6He/ FZEBDU8Q9PQNGri+iE3LPtRS0uNzvQWYUrrM1Pp3QTEOOsJVj1SMPPA7M3+scMolFH5y XW8Reir3ur/s4MDVmFfyWHNZK4V9UiVLycKYoXl+gQXHRcJ2k76kTT8K2HA2RFSlnOkX 2f2w== X-Gm-Message-State: AOAM533kQCnCQTRwKsICjIC5tLV3vZpn8+RzA8WacSRI1EgvetMUdU8V aDspta9U/b15JIJty3+/+FsNsdWQGX3noy+a3Vt73w== X-Google-Smtp-Source: ABdhPJy170L4nZUSDQ8WXGzUvalJZ9IhnF0oShwSBL+l3i/5MmJpOEvPlftUvdIPDo+opdefnjxXlZ1jPGXVwFf6C1U= X-Received: by 2002:a05:6e02:1985:: with SMTP id g5mr4958258ilf.311.1632691023319; Sun, 26 Sep 2021 14:17:03 -0700 (PDT) MIME-Version: 1.0 References: <20210922083044.21242-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210922083044.21242-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Sun, 26 Sep 2021 14:16:47 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000007e503505ccec803c" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix function driver register/unregister functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000007e503505ccec803c Content-Type: text/plain; charset="UTF-8" On Wed, Sep 22, 2021 at 1:10 AM Kalesh A P wrote: > > From: Kalesh AP > > 1. Fix to use correct fields in the request structure of > HWRM_FUNC_DRV_RGTR. > 2. Remove the "flags" argument to bnxt_hwrm_func_driver_unregister() > as it is not needed. > > Fixes: beb3087f5056 ("net/bnxt: add driver register/unregister") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde > Reviewed-by: Lance Richardson > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 +- > drivers/net/bnxt/bnxt_hwrm.c | 9 ++++----- > drivers/net/bnxt/bnxt_hwrm.h | 2 +- > 3 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 097dd10..dc7dee1 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -6156,7 +6156,7 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev) > bp->pf->vf_req_buf = NULL; > } > > - rc = bnxt_hwrm_func_driver_unregister(bp, 0); > + rc = bnxt_hwrm_func_driver_unregister(bp); > bp->flags &= ~BNXT_FLAG_REGISTERED; > bnxt_free_ctx_mem(bp); > if (!reconfig_dev) { > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 585cded..d4d8581 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -1059,9 +1059,9 @@ int bnxt_hwrm_func_driver_register(struct bnxt *bp) > HWRM_PREP(&req, HWRM_FUNC_DRV_RGTR, BNXT_USE_CHIMP_MB); > req.enables = rte_cpu_to_le_32(HWRM_FUNC_DRV_RGTR_INPUT_ENABLES_VER | > HWRM_FUNC_DRV_RGTR_INPUT_ENABLES_ASYNC_EVENT_FWD); > - req.ver_maj = RTE_VER_YEAR; > - req.ver_min = RTE_VER_MONTH; > - req.ver_upd = RTE_VER_MINOR; > + req.ver_maj_8b = RTE_VER_YEAR; > + req.ver_min_8b = RTE_VER_MONTH; > + req.ver_upd_8b = RTE_VER_MINOR; > > if (BNXT_PF(bp)) { > req.enables |= rte_cpu_to_le_32( > @@ -1370,7 +1370,7 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) > return rc; > } > > -int bnxt_hwrm_func_driver_unregister(struct bnxt *bp, uint32_t flags) > +int bnxt_hwrm_func_driver_unregister(struct bnxt *bp) > { > int rc; > struct hwrm_func_drv_unrgtr_input req = {.req_type = 0 }; > @@ -1380,7 +1380,6 @@ int bnxt_hwrm_func_driver_unregister(struct bnxt *bp, uint32_t flags) > return 0; > > HWRM_PREP(&req, HWRM_FUNC_DRV_UNRGTR, BNXT_USE_CHIMP_MB); > - req.flags = flags; > > rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); > > diff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h > index b311ff5..6dc23b9 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.h > +++ b/drivers/net/bnxt/bnxt_hwrm.h > @@ -145,7 +145,7 @@ int bnxt_hwrm_func_buf_unrgtr(struct bnxt *bp); > int bnxt_hwrm_func_driver_register(struct bnxt *bp); > int bnxt_hwrm_func_qcaps(struct bnxt *bp); > int bnxt_hwrm_func_reset(struct bnxt *bp); > -int bnxt_hwrm_func_driver_unregister(struct bnxt *bp, uint32_t flags); > +int bnxt_hwrm_func_driver_unregister(struct bnxt *bp); > int bnxt_hwrm_func_qstats(struct bnxt *bp, uint16_t fid, > struct rte_eth_stats *stats, > struct hwrm_func_qstats_output *func_qstats); > -- > 2.10.1 > --0000000000007e503505ccec803c--