From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D16F9C07E96 for ; Thu, 15 Jul 2021 08:55:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24E606127C for ; Thu, 15 Jul 2021 08:55:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24E606127C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3x9g-0004s1-VK for qemu-devel@archiver.kernel.org; Thu, 15 Jul 2021 04:55:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3x8a-0004Aw-AR for qemu-devel@nongnu.org; Thu, 15 Jul 2021 04:54:32 -0400 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:36799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3x8Y-00062l-Hf for qemu-devel@nongnu.org; Thu, 15 Jul 2021 04:54:32 -0400 Received: by mail-ot1-x32c.google.com with SMTP id h24-20020a9d64180000b029036edcf8f9a6so5443086otl.3 for ; Thu, 15 Jul 2021 01:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=so7fZ9vcz5dtRxkyG6SAP+DH0rYMK+e2vHeOc2ltn9o=; b=I60PnNvu324dS6hJVOMWs5eSpi2cvw3sFweUYVvzehyfdXZt3KKqpK/cQEhv6IBdQp 873MEE9Gwj1N7rw7cH8RsQySZgk/up/UTo1IpWYCyahBneJevZr7/3EZo2eqvoiI3ar5 IPWb5US8PeOJDMsgmBomijc0A1uh9I0CkMPJyzR0OF/SQFE5WS6wtwJURz5Vi3KZlnV5 YurOrfy5l/RTBhKlq3CwjVeuyyJw6msyfK8kzMEhnvlv+OJxyoJk7h1/5Y3zv/NNtl7g NCqXpnGXO139rQ8R7W0GDTxypa+F5LcXCj3mkKm+np0wjjzqJS+bvt5dRhMWviUWJ9CS RYxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=so7fZ9vcz5dtRxkyG6SAP+DH0rYMK+e2vHeOc2ltn9o=; b=YfhXI7AbY2yu/0X4IZGbA7NjIXLu15f4gGOydWxAwE4HcXKDAMJtcFAClZw7/vvgxl VivF0MJLur0vjuT935e2dLnVGOYMtgulEcZW+/0DlhPj0YBepyS+WNv31j5Qa2yrlM8e dWXsZ06WChrAXx/1i+NvBEccMn6Gg4/Ejdf7uSwajn9/Fy/YQDRk+zO5iAcJ++0dEYV1 7LH1tLf1AasSUOEifAhO2+D043SDDRe/NerbhPCN6yI3btdZQuZqorjqH6dOZPaCvfn+ JVxezdWlQpUgx1jDp68XUKqep7g3zlJ0P5ohyLfVi/89MSRFLZdxL7va8iCUo2exJB7P fJEw== X-Gm-Message-State: AOAM5326lHjudbuihcqZGaQT3s6DGThMsKuMTVu8lKFfdIXJYpLuccrA Zvpj6o0kMTlZ+DQ6NDUp9FUzGX91bY/t0c3LtiY= X-Google-Smtp-Source: ABdhPJxMkTQiCUM3XQ+5zIrL8YWZmnMSu3jmh5OoR0PFyvaO5mhERz3GM7LiwLRWHoJN5mBwIivUB++K4xlTqCUpn/M= X-Received: by 2002:a9d:ac9:: with SMTP id 67mr2933643otq.190.1626339268851; Thu, 15 Jul 2021 01:54:28 -0700 (PDT) MIME-Version: 1.0 References: <20210713220946.212562-1-mst@redhat.com> In-Reply-To: From: Marcel Apfelbaum Date: Thu, 15 Jul 2021 11:54:17 +0300 Message-ID: Subject: Re: [PULL 00/23] pc,pci,virtio: lots of new features To: Mathieu Poirier , "Michael S. Tsirkin" Content-Type: multipart/alternative; boundary="000000000000677b4605c7259eae" Received-SPF: pass client-ip=2607:f8b0:4864:20::32c; envelope-from=marcel.apfelbaum@gmail.com; helo=mail-ot1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000677b4605c7259eae Content-Type: text/plain; charset="UTF-8" Hi, On Wed, Jul 14, 2021 at 11:33 PM Peter Maydell wrote: > On Tue, 13 Jul 2021 at 23:10, Michael S. Tsirkin wrote: > > > > The following changes since commit > 708f50199b59476ec4b45ebcdf171550086d6292: > > > > Merge remote-tracking branch > 'remotes/ericb/tags/pull-nbd-2021-07-09-v2' into staging (2021-07-13 > 14:32:20 +0100) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > for you to fetch changes up to cf171f90d5e41730ad3e0ce23f1990f34b7e63ef: > > > > vhost-vsock: SOCK_SEQPACKET feature bit support (2021-07-13 16:59:12 > -0400) > > > > ---------------------------------------------------------------- > > pc,pci,virtio: lots of new features > > > > Lots of last minute stuff. > > > > vhost-user-rng. > > vhost-user-i2c. > > vhost-vsock SOCK_SEQPACKET support. > > IOMMU bypass. > > ACPI based pci hotplug. > > > > Signed-off-by: Michael S. Tsirkin > > This seems to produce a new meson warning: > > Configuring 50-qemu-gpu.json using configuration > Configuring 50-qemu-virtiofsd.json using configuration > Configuring 50-qemu-rng.json using configuration > ../../tools/vhost-user-rng/meson.build:7: WARNING: The variable(s) > 'libexecdir' in the input file > 'tools/vhost-user-rng/50-qemu-rng.json.in' are not present in the > given configuration data. > Configuring 50-edk2-i386-secure.json using configuration > Configuring 50-edk2-x86_64-secure.json using configuration > Configuring 60-edk2-aarch64.json using configuration > > (the build then seems to go on to complete OK). > /cc Mathieu The below patch solved the warning for me: diff --git a/tools/vhost-user-rng/meson.build b/tools/vhost-user-rng/meson.build index 4dc386daf3..2192a65ca6 100644 --- a/tools/vhost-user-rng/meson.build +++ b/tools/vhost-user-rng/meson.build @@ -6,5 +6,5 @@ executable('vhost-user-rng', files( configure_file(input: '50-qemu-rng.json.in', output: '50-qemu-rng.json', - configuration: config_host, + configuration: { 'libexecdir' : get_option('prefix') / get_option('libexecdir') }, install_dir: qemu_datadir / 'vhost-user') Thanks, Marcel > > -- PMM > > --000000000000677b4605c7259eae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,=C2=A0

On Wed, Jul 14, 2021 at 11:33 PM= Peter Maydell <peter.maydel= l@linaro.org> wrote:
On Tue, 13 Jul 2021 at 23:10, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> The following changes since commit 708f50199b59476ec4b45ebcdf171550086= d6292:
>
>=C2=A0 =C2=A0Merge remote-tracking branch 'remotes/ericb/tags/pull-= nbd-2021-07-09-v2' into staging (2021-07-13 14:32:20 +0100)
>
> are available in the Git repository at:
>
>=C2=A0 =C2=A0git://git.kernel.org/pub/scm/vir= t/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to cf171f90d5e41730ad3e0ce23f1990f34b7e63e= f:
>
>=C2=A0 =C2=A0vhost-vsock: SOCK_SEQPACKET feature bit support (2021-07-1= 3 16:59:12 -0400)
>
> ----------------------------------------------------------------
> pc,pci,virtio: lots of new features
>
> Lots of last minute stuff.
>
> vhost-user-rng.
> vhost-user-i2c.
> vhost-vsock SOCK_SEQPACKET support.
> IOMMU bypass.
> ACPI based pci hotplug.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

This seems to produce a new meson warning:

Configuring 50-qemu-gpu.json using configuration
Configuring 50-qemu-virtiofsd.json using configuration
Configuring 50-qemu-rng.json using configuration
../../tools/vhost-user-rng/meson.build:7: WARNING: The variable(s)
'libexecdir' in the input file
'tools/vhost-user-rng/50-qemu-rng.json.in' are not present in = the
given configuration data.
Configuring 50-edk2-i386-secure.json using configuration
Configuring 50-edk2-x86_64-secure.json using configuration
Configuring 60-edk2-aarch64.json using configuration

(the build then seems to go on to complete OK).

/cc Mathieu

The below patch solved th= e warning for me:

diff --git a/tools/vhost-user-rn= g/meson.build b/tools/vhost-user-rng/meson.build
index 4dc386daf3..2192a= 65ca6 100644
--- a/tools/vhost-user-rng/meson.build
+++ b/tools/vhost= -user-rng/meson.build
@@ -6,5 +6,5 @@ executable('vhost-user-rng'= ;, files(
=C2=A0
=C2=A0configure_file(input: '50-qemu-rng.json.in',
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 output: '50-qemu-rng.json',
-= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 configuration: config_hos= t,
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 configuration: { &= #39;libexecdir' : get_option('prefix') / get_option('libexe= cdir') },
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 in= stall_dir: qemu_datadir / 'vhost-user')


Thanks,
Marcel

=C2=A0

-- PMM

--000000000000677b4605c7259eae--