From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CACC433E0 for ; Wed, 3 Feb 2021 20:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A36A64DD5 for ; Wed, 3 Feb 2021 20:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232073AbhBCUu7 (ORCPT ); Wed, 3 Feb 2021 15:50:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232320AbhBCUuW (ORCPT ); Wed, 3 Feb 2021 15:50:22 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE073C0613ED for ; Wed, 3 Feb 2021 12:49:40 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id m6so621583pfk.1 for ; Wed, 03 Feb 2021 12:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc :content-transfer-encoding; bh=M8lFoGv6mHlkS4pfcEZxXT0GjlBrKSHlOVSDDjgilMk=; b=rM1xvLKChJbMhPiPxDWEcePASMy0cf8HeErbywGhn2uz/vxUt3AWciE3Uj63Z9rkey 3clwXdhoaZ9tcupljd+xCp/yiRwzX/ekcHuZsIbhXa17Qm+44qBkGfi0JFpr2BfLDeUP uL4Jo+ge5eJYzKr58jmA5TrlIeovIVSgJdXR6bfIIoYV+m7rgmaz3WLeyQzZxEEjpNnU UNyxblr37Vse2cJev1TBfQXLjVuw5otZVV5JNNT8jZRq/IIGsHa9JjamNNJP/gdZTaZo +iWKjsNqQHVX2hrRwm0Ki4jIyyS7RT2xYbuq6koIXVc5C5NFulhXVP9qaCbJ3Xt/zb+N PvcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc:content-transfer-encoding; bh=M8lFoGv6mHlkS4pfcEZxXT0GjlBrKSHlOVSDDjgilMk=; b=jhSBqEkapwp/7xjDfqWvap6XoZ4ugiauXZqOrmBJD20Vuhd2jcB+ZtjTIVPDUR3FNW LP0l//gjZz+3OVXOhQD/E6Ndmf10m2z0/8y4Hc5NjEA/RtFpgQD9qcGZL8nT2ETXp5sz u84fwQKlWVu//sz2FwYskN2XcU2RSY0Xi1e/qBv1TdG6FkKe3EM803JEC/hPJS3BEGGS WiC7ivi2I4PZ5u/0kNmGbKLOB+gXrBW/LVMvM3VOPrD+8QqHo82pvbKJRUlpRG0+Ta1f 64XGL0YTVcHMsRbXSR5yqlvApQnU7iGETQBXvHdY2oK5SDx+RFu+fypuuZV1NsyWcdCI 6Gpg== X-Gm-Message-State: AOAM533nJZnqb1wkc9p0LBEG+I1xrc2ej6HYqHVqJD/3i/FwqpElav9D VfdiLmA11XbjlbU4cdgPlH2mlDNZtQeYc7FJpD13uw== X-Received: by 2002:aa7:910a:0:b029:1c8:9947:305c with SMTP id 10-20020aa7910a0000b02901c89947305cmt3620827pfh.75.1612385380012; Wed, 03 Feb 2021 12:49:40 -0800 (PST) MIME-Version: 1.0 References: <20210128182432.2216573-1-kaleshsingh@google.com> In-Reply-To: <20210128182432.2216573-1-kaleshsingh@google.com> From: Kalesh Singh Date: Wed, 3 Feb 2021 15:49:27 -0500 Message-ID: Subject: Re: [PATCH 0/2] Allow reading process DMA buf stats from fdinfo Cc: Jann Horn , Jeffrey Vander Stoep , Kees Cook , Suren Baghdasaryan , Minchan Kim , Hridya Valsaraju , "Cc: Android Kernel" , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Alexey Dobriyan , "Eric W. Biederman" , Andrew Morton , Alexey Gladkov , Daniel Jordan , Michel Lespinasse , Bernd Edlinger , Andrei Vagin , Yafang Shao , Christian Brauner , Linux Media Mailing List , DRI mailing list , "moderated list:DMA BUFFER SHARING FRAMEWORK" , LKML , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 1:24 PM Kalesh Singh wrote= : > > Android captures per-process system memory state when certain low memory > events (e.g a foreground app kill) occur, to identify potential memory > hoggers. In order to measure how much memory a process actually consumes, > it is necessary to include the DMA buffer sizes for that process in the > memory accounting. Since the handle to DMA buffers are raw FDs, it is > important to be able to identify which processes have FD references to > a DMA buffer. > > Currently, DMA buffer FDs can be accounted using /proc//fd/* and > /proc//fdinfo -- both are only readable by the process owner, > as follows: > 1. Do a readlink on each FD. > 2. If the target path begins with "/dmabuf", then the FD is a dmabuf FD= . > 3. stat the file to get the dmabuf inode number. > 4. Read/ proc//fdinfo/, to get the DMA buffer size. > > Accessing other processes=E2=80=99 fdinfo requires root privileges. This = limits > the use of the interface to debugging environments and is not suitable > for production builds. Granting root privileges even to a system process > increases the attack surface and is highly undesirable. > > This series proposes making the requirement to read fdinfo less strict > with PTRACE_MODE_READ. > Hi everyone, I will send v2 of this patch series. Please let me know if you have any other comments or feedback, that should be addressed in the new version. Thanks, Kalesh > Kalesh Singh (2): > procfs: Allow reading fdinfo with PTRACE_MODE_READ > dmabuf: Add dmabuf inode no to fdinfo > > drivers/dma-buf/dma-buf.c | 1 + > fs/proc/base.c | 4 ++-- > fs/proc/fd.c | 15 ++++++++++++++- > 3 files changed, 17 insertions(+), 3 deletions(-) > > -- > 2.30.0.365.g02bc693789-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MISSING_HEADERS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041A4C433E9 for ; Thu, 4 Feb 2021 08:33:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA95364F45 for ; Thu, 4 Feb 2021 08:33:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA95364F45 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 74A7F6ECFF; Thu, 4 Feb 2021 08:32:48 +0000 (UTC) Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96F006EBAC for ; Wed, 3 Feb 2021 20:49:40 +0000 (UTC) Received: by mail-pf1-x42a.google.com with SMTP id f63so580232pfa.13 for ; Wed, 03 Feb 2021 12:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc :content-transfer-encoding; bh=M8lFoGv6mHlkS4pfcEZxXT0GjlBrKSHlOVSDDjgilMk=; b=rM1xvLKChJbMhPiPxDWEcePASMy0cf8HeErbywGhn2uz/vxUt3AWciE3Uj63Z9rkey 3clwXdhoaZ9tcupljd+xCp/yiRwzX/ekcHuZsIbhXa17Qm+44qBkGfi0JFpr2BfLDeUP uL4Jo+ge5eJYzKr58jmA5TrlIeovIVSgJdXR6bfIIoYV+m7rgmaz3WLeyQzZxEEjpNnU UNyxblr37Vse2cJev1TBfQXLjVuw5otZVV5JNNT8jZRq/IIGsHa9JjamNNJP/gdZTaZo +iWKjsNqQHVX2hrRwm0Ki4jIyyS7RT2xYbuq6koIXVc5C5NFulhXVP9qaCbJ3Xt/zb+N PvcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc:content-transfer-encoding; bh=M8lFoGv6mHlkS4pfcEZxXT0GjlBrKSHlOVSDDjgilMk=; b=HLxlzrD8tghL3XVWsc/TVcHr9wBgHx+hoycxEddRM2fTLkDAoLqmWLP8I4JB856l1H O/mHbcOZUqdQgLTPneVFdyE0MNlBscSJ84TVVaix8GMtM9pknpzkZ3noze+Mo7THE+bm hkAhCs1A97iWBIU5HMe+NzkKqu8XPiwTovCyemlJBgQn6fr/uMtqvwp0A5bRJwkkQdZl xRL7llKy7MJlU7XxMBjJr3vquncDjkfBgOgktLQuMx+zhVc8jz0FCcEj4HHxhijaiImM Fi3/MwNFDTnepgstxmYK83r/8iIVWq2Iu/BhsBP42btfbWxcBsNz9Banrsk8aD+aU1hw C1vg== X-Gm-Message-State: AOAM530dKssSMShtSsWJJINT2AIAItZY+a2tewO4Ht4RperUuTvIio8C XGjH24iOS2u0GaAmz9WSx12yueJZ78is+1oZdge0Cg== X-Received: by 2002:aa7:910a:0:b029:1c8:9947:305c with SMTP id 10-20020aa7910a0000b02901c89947305cmt3620825pfh.75.1612385380012; Wed, 03 Feb 2021 12:49:40 -0800 (PST) MIME-Version: 1.0 References: <20210128182432.2216573-1-kaleshsingh@google.com> In-Reply-To: <20210128182432.2216573-1-kaleshsingh@google.com> From: Kalesh Singh Date: Wed, 3 Feb 2021 15:49:27 -0500 Message-ID: Subject: Re: [PATCH 0/2] Allow reading process DMA buf stats from fdinfo X-Mailman-Approved-At: Thu, 04 Feb 2021 08:32:37 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DRI mailing list , Andrei Vagin , Christian Brauner , Michel Lespinasse , Jeffrey Vander Stoep , Daniel Jordan , "Cc: Android Kernel" , Alexey Dobriyan , Linux Media Mailing List , Kees Cook , Jann Horn , "moderated list:DMA BUFFER SHARING FRAMEWORK" , linux-fsdevel , Bernd Edlinger , Suren Baghdasaryan , Alexey Gladkov , LKML , Minchan Kim , Yafang Shao , "Eric W. Biederman" , Hridya Valsaraju , Andrew Morton , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCBKYW4gMjgsIDIwMjEgYXQgMToyNCBQTSBLYWxlc2ggU2luZ2ggPGthbGVzaHNpbmdo QGdvb2dsZS5jb20+IHdyb3RlOgo+Cj4gQW5kcm9pZCBjYXB0dXJlcyBwZXItcHJvY2VzcyBzeXN0 ZW0gbWVtb3J5IHN0YXRlIHdoZW4gY2VydGFpbiBsb3cgbWVtb3J5Cj4gZXZlbnRzIChlLmcgYSBm b3JlZ3JvdW5kIGFwcCBraWxsKSBvY2N1ciwgdG8gaWRlbnRpZnkgcG90ZW50aWFsIG1lbW9yeQo+ IGhvZ2dlcnMuIEluIG9yZGVyIHRvIG1lYXN1cmUgaG93IG11Y2ggbWVtb3J5IGEgcHJvY2VzcyBh Y3R1YWxseSBjb25zdW1lcywKPiBpdCBpcyBuZWNlc3NhcnkgdG8gaW5jbHVkZSB0aGUgRE1BIGJ1 ZmZlciBzaXplcyBmb3IgdGhhdCBwcm9jZXNzIGluIHRoZQo+IG1lbW9yeSBhY2NvdW50aW5nLiBT aW5jZSB0aGUgaGFuZGxlIHRvIERNQSBidWZmZXJzIGFyZSByYXcgRkRzLCBpdCBpcwo+IGltcG9y dGFudCB0byBiZSBhYmxlIHRvIGlkZW50aWZ5IHdoaWNoIHByb2Nlc3NlcyBoYXZlIEZEIHJlZmVy ZW5jZXMgdG8KPiBhIERNQSBidWZmZXIuCj4KPiBDdXJyZW50bHksIERNQSBidWZmZXIgRkRzIGNh biBiZSBhY2NvdW50ZWQgdXNpbmcgL3Byb2MvPHBpZD4vZmQvKiBhbmQKPiAvcHJvYy88cGlkPi9m ZGluZm8gLS0gYm90aCBhcmUgb25seSByZWFkYWJsZSBieSB0aGUgcHJvY2VzcyBvd25lciwKPiBh cyBmb2xsb3dzOgo+ICAgMS4gRG8gYSByZWFkbGluayBvbiBlYWNoIEZELgo+ICAgMi4gSWYgdGhl IHRhcmdldCBwYXRoIGJlZ2lucyB3aXRoICIvZG1hYnVmIiwgdGhlbiB0aGUgRkQgaXMgYSBkbWFi dWYgRkQuCj4gICAzLiBzdGF0IHRoZSBmaWxlIHRvIGdldCB0aGUgZG1hYnVmIGlub2RlIG51bWJl ci4KPiAgIDQuIFJlYWQvIHByb2MvPHBpZD4vZmRpbmZvLzxmZD4sIHRvIGdldCB0aGUgRE1BIGJ1 ZmZlciBzaXplLgo+Cj4gQWNjZXNzaW5nIG90aGVyIHByb2Nlc3Nlc+KAmSBmZGluZm8gcmVxdWly ZXMgcm9vdCBwcml2aWxlZ2VzLiBUaGlzIGxpbWl0cwo+IHRoZSB1c2Ugb2YgdGhlIGludGVyZmFj ZSB0byBkZWJ1Z2dpbmcgZW52aXJvbm1lbnRzIGFuZCBpcyBub3Qgc3VpdGFibGUKPiBmb3IgcHJv ZHVjdGlvbiBidWlsZHMuICBHcmFudGluZyByb290IHByaXZpbGVnZXMgZXZlbiB0byBhIHN5c3Rl bSBwcm9jZXNzCj4gaW5jcmVhc2VzIHRoZSBhdHRhY2sgc3VyZmFjZSBhbmQgaXMgaGlnaGx5IHVu ZGVzaXJhYmxlLgo+Cj4gVGhpcyBzZXJpZXMgcHJvcG9zZXMgbWFraW5nIHRoZSByZXF1aXJlbWVu dCB0byByZWFkIGZkaW5mbyBsZXNzIHN0cmljdAo+IHdpdGggUFRSQUNFX01PREVfUkVBRC4KPgoK SGkgZXZlcnlvbmUsCgpJIHdpbGwgc2VuZCB2MiBvZiB0aGlzIHBhdGNoIHNlcmllcy4gUGxlYXNl IGxldCBtZSBrbm93IGlmIHlvdSBoYXZlCmFueSBvdGhlciBjb21tZW50cyBvciBmZWVkYmFjaywg dGhhdCBzaG91bGQgYmUgYWRkcmVzc2VkIGluIHRoZSBuZXcKdmVyc2lvbi4KClRoYW5rcywKS2Fs ZXNoCgo+IEthbGVzaCBTaW5naCAoMik6Cj4gICBwcm9jZnM6IEFsbG93IHJlYWRpbmcgZmRpbmZv IHdpdGggUFRSQUNFX01PREVfUkVBRAo+ICAgZG1hYnVmOiBBZGQgZG1hYnVmIGlub2RlIG5vIHRv IGZkaW5mbwo+Cj4gIGRyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMgfCAgMSArCj4gIGZzL3Byb2Mv YmFzZS5jICAgICAgICAgICAgfCAgNCArKy0tCj4gIGZzL3Byb2MvZmQuYyAgICAgICAgICAgICAg fCAxNSArKysrKysrKysrKysrKy0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCsp LCAzIGRlbGV0aW9ucygtKQo+Cj4gLS0KPiAyLjMwLjAuMzY1LmcwMmJjNjkzNzg5LWdvb2cKPgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK