From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B860C433B4 for ; Mon, 12 Apr 2021 18:38:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6380610C8 for ; Mon, 12 Apr 2021 18:38:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6380610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D7206B006C; Mon, 12 Apr 2021 14:38:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AC6E6B006E; Mon, 12 Apr 2021 14:38:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5744F6B0070; Mon, 12 Apr 2021 14:38:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 3B5EF6B006C for ; Mon, 12 Apr 2021 14:38:43 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EB7FA180ACF8B for ; Mon, 12 Apr 2021 18:38:42 +0000 (UTC) X-FDA: 78024576084.13.E9F0CC9 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf10.hostedemail.com (Postfix) with ESMTP id E05ED40002CF for ; Mon, 12 Apr 2021 18:38:37 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id e8-20020a17090a7288b029014e51f5a6baso2327546pjg.2 for ; Mon, 12 Apr 2021 11:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=znmXIW1/QJS0uTcg80n6f83PnFW9LOiw79fgKlUbw/4=; b=nts6sXBGb0eC1anG2BPaT0sd+dN2/tL6x72qAjDVVttCP9qy4xKob6Z64pSuwF9X1y ZpBEawHOoU+THK/WeH0tGhwmuPfSa1xfSEGtOrKaQQQRZPqSNFTOc1wpc+/Xt1h9DsLD 87ouFykHfcUHAimf/co9vcrbxaAg8/QE4/IE8QOPZn/V/PEBdQ2uIaItAbzgfa9jgx/+ OrSW9DG/DUNLnNnn3z3VFaKzgTM7abDB9zin/CgHCRSePQfCExNPXoNW50Zt+wvZ7SNt HNMAMkmM+JpcGao/wUbZujJHmgDB5qbjdghf2NYpEO0oVzGnRin8VtnPVEywUGtm9n1Q 19/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=znmXIW1/QJS0uTcg80n6f83PnFW9LOiw79fgKlUbw/4=; b=kKfG9FvmYIJPt+0pLAcx/sNAm0kP6vGP2UuFbrIqfiWZE+saTQ175TMEzzVt1krCCu xAqiJs7CieU+7ksKSWPjJL4/EHpZs7p1d4e4lhW38gNJXVEdmMS+aZ23ORiIvrPj26iv 6s11r5GBW/IZllOdqWEctU3SSyIMwTZFu67B1MklTZLJ6T/E7h/rC+oB6IJSYBxtgqZN XLzk86h7AYYZV0xoELJvVuxz7gSICibRRUiW+qmH8rlpS/ENsRCthVtzT3dX32rYnUqO ZAdKlU+7APUHJhZk6fUV+QbK51qg2hkZIKZO/aMO9MIQSjCPYsFCJ0m3tFdHgmJQvTfI OCzA== X-Gm-Message-State: AOAM5316i7hhTUSQdxModK1Nh7L/C1OVRouyTKjYcKdzZ1VlFClKOXQ4 Ayg9ZWQIPduajHuQGzFXm4g3UHJwgq0xqb1ImGs7WQ== X-Google-Smtp-Source: ABdhPJysusR/0ohykd080zxtz0L/gAQRVHtNW+nVOMELoEOreBYlWERdT7s5icQwW3t/Xk04rh8mVkDFh6B/pOQG3Zc= X-Received: by 2002:a17:90a:7d05:: with SMTP id g5mr572428pjl.114.1618252721322; Mon, 12 Apr 2021 11:38:41 -0700 (PDT) MIME-Version: 1.0 References: <20210330060752.592769-1-aneesh.kumar@linux.ibm.com> <20210330060752.592769-3-aneesh.kumar@linux.ibm.com> In-Reply-To: <20210330060752.592769-3-aneesh.kumar@linux.ibm.com> From: Kalesh Singh Date: Mon, 12 Apr 2021 11:38:30 -0700 Message-ID: Subject: Re: [PATCH v3 2/9] selftest/mremap_test: Avoid crash with static build To: "Aneesh Kumar K.V" Cc: "open list:MEMORY MANAGEMENT" , Andrew Morton , mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, joel@joelfernandes.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E05ED40002CF X-Stat-Signature: zjhg8cox11d3fppsimmtfy85gc6fnydt Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mail-pj1-f46.google.com; client-ip=209.85.216.46 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618252717-883225 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 29, 2021 at 11:08 PM Aneesh Kumar K.V wrote: > > With a large mmap map size, we can overlap with the text area and using > MAP_FIXED results in unmapping that area. Switch to MAP_FIXED_NOREPLACE > and handle the EEXIST error. > > Signed-off-by: Aneesh Kumar K.V Reviewed-by: Kalesh Singh > --- > tools/testing/selftests/vm/mremap_test.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/vm/mremap_test.c b/tools/testing/selftests/vm/mremap_test.c > index c9a5461eb786..0624d1bd71b5 100644 > --- a/tools/testing/selftests/vm/mremap_test.c > +++ b/tools/testing/selftests/vm/mremap_test.c > @@ -75,9 +75,10 @@ static void *get_source_mapping(struct config c) > retry: > addr += c.src_alignment; > src_addr = mmap((void *) addr, c.region_size, PROT_READ | PROT_WRITE, > - MAP_FIXED | MAP_ANONYMOUS | MAP_SHARED, -1, 0); > + MAP_FIXED_NOREPLACE | MAP_ANONYMOUS | MAP_SHARED, > + -1, 0); > if (src_addr == MAP_FAILED) { > - if (errno == EPERM) > + if (errno == EPERM || errno == EEXIST) > goto retry; > goto error; > } > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA6B0C433ED for ; Mon, 12 Apr 2021 22:03:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51A0D61220 for ; Mon, 12 Apr 2021 22:03:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51A0D61220 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FK2n46s29z3cb8 for ; Tue, 13 Apr 2021 08:03:36 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=nts6sXBG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::102e; helo=mail-pj1-x102e.google.com; envelope-from=kaleshsingh@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=nts6sXBG; dkim-atps=neutral Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FJyDh6BTdz30G6 for ; Tue, 13 Apr 2021 04:38:44 +1000 (AEST) Received: by mail-pj1-x102e.google.com with SMTP id il9-20020a17090b1649b0290114bcb0d6c2so9372378pjb.0 for ; Mon, 12 Apr 2021 11:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=znmXIW1/QJS0uTcg80n6f83PnFW9LOiw79fgKlUbw/4=; b=nts6sXBGb0eC1anG2BPaT0sd+dN2/tL6x72qAjDVVttCP9qy4xKob6Z64pSuwF9X1y ZpBEawHOoU+THK/WeH0tGhwmuPfSa1xfSEGtOrKaQQQRZPqSNFTOc1wpc+/Xt1h9DsLD 87ouFykHfcUHAimf/co9vcrbxaAg8/QE4/IE8QOPZn/V/PEBdQ2uIaItAbzgfa9jgx/+ OrSW9DG/DUNLnNnn3z3VFaKzgTM7abDB9zin/CgHCRSePQfCExNPXoNW50Zt+wvZ7SNt HNMAMkmM+JpcGao/wUbZujJHmgDB5qbjdghf2NYpEO0oVzGnRin8VtnPVEywUGtm9n1Q 19/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=znmXIW1/QJS0uTcg80n6f83PnFW9LOiw79fgKlUbw/4=; b=TZJ/1jtOKkS6bbX7+A0RHPL8tGbZEg+z97GWr0OivQsf+dkljgreQlI+u9uZWLUUNV 8Vu5jSNQ+m2ejFSrTODosxfdxom4+X03vw+Hs0tZZd0qdheTM2ceZBTgKmPwfq35GO86 DpLYSVEoppqDwsNeVFlZQVFOcIGDUPcHY9EnNAprSLngIFOm8s3mLHvZ2uTINr6XwNWM MUtSpkTA3hSWB2mNqDljB+lALW9oCk23nSoYTCRhReTu7/Enu7OHK1YN3+4JlMs3nek3 oGQCFEu47rXyuNYmSDOTKhGZb2NJTdDDuhCWs/zvZdrdl+yPl2u87/bOVHDhgB1COA+3 yKhw== X-Gm-Message-State: AOAM531QkbUDDwqQfFziUKE12qaHGBS+0YyzsbOHsJVQPKnABNfJcH7V jqLmNg7ykOf8n8LVDBfiaCn0GWcIB/hJwd882FO7jg== X-Google-Smtp-Source: ABdhPJysusR/0ohykd080zxtz0L/gAQRVHtNW+nVOMELoEOreBYlWERdT7s5icQwW3t/Xk04rh8mVkDFh6B/pOQG3Zc= X-Received: by 2002:a17:90a:7d05:: with SMTP id g5mr572428pjl.114.1618252721322; Mon, 12 Apr 2021 11:38:41 -0700 (PDT) MIME-Version: 1.0 References: <20210330060752.592769-1-aneesh.kumar@linux.ibm.com> <20210330060752.592769-3-aneesh.kumar@linux.ibm.com> In-Reply-To: <20210330060752.592769-3-aneesh.kumar@linux.ibm.com> From: Kalesh Singh Date: Mon, 12 Apr 2021 11:38:30 -0700 Message-ID: Subject: Re: [PATCH v3 2/9] selftest/mremap_test: Avoid crash with static build To: "Aneesh Kumar K.V" Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Tue, 13 Apr 2021 08:01:23 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: npiggin@gmail.com, "open list:MEMORY MANAGEMENT" , joel@joelfernandes.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 29, 2021 at 11:08 PM Aneesh Kumar K.V wrote: > > With a large mmap map size, we can overlap with the text area and using > MAP_FIXED results in unmapping that area. Switch to MAP_FIXED_NOREPLACE > and handle the EEXIST error. > > Signed-off-by: Aneesh Kumar K.V Reviewed-by: Kalesh Singh > --- > tools/testing/selftests/vm/mremap_test.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/vm/mremap_test.c b/tools/testing/selftests/vm/mremap_test.c > index c9a5461eb786..0624d1bd71b5 100644 > --- a/tools/testing/selftests/vm/mremap_test.c > +++ b/tools/testing/selftests/vm/mremap_test.c > @@ -75,9 +75,10 @@ static void *get_source_mapping(struct config c) > retry: > addr += c.src_alignment; > src_addr = mmap((void *) addr, c.region_size, PROT_READ | PROT_WRITE, > - MAP_FIXED | MAP_ANONYMOUS | MAP_SHARED, -1, 0); > + MAP_FIXED_NOREPLACE | MAP_ANONYMOUS | MAP_SHARED, > + -1, 0); > if (src_addr == MAP_FAILED) { > - if (errno == EPERM) > + if (errno == EPERM || errno == EEXIST) > goto retry; > goto error; > } > -- > 2.30.2 >