From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24162C433EF for ; Tue, 26 Oct 2021 23:36:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0918960F56 for ; Tue, 26 Oct 2021 23:36:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240312AbhJZXip (ORCPT ); Tue, 26 Oct 2021 19:38:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240305AbhJZXij (ORCPT ); Tue, 26 Oct 2021 19:38:39 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 078C1C061767 for ; Tue, 26 Oct 2021 16:36:15 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id m26so958018pff.3 for ; Tue, 26 Oct 2021 16:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8d3uWZxdzrBP+vl4m4KBl847bLF2nEq/HOn/R3ceq4w=; b=Q5NrgZhN893Ji62/KpmU/s0XihJoVAvCozwZOXxNA4AKKViVxUf+8II1xWXtP15i8d m/fNJct7ZYeWG58YA7zBxktPNBkec4UanJR5DkRKzhaR7p20AurOtNWSb/6uFc70+zEr lQCmhKaQFpOZTA6eGph8FeUYie1nxSyTAiLUTe+MMiP42Q80EcSSXWz3sSiJQN5CQHrW IdYNPLvRxvN2NllMXSACf0aB2tFPRv5QbwkLGfaz9q/0QP4fFamyMFcSJ0zcV3ivAFig WR8riosRBoWk0urCGnzlaeeEpw3UKDMEwdCJ5A1VmVJTqBVwpgUtiKlfHzAAhELhvHAj TbiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8d3uWZxdzrBP+vl4m4KBl847bLF2nEq/HOn/R3ceq4w=; b=zGjG6rDTXGz4r+9ThOCxFCOAr4qpZ6GQRCt4DfsGGr3eK622HC0nM9A39xk+uqCXg+ 9KkuIdLj5vBdScqECmrhItBPL/kS5Qr+LdfeK358Ohn1tqgCv2zl6ZnFHBEEqhfcdf9d QT0+vvN87dteOcrkmkYN8MxfSqSKROlKG0hAv1axedWpXBDvDT7vCSupdTWdqPuwbKQ9 1u9knjUJZZBSIw9m8TP4pro7k1ysZMbBFCIEs82G5lYdS5pLYr2Hhl54R47T0j9E8SQM /YRcDDSAlH40SnDu9xOaukDgGV/66mmScKIWUAnwPPMBf0RIsx4mcwx2GjfYxJ/ftTM6 lpXw== X-Gm-Message-State: AOAM533kjWVX3G4RQdEjQ1U958WlomBe7sbINmu/bZsO29DYWLnJJDW2 y5C1zQoAqOmG4sGkyWreoJ8M/+dRVInsk/ABH5q8Cw== X-Google-Smtp-Source: ABdhPJw9UniSPiWvgzo1wCS2HEoxo1G7FE93fhG5GNjDmDm0dk4ZhL9/ul4eF2JYrMPDF/5k1zAn2lyu2xBglACK8IU= X-Received: by 2002:aa7:8246:0:b0:44b:4870:1b09 with SMTP id e6-20020aa78246000000b0044b48701b09mr29659821pfn.82.1635291374309; Tue, 26 Oct 2021 16:36:14 -0700 (PDT) MIME-Version: 1.0 References: <20211025200852.3002369-1-kaleshsingh@google.com> <20211025200852.3002369-8-kaleshsingh@google.com> <20211026214311.583c728d90d41778c38201dd@kernel.org> <20211026174420.0056bde2@gandalf.local.home> In-Reply-To: <20211026174420.0056bde2@gandalf.local.home> From: Kalesh Singh Date: Tue, 26 Oct 2021 16:36:03 -0700 Message-ID: Subject: Re: [PATCH v4 7/8] tracing/selftests: Add tests for hist trigger expression parsing To: Steven Rostedt Cc: Masami Hiramatsu , surenb@google.com, hridya@google.com, namhyung@kernel.org, kernel-team@android.com, Jonathan Corbet , Ingo Molnar , Shuah Khan , Tom Zanussi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 26, 2021 at 2:44 PM Steven Rostedt wrote: > > On Tue, 26 Oct 2021 07:28:39 -0700 > Kalesh Singh wrote: > > > > If this update has any meaning, please make a separate patch for this part. > > > > Hi Masami, > > > > Thanks for the feedback. The above change is to ensure we remove > > triggers in the reverse order that we created them - important when > > one trigger depends on another. I can split it out into a separate > > patch and will add a README pattern check to the requires tag for > > these tests. > > Also make sure to run all the ftracetests. When I ran it with this update, > most of the other histogram tests failed. Even with your patches applied to > the running kernel. Hi Steve, On my setup I without any of the changes applied (config hist triggers enabled): ./ftracetests # of passed: 41 # of failed: 40 # of unresolved: 0 # of untested: 0 # of unsupported: 32 # of xfailed: 0 # of undefined(test bug): 0 Do all the tests pass for you, before any of the changes in this series? Maybe some of the tests need updating? - Kalesh > > -- Steve