From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C04C433EF for ; Mon, 27 Jun 2022 16:32:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239307AbiF0Qcz (ORCPT ); Mon, 27 Jun 2022 12:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239401AbiF0Qco (ORCPT ); Mon, 27 Jun 2022 12:32:44 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D994B7C2 for ; Mon, 27 Jun 2022 09:32:43 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id f190so5488445wma.5 for ; Mon, 27 Jun 2022 09:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3jWqe5eCEvfhJ7SMk4jmfVBzaJ6AjX6eIUnqn4WhHcw=; b=XVc9E0UydcgtLVpzee18YUE9wICJ2T/ZGKJI2aIKDSZ0FG2od9hCMeDuQ04H0LHste EMlYDFtHmqQHE5QTJzqXpgfexBrPEb8s/gNrhGLcVlknqbf5WVjUoLqoF4/auGb1d2pp KvCmBZx6+xHU2kGHRslJarja7ML5hE8qjc9vYEWtYm6gDaLMyKKY/CNS1qDDYMmNrf2q eJGzNf6Kt2xl35zFybppKqqjGgCbEToH9xB5OnUM9RQIoqOID+E6UxNMgQJxGaGbAiK+ A9lg9ufuLtyP3v79JJ+7OzMGSKg+ItpegL4oXNOvBdIBkW74CZhBWA2w3qXGGoNk6Q2Y GrXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3jWqe5eCEvfhJ7SMk4jmfVBzaJ6AjX6eIUnqn4WhHcw=; b=n9B7EMO36cxxLYpcDqzLvS6uB5xBoKjuzykS3YXSVMGu4Zy7uFJdltYJo4r7l4f6of mQbVl76Rd6crQU7PiioG2jTHWq4zVfxUckB8iIi1LSxDRoyuzeUKB1JtOHGku1OOBbjm ES5eFn8V9dKxW55QadUsql6K+iaOseM0VMoy3CjVqcTwRyd0qLvSnMExyHjjqGQY41jo /3pJ8Y8/BP4LIzy1uU8paHpHjUjV4/y0xbMZtkevDAA29oPujmoQDzMhrfCVy5xlBDcZ WN0ublkzmVrhbCJLFTn51Tqnjm+W2RvBCfZ7vpVvzjWTrUjwlU/hdFrkhNNIdmZnbJI7 aDGg== X-Gm-Message-State: AJIora/295zuf/fbRhWMSp4+p93FlkS6ppFB9rcz4NraMo2wOFbB0EDB 3tRWDC2b8J3dUIaWFQHCB0Tels9QrzqBZpJBTouxkw== X-Google-Smtp-Source: AGRyM1t48nYJVTT2qNAqd3qaLOiynSoa4TcaU+Vs4a6qOvjq1erfTLSCVvuvbMMR2hkQh4b41MolwKgSaJZvfs85Jjs= X-Received: by 2002:a05:600c:4081:b0:3a0:47c4:8dd0 with SMTP id k1-20020a05600c408100b003a047c48dd0mr9768995wmh.178.1656347561570; Mon, 27 Jun 2022 09:32:41 -0700 (PDT) MIME-Version: 1.0 References: <20220617210717.27126-1-madvenka@linux.microsoft.com> <20220623173224.GB16966@willie-the-truck> <66545c21-cfcf-60eb-4acf-39be99520369@linux.microsoft.com> In-Reply-To: From: Kalesh Singh Date: Mon, 27 Jun 2022 09:32:30 -0700 Message-ID: Subject: Re: [PATCH v15 0/6] arm64: Reorganize the unwinder and implement stack trace reliability checks To: "Madhavan T. Venkataraman" Cc: Mark Rutland , Will Deacon , Mark Brown , Josh Poimboeuf , Ard Biesheuvel , nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, Catalin Marinas , James Morris , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , live-patching@vger.kernel.org, LKML , Marc Zyngier Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 26, 2022 at 9:33 PM Madhavan T. Venkataraman wrote: > > > > On 6/26/22 04:18, Mark Rutland wrote: > > On Fri, Jun 24, 2022 at 12:19:01AM -0500, Madhavan T. Venkataraman wrote: > >> > >> > >> On 6/23/22 12:32, Will Deacon wrote: > >>> On Fri, Jun 17, 2022 at 04:07:11PM -0500, madvenka@linux.microsoft.com wrote: > >>>> From: "Madhavan T. Venkataraman" > >>>> > >>>> I have synced this patch series to v5.19-rc2. > >>>> I have also removed the following patch. > >>>> > >>>> [PATCH v14 7/7] arm64: Select HAVE_RELIABLE_STACKTRACE > >>>> > >>>> as HAVE_RELIABLE_STACKTRACE depends on STACK_VALIDATION which is not present > >>>> yet. This patch will be added in the future once Objtool is enhanced to > >>>> provide stack validation in some form. > >>> > >>> Given that it's not at all obvious that we're going to end up using objtool > >>> for arm64, does this patch series gain us anything in isolation? > >>> > >> > >> BTW, I have synced my patchset to 5.19-rc2 and sent it as v15. > >> > >> So, to answer your question, patches 1 thru 3 in v15 are still useful even if we don't > >> consider reliable stacktrace. These patches reorganize the unwinder code based on > >> comments from both Mark Rutland and Mark Brown. Mark Brown has already OKed them. > >> If Mark Rutland OKes them, we should upstream them. > > > > Sorry for the delay; I have been rather swamped recently and haven't had the > > time to give this the time it needs. > > > > I'm happy with patches 1 and 2, and I've acked those in case Will wants to pick > > them. > > > > Kalesh (cc'd) is working to share the unwinder code with hyp, and I think that > > we need to take a step back and consider how we can make the design work > > cleanly with that. I'd had a go at prototyping making the unwinder more data > > driven, but I haven't come up with something satisfactory so far. > > > > It would be good if you could look at / comment on each others series. > > > > I will review Kalesh's unwinder changes. Thanks Mark, I'll take a look. Madhavan, I'm in the process of preparing a new version. Let me rebase on your first 2 patches and resend, so you can look at that version instead. Thanks, Kalesh > > Thanks. > > Madhavan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B258BC433EF for ; Mon, 27 Jun 2022 16:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BE4zLXEXeUUQqn6lX9USFJzjohZc/Ccc0v6M8vUTN90=; b=edBLgTaPix8JUx BURqLwrp2rxy1AB+dlZPb5ykOgCQSarur9U+YXGytlPB6Ga1/G8k29MDJZ1Ll3c2EuYGI68Tfshio F1pBO4Dbsc077TMqTZFRn+T9zafM7mEdLiIAj6lPSO5AqvQaaaaJZ051uxeexKPw5/x6opz+Rsvhi kEdCnnBKlReN2kP+08f7pjLz3iEVdYGAVf0jZmOWCdZlTWUsVmpIx7cjNqgNxZlH4DOdTlzcpfBKq vozoeyfpLs033oR+mAbru1nc5K/vtiFI2TSrpx82hYp8gpP6NqdS227lrJ5U0QVM3a6dlgnsU/39p NLS0mm3tGW8mu8+GinJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5rfQ-001r7Z-QA; Mon, 27 Jun 2022 16:32:53 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5rfL-001r3l-8l for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 16:32:49 +0000 Received: by mail-wm1-x331.google.com with SMTP id n185so5758584wmn.4 for ; Mon, 27 Jun 2022 09:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3jWqe5eCEvfhJ7SMk4jmfVBzaJ6AjX6eIUnqn4WhHcw=; b=XVc9E0UydcgtLVpzee18YUE9wICJ2T/ZGKJI2aIKDSZ0FG2od9hCMeDuQ04H0LHste EMlYDFtHmqQHE5QTJzqXpgfexBrPEb8s/gNrhGLcVlknqbf5WVjUoLqoF4/auGb1d2pp KvCmBZx6+xHU2kGHRslJarja7ML5hE8qjc9vYEWtYm6gDaLMyKKY/CNS1qDDYMmNrf2q eJGzNf6Kt2xl35zFybppKqqjGgCbEToH9xB5OnUM9RQIoqOID+E6UxNMgQJxGaGbAiK+ A9lg9ufuLtyP3v79JJ+7OzMGSKg+ItpegL4oXNOvBdIBkW74CZhBWA2w3qXGGoNk6Q2Y GrXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3jWqe5eCEvfhJ7SMk4jmfVBzaJ6AjX6eIUnqn4WhHcw=; b=iqVLz0VoO3IaLL3Qc7ZtwLkijM2maHHb2NYJ+VLnWAt+EojW23RaWIYekCFYTemcz3 HqJ1Z10Zi3zNKItljKYsGD/5dezYgNt10bOLEK12w3Q7vNpkERVHP91nyKGlzly1Z/03 jKkco2+t28pbpPVmJQ3RdMvJJbvhr7H7k5/Mv5OljGnytpVUFGlgffF5Yov1qpRx2Luu gWQRBb1s3vIlIFxmwLEvLvpVREJdXFSlRWrlRXdtrUuvYaO5u285GhO8jY0o3H5DU8Jb E2+lO2Qd8yM0WaVr4PSP4RdTJXTVdx3Q/+qSRxzAbiyvXpQez8KpZI2LKYIoPTz2nvd/ cPyw== X-Gm-Message-State: AJIora8lwVCYmU4BhTkoQN7pK2eMbs5pqWXrG8Xd61LSgD7EmPsYi1An 8KB1v2cISlZuEHDQACL4cX6Ks+LJvvTrx3U+VB+WeQ== X-Google-Smtp-Source: AGRyM1t48nYJVTT2qNAqd3qaLOiynSoa4TcaU+Vs4a6qOvjq1erfTLSCVvuvbMMR2hkQh4b41MolwKgSaJZvfs85Jjs= X-Received: by 2002:a05:600c:4081:b0:3a0:47c4:8dd0 with SMTP id k1-20020a05600c408100b003a047c48dd0mr9768995wmh.178.1656347561570; Mon, 27 Jun 2022 09:32:41 -0700 (PDT) MIME-Version: 1.0 References: <20220617210717.27126-1-madvenka@linux.microsoft.com> <20220623173224.GB16966@willie-the-truck> <66545c21-cfcf-60eb-4acf-39be99520369@linux.microsoft.com> In-Reply-To: From: Kalesh Singh Date: Mon, 27 Jun 2022 09:32:30 -0700 Message-ID: Subject: Re: [PATCH v15 0/6] arm64: Reorganize the unwinder and implement stack trace reliability checks To: "Madhavan T. Venkataraman" Cc: Mark Rutland , Will Deacon , Mark Brown , Josh Poimboeuf , Ard Biesheuvel , nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, Catalin Marinas , James Morris , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , live-patching@vger.kernel.org, LKML , Marc Zyngier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_093247_361306_995CDEE3 X-CRM114-Status: GOOD ( 31.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jun 26, 2022 at 9:33 PM Madhavan T. Venkataraman wrote: > > > > On 6/26/22 04:18, Mark Rutland wrote: > > On Fri, Jun 24, 2022 at 12:19:01AM -0500, Madhavan T. Venkataraman wrote: > >> > >> > >> On 6/23/22 12:32, Will Deacon wrote: > >>> On Fri, Jun 17, 2022 at 04:07:11PM -0500, madvenka@linux.microsoft.com wrote: > >>>> From: "Madhavan T. Venkataraman" > >>>> > >>>> I have synced this patch series to v5.19-rc2. > >>>> I have also removed the following patch. > >>>> > >>>> [PATCH v14 7/7] arm64: Select HAVE_RELIABLE_STACKTRACE > >>>> > >>>> as HAVE_RELIABLE_STACKTRACE depends on STACK_VALIDATION which is not present > >>>> yet. This patch will be added in the future once Objtool is enhanced to > >>>> provide stack validation in some form. > >>> > >>> Given that it's not at all obvious that we're going to end up using objtool > >>> for arm64, does this patch series gain us anything in isolation? > >>> > >> > >> BTW, I have synced my patchset to 5.19-rc2 and sent it as v15. > >> > >> So, to answer your question, patches 1 thru 3 in v15 are still useful even if we don't > >> consider reliable stacktrace. These patches reorganize the unwinder code based on > >> comments from both Mark Rutland and Mark Brown. Mark Brown has already OKed them. > >> If Mark Rutland OKes them, we should upstream them. > > > > Sorry for the delay; I have been rather swamped recently and haven't had the > > time to give this the time it needs. > > > > I'm happy with patches 1 and 2, and I've acked those in case Will wants to pick > > them. > > > > Kalesh (cc'd) is working to share the unwinder code with hyp, and I think that > > we need to take a step back and consider how we can make the design work > > cleanly with that. I'd had a go at prototyping making the unwinder more data > > driven, but I haven't come up with something satisfactory so far. > > > > It would be good if you could look at / comment on each others series. > > > > I will review Kalesh's unwinder changes. Thanks Mark, I'll take a look. Madhavan, I'm in the process of preparing a new version. Let me rebase on your first 2 patches and resend, so you can look at that version instead. Thanks, Kalesh > > Thanks. > > Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel