From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F94EC433EF for ; Fri, 29 Apr 2022 16:26:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379062AbiD2Q31 (ORCPT ); Fri, 29 Apr 2022 12:29:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379061AbiD2Q3S (ORCPT ); Fri, 29 Apr 2022 12:29:18 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49EE4D5578 for ; Fri, 29 Apr 2022 09:25:59 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id 125-20020a1c1983000000b003941f354c62so1251431wmz.0 for ; Fri, 29 Apr 2022 09:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U7GwZfxNxCr20dXvniV2zLTxrd1PMEcbQZAO6v8SYLo=; b=D7hRSRGysLF6b/+lZGfGwGJW36LZtjnuaVsdT5g70KMJgcqMMC+FEhfKVUsaq/1da7 IIbDQ1woP6gkqB9YFFVt2Z1ekn7gRvOn9m2dz899A2gF6FBaNoF1biSy4iaquXh+4IUI xntEIqq+rBOCXSEXbyXmRDWy5DyPF+oOtEp/tojXXdC7ZGUPgtjmAO4F67MHFK+pFHeC HyHxG3Xm7Kn0NTU2juRmrQhnIzj4auuTvurfUW7+ntOkSEzMWmLm6nRn/linRhkY58ae ouvIrvB+0vzZ6/h+haYPYB9L3MeD9Z6QO4u+RuQmqgtb/2egseSjMnCQAh+JCe3q1Iez W0FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U7GwZfxNxCr20dXvniV2zLTxrd1PMEcbQZAO6v8SYLo=; b=hdZe0GjD6BL7w/Jk3SGXYakjFjePVcKZjSWOzv+z1m/IqXuWe/LDnp+orIFo0i4RdL BZ3EH3nliAdDZyC9qB/L3Jg0rMwEx56l7pQSH+S5aRyy9062zH1u3Pqc4pNeaYvkZhzs gPrzqClXRVYqF137FgyjFNUne8wPkq2a7gTL0+IiMYYB7F1cTNU2o5WU9dquOYof9NUO kvHgMa4HlVu0XEQ3HPReuBNJkABMSWjIDHT78LGtjFbg1GVB4RvJd+ZOd3kNb0H8cYqi Cm5IIZYLcihRDsfxMSUylxU2bvYGE2oT1ZObgKKD/Q+f+qjp0vwD1SVcWyklop1ANRwk IfIA== X-Gm-Message-State: AOAM532kB2sa9DvYpl8Glm93IxiDytSou9IDB4KBJHFpEf6Q1s4SI4+7 2B3wtaV+6SH8fSCSos+5Ld/7tSv3aomczm3ziw9L4Q== X-Google-Smtp-Source: ABdhPJxhLzTgLf/Ks/AB0pes6BWh4ozeKIdS874CsMwC+xluHukgX/fubue2dWWqxRl4fMNT+Iw0yiN5ImWbON3APeU= X-Received: by 2002:a05:600c:4f93:b0:393:f08d:a048 with SMTP id n19-20020a05600c4f9300b00393f08da048mr4023212wmq.158.1651249557596; Fri, 29 Apr 2022 09:25:57 -0700 (PDT) MIME-Version: 1.0 References: <20220427184716.1949239-1-kaleshsingh@google.com> <20220427184716.1949239-2-kaleshsingh@google.com> In-Reply-To: From: Kalesh Singh Date: Fri, 29 Apr 2022 09:25:46 -0700 Message-ID: Subject: Re: [PATCH 1/4] KVM: arm64: Compile stacktrace.nvhe.o To: Mark Brown Cc: Mark Rutland , Will Deacon , Marc Zyngier , Quentin Perret , Fuad Tabba , Suren Baghdasaryan , "Cc: Android Kernel" , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Masami Hiramatsu , Peter Collingbourne , Alexei Starovoitov , "Madhavan T. Venkataraman" , Andrew Jones , Zenghui Yu , Keir Fraser , Kefeng Wang , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , kvmarm , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 5:47 AM Mark Brown wrote: > > On Wed, Apr 27, 2022 at 11:46:56AM -0700, Kalesh Singh wrote: > > > Recompile stack unwinding code for use with the nVHE hypervisor. This is > > a preparatory patch that will allow reusing most of the kernel unwinding > > logic in the nVHE hypervisor. > > This is substantially more than just the build change that the changelog > would seem to indicate... it would I think be clearer to split this up > further with the code changes separated out and explained a bit more. > It's not just recompling the code for nVHE, there's also refactoring to > split out changes that don't apply in nVHE hypervisor like all the task > related code which is needed but not mentioned in the changlog at all. > Possibly a patch or two for the code motion then a separate patch for > the ifdefs and build changes? Hi Mark, Thank you for reviewing. I agree - will split this into more incremental patches in the next version. Thanks, Kalesh > > I *think* the code is all fine but I'd need to go through it a few more > times to be sure I didn't miss anything. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21459C4332F for ; Fri, 29 Apr 2022 16:26:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 896824B241; Fri, 29 Apr 2022 12:26:02 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EZck5FQsxy7Z; Fri, 29 Apr 2022 12:26:01 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 870B44A014; Fri, 29 Apr 2022 12:26:01 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0B68F49E39 for ; Fri, 29 Apr 2022 12:26:00 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r77-cZbYt3Ki for ; Fri, 29 Apr 2022 12:25:59 -0400 (EDT) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id EC1C54966F for ; Fri, 29 Apr 2022 12:25:58 -0400 (EDT) Received: by mail-wm1-f42.google.com with SMTP id c190-20020a1c35c7000000b0038e37907b5bso7364019wma.0 for ; Fri, 29 Apr 2022 09:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U7GwZfxNxCr20dXvniV2zLTxrd1PMEcbQZAO6v8SYLo=; b=D7hRSRGysLF6b/+lZGfGwGJW36LZtjnuaVsdT5g70KMJgcqMMC+FEhfKVUsaq/1da7 IIbDQ1woP6gkqB9YFFVt2Z1ekn7gRvOn9m2dz899A2gF6FBaNoF1biSy4iaquXh+4IUI xntEIqq+rBOCXSEXbyXmRDWy5DyPF+oOtEp/tojXXdC7ZGUPgtjmAO4F67MHFK+pFHeC HyHxG3Xm7Kn0NTU2juRmrQhnIzj4auuTvurfUW7+ntOkSEzMWmLm6nRn/linRhkY58ae ouvIrvB+0vzZ6/h+haYPYB9L3MeD9Z6QO4u+RuQmqgtb/2egseSjMnCQAh+JCe3q1Iez W0FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U7GwZfxNxCr20dXvniV2zLTxrd1PMEcbQZAO6v8SYLo=; b=HZKfCjyxND1uY9gAsAnN6qXH2mZ8Wmpjvuu+2ALdIcsnRLKW/baUypjD7ayIuQtHQu 6yKMFFHgBLCJCKZ+mqcn7xFw5S8CIjwDDCo5LlYb7LY3lkpBdXvaHbn6RT5uCV4nnvKI AblzNhaLwYhrrhgeN7jjKr1Ay/2IDq8LC+lk0bKiAhwvay7n+1yrIlh83UcYgxOeh+lq 3+ZfCOTx6GsUXGJ9LdjJ8giqEvHLsyJp4QGdMmrdaWwAY3vwgxDROcCovT7BFQAi7+BK qF0Itwl3IMvF2FR0ujWXuZxPZdGhqwSPCB8UkC9p1RPuTSSDz2hIOaCO/hoUpTEFde/v H75g== X-Gm-Message-State: AOAM530M5qzewScwFDmieKsRjSuoHYwkh+PBsV1NFOEQoucKAeSvYxYk 8224cp305PyKd/LUUAVPG77BhSAZrAQeJJHRNsz7wA== X-Google-Smtp-Source: ABdhPJxhLzTgLf/Ks/AB0pes6BWh4ozeKIdS874CsMwC+xluHukgX/fubue2dWWqxRl4fMNT+Iw0yiN5ImWbON3APeU= X-Received: by 2002:a05:600c:4f93:b0:393:f08d:a048 with SMTP id n19-20020a05600c4f9300b00393f08da048mr4023212wmq.158.1651249557596; Fri, 29 Apr 2022 09:25:57 -0700 (PDT) MIME-Version: 1.0 References: <20220427184716.1949239-1-kaleshsingh@google.com> <20220427184716.1949239-2-kaleshsingh@google.com> In-Reply-To: From: Kalesh Singh Date: Fri, 29 Apr 2022 09:25:46 -0700 Message-ID: Subject: Re: [PATCH 1/4] KVM: arm64: Compile stacktrace.nvhe.o To: Mark Brown Cc: Kefeng Wang , Catalin Marinas , Alexei Starovoitov , Will Deacon , kvmarm , Marc Zyngier , "Madhavan T. Venkataraman" , "moderated list:ARM64 PORT \(AARCH64 ARCHITECTURE\)" , "Cc: Android Kernel" , Suren Baghdasaryan , Peter Collingbourne , LKML , Masami Hiramatsu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Apr 29, 2022 at 5:47 AM Mark Brown wrote: > > On Wed, Apr 27, 2022 at 11:46:56AM -0700, Kalesh Singh wrote: > > > Recompile stack unwinding code for use with the nVHE hypervisor. This is > > a preparatory patch that will allow reusing most of the kernel unwinding > > logic in the nVHE hypervisor. > > This is substantially more than just the build change that the changelog > would seem to indicate... it would I think be clearer to split this up > further with the code changes separated out and explained a bit more. > It's not just recompling the code for nVHE, there's also refactoring to > split out changes that don't apply in nVHE hypervisor like all the task > related code which is needed but not mentioned in the changlog at all. > Possibly a patch or two for the code motion then a separate patch for > the ifdefs and build changes? Hi Mark, Thank you for reviewing. I agree - will split this into more incremental patches in the next version. Thanks, Kalesh > > I *think* the code is all fine but I'd need to go through it a few more > times to be sure I didn't miss anything. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 459C0C433EF for ; Fri, 29 Apr 2022 16:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uTMaph4+K93iBhO7S3OaTa6MmjTHN9K08wVJcc4+tUw=; b=4g3QT8CxBSna63 4bPSeuPAYeDLzKd7GJbqomewr7udUR/Mbr+mtB+1FgiNWiaI8AE9q5DVa7NoGfoXMFmNQA4NMLB3r M2TdVlxNh4yt1imVnBSrMKWQB3ikYGbmUcC9AyhCC2S/v+th1VCTvjmFA7k1xyIvnOGPX6L7axa1a sYB1C6sxl3h7Frty6TIeROpL3BFsXcK5FSV+9lvsIBOIG+/eYQzOO7Pbh64nDo4vDxvRuEBpRpWDu cXwv9T2ZsWmPRU3zX3bt5yZA6bQyQcG6VSCGJeDiUZjqVpmXq9vVVg/75uf5Io/fQBh3meUWnnplr olwI/HFU7bOsFC+fdOPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkTRW-00BxdL-K4; Fri, 29 Apr 2022 16:26:06 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkTRU-00BxbZ-01 for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 16:26:05 +0000 Received: by mail-wm1-x329.google.com with SMTP id o12-20020a1c4d0c000000b00393fbe2973dso6393437wmh.2 for ; Fri, 29 Apr 2022 09:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U7GwZfxNxCr20dXvniV2zLTxrd1PMEcbQZAO6v8SYLo=; b=D7hRSRGysLF6b/+lZGfGwGJW36LZtjnuaVsdT5g70KMJgcqMMC+FEhfKVUsaq/1da7 IIbDQ1woP6gkqB9YFFVt2Z1ekn7gRvOn9m2dz899A2gF6FBaNoF1biSy4iaquXh+4IUI xntEIqq+rBOCXSEXbyXmRDWy5DyPF+oOtEp/tojXXdC7ZGUPgtjmAO4F67MHFK+pFHeC HyHxG3Xm7Kn0NTU2juRmrQhnIzj4auuTvurfUW7+ntOkSEzMWmLm6nRn/linRhkY58ae ouvIrvB+0vzZ6/h+haYPYB9L3MeD9Z6QO4u+RuQmqgtb/2egseSjMnCQAh+JCe3q1Iez W0FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U7GwZfxNxCr20dXvniV2zLTxrd1PMEcbQZAO6v8SYLo=; b=hxJH8LhllFc/k6FCM/EVTwVa1M9BiutnbDKO5Q+1wV4vZqYFX5ubt26Atn4kLrrWqM 0JHDo4YDPAFqECmVHErPPapGrlW4GlTCb64ujMjo0R+uINltHcHTR30FRv94UpfzumQU Xo7doVcGB2X0f8iULTI1ED0b3e1XMYCi8fv5oGK873+AZ6BSkMjAdv7PR7+xLXpSW9Ep 2pWgVib8GQtbOafaq/KynRS8mCJ9lqk9m9SMjMNCPUy/z68eOM9PwmMplPOye76Z1XC/ I0XyYdGynCx5pSXQo17ik3LD0sa3IdSI/ITKJxQVKMpkKfehIzIgFQdfK/8s0K6FgbsJ HMww== X-Gm-Message-State: AOAM532zC2DUFbyrzZkXQgWFmMyUYacLzUWI6BT70TJEfkgOeg89DmJ+ AW2OzBLDHHO/yDhutEvkGWsxA0iVJPOyemAS9DzN7Q== X-Google-Smtp-Source: ABdhPJxhLzTgLf/Ks/AB0pes6BWh4ozeKIdS874CsMwC+xluHukgX/fubue2dWWqxRl4fMNT+Iw0yiN5ImWbON3APeU= X-Received: by 2002:a05:600c:4f93:b0:393:f08d:a048 with SMTP id n19-20020a05600c4f9300b00393f08da048mr4023212wmq.158.1651249557596; Fri, 29 Apr 2022 09:25:57 -0700 (PDT) MIME-Version: 1.0 References: <20220427184716.1949239-1-kaleshsingh@google.com> <20220427184716.1949239-2-kaleshsingh@google.com> In-Reply-To: From: Kalesh Singh Date: Fri, 29 Apr 2022 09:25:46 -0700 Message-ID: Subject: Re: [PATCH 1/4] KVM: arm64: Compile stacktrace.nvhe.o To: Mark Brown Cc: Mark Rutland , Will Deacon , Marc Zyngier , Quentin Perret , Fuad Tabba , Suren Baghdasaryan , "Cc: Android Kernel" , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Masami Hiramatsu , Peter Collingbourne , Alexei Starovoitov , "Madhavan T. Venkataraman" , Andrew Jones , Zenghui Yu , Keir Fraser , Kefeng Wang , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , kvmarm , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220429_092604_074384_F6852CB8 X-CRM114-Status: GOOD ( 23.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 29, 2022 at 5:47 AM Mark Brown wrote: > > On Wed, Apr 27, 2022 at 11:46:56AM -0700, Kalesh Singh wrote: > > > Recompile stack unwinding code for use with the nVHE hypervisor. This is > > a preparatory patch that will allow reusing most of the kernel unwinding > > logic in the nVHE hypervisor. > > This is substantially more than just the build change that the changelog > would seem to indicate... it would I think be clearer to split this up > further with the code changes separated out and explained a bit more. > It's not just recompling the code for nVHE, there's also refactoring to > split out changes that don't apply in nVHE hypervisor like all the task > related code which is needed but not mentioned in the changlog at all. > Possibly a patch or two for the code motion then a separate patch for > the ifdefs and build changes? Hi Mark, Thank you for reviewing. I agree - will split this into more incremental patches in the next version. Thanks, Kalesh > > I *think* the code is all fine but I'd need to go through it a few more > times to be sure I didn't miss anything. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel