All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Masahisa Kojima <masahisa.kojima@linaro.org>,
	u-boot@lists.denx.de,  Simon Glass <sjg@chromium.org>,
	Alexander Graf <agraf@csgraf.de>
Subject: Re: [PATCH 1/2] efi_loader: add missing const qualifier
Date: Sat, 23 Oct 2021 20:21:36 +0300	[thread overview]
Message-ID: <CAC_iWj+oSLGF7B=Zb=qKqZDspjL6XZxSpOHJ=vAQWfvpDGKLxQ@mail.gmail.com> (raw)
In-Reply-To: <59f7db9e-3c8e-2eba-f908-01d4822b4bcf@gmx.de>

On Sat, 23 Oct 2021 at 11:40, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 10/22/21 13:24, Masahisa Kojima wrote:
> > This commit fixes the following compilation warning
> > of boottime->install_configuration_table() function.
> >
> > ---
> > lib/efi_selftest/efi_selftest_tcg2.c:475:46:
> > warning: passing argument 1 of ‘boottime->install_configuration_table’
> > discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> >    ret = boottime->install_configuration_table(&smbios_guid, dmi);
> > ---
> >
> > Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
>
> The first --- separates the commit message from the rest of the patch:
>
> $ scripts/checkpatch.pl 0001-efi_loader-add-missing-const-qualifier.patch
> ERROR: Missing Signed-off-by: line by nominal patch author 'Masahisa
> Kojima <masahisa.kojima@linaro.org>'
>
> I will reformat the commit message when merging.
>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

  reply	other threads:[~2021-10-23 17:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 11:24 [PATCH 0/2] add selftest for EFI_TCG2_PROTOCOL and Measured Boot Masahisa Kojima
2021-10-22 11:24 ` [PATCH 1/2] efi_loader: add missing const qualifier Masahisa Kojima
2021-10-23  8:40   ` Heinrich Schuchardt
2021-10-23 17:21     ` Ilias Apalodimas [this message]
2021-10-22 11:24 ` [PATCH 2/2] efi_selftest: add selftest for EFI_TCG2_PROTOCOL and Measured Boot Masahisa Kojima
2021-10-23  9:42   ` Heinrich Schuchardt
2021-10-25  7:59     ` Masahisa Kojima
2021-10-25  9:43       ` Heinrich Schuchardt
2021-10-30  6:02         ` Ilias Apalodimas
2021-10-30  6:13           ` Heinrich Schuchardt
2021-11-01  9:38             ` Masahisa Kojima
2021-10-24 19:54 ` [PATCH 0/2] " Simon Glass
2021-11-02  8:03   ` Masahisa Kojima
2021-11-02 14:55     ` Simon Glass
2021-11-02 16:27       ` Ilias Apalodimas
2021-11-05  2:02         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC_iWj+oSLGF7B=Zb=qKqZDspjL6XZxSpOHJ=vAQWfvpDGKLxQ@mail.gmail.com' \
    --to=ilias.apalodimas@linaro.org \
    --cc=agraf@csgraf.de \
    --cc=masahisa.kojima@linaro.org \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.